From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1hT38D-0006fE-3k for mharc-grub-devel@gnu.org; Tue, 21 May 2019 07:40:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hT38B-0006e7-19 for grub-devel@gnu.org; Tue, 21 May 2019 07:40:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hT386-0002Ea-31 for grub-devel@gnu.org; Tue, 21 May 2019 07:40:30 -0400 Received: from a-painless.mh.aa.net.uk ([81.187.30.51]:52495) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hT384-00024E-3g for grub-devel@gnu.org; Tue, 21 May 2019 07:40:25 -0400 Received: from f.b.1.7.2.1.e.f.f.f.a.c.5.0.a.6.4.1.b.e.2.f.f.b.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:bff2:eb14:6a05:caff:fe12:71bf] helo=riva.pelham.vpn.ucam.org) by a-painless.mh.aa.net.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hT37w-0005lE-7P; Tue, 21 May 2019 12:40:16 +0100 Received: from ns1.pelham.vpn.ucam.org ([172.20.153.2] helo=riva.ucam.org) by riva.pelham.vpn.ucam.org with esmtp (Exim 4.92) (envelope-from ) id 1hT37p-0000qa-AV; Tue, 21 May 2019 12:40:09 +0100 Date: Tue, 21 May 2019 12:40:09 +0100 From: Colin Watson To: The development of GNU GRUB Cc: Olaf Hering Subject: Re: grub.git fails to compiler after gnulib upgrade due to gettext Message-ID: <20190521114009.GA28187@riva.ucam.org> References: <20190520212638.236752eb.olaf@aepfle.de> <20190521092317.4iefbsq3li2544hr@tomti.i.net-space.pl> <20190521113218.1f4733e6.olaf@aepfle.de> <20190521102000.rdpje32vhq5ab7ec@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190521102000.rdpje32vhq5ab7ec@tomti.i.net-space.pl> User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 81.187.30.51 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 May 2019 11:40:32 -0000 On Tue, May 21, 2019 at 12:20:00PM +0200, Daniel Kiper wrote: > On Tue, May 21, 2019 at 11:32:18AM +0200, Olaf Hering wrote: > > Am Tue, 21 May 2019 11:23:17 +0200 > > schrieb Daniel Kiper : > > > Could you tell us more? OS version, etc... > > > > Well, SLES11. But most importantly, the old gettext. Does gettext matter at all with --disable-nls? > > Adding Colin who is the original author. > > Colin, could you take a look at this thread? While gettext probably doesn't massively matter at configure time with --disable-nls, its Autoconf macros do need to *exist* in order to build the configure script, and we need to pick a version of those macros. This is formally a maintainer operation and is expected to be able to rely on reasonably current tools, so I think a version that's nearly six years old isn't too unreasonable. The requirement in bootstrap is necessary in order to satisfy the version of the gettext macros that's pinned in configure.ac (having a newer version installed is OK because gettext ships an archive with lots of older versions of its macros, but having an older version installed won't work). You can apply the following patch locally to use an earlier version of the gettext macros, but we shouldn't do this upstream because it would mean that the configure script we distribute in tarballs would use the older version, and hence lose out on bug fixes from the newer version. In particular, versions of the gettext macros older than 0.18.2 don't work with Automake >= 1.14, and since that was released in June 2013 maintainers will typically have at least that version installed when generating tarballs. diff --git a/bootstrap.conf b/bootstrap.conf index 988dda099..a3193a93e 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -67,7 +67,7 @@ SKIP_PO=t buildreq="\ autoconf 2.63 automake 1.11 -gettext 0.18.3 +gettext 0.17 git 1.5.5 tar - " diff --git a/configure.ac b/configure.ac index 08b518fcc..99f5b364d 100644 --- a/configure.ac +++ b/configure.ac @@ -362,7 +362,7 @@ AC_CHECK_PROG(HAVE_CXX, $CXX, yes, no) AC_GNU_SOURCE AM_GNU_GETTEXT([external]) -AM_GNU_GETTEXT_VERSION([0.18.3]) +AM_GNU_GETTEXT_VERSION([0.17]) AC_SYS_LARGEFILE # Identify characteristics of the host architecture. -- Colin Watson [cjwatson@debian.org]