All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Richard Weinberger <richard@nod.at>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-mtd@lists.infradead.org, kernel@pengutronix.de,
	Boris Brezillon <bbrezillon@kernel.org>
Subject: Re: [PATCH v2] mtd: rawnand: initialize ntargets with maxchips
Date: Tue, 21 May 2019 11:48:08 +0200	[thread overview]
Message-ID: <20190521114808.76c56e27@xps13> (raw)
In-Reply-To: <20190521114022.2c3bbc77@collabora.com>

Hi Boris,

Boris Brezillon <boris.brezillon@collabora.com> wrote on Tue, 21 May
2019 11:40:22 +0200:

> On Tue, 21 May 2019 11:04:17 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> > On Tue, 2019-05-21 at 08:43:35 UTC, Sascha Hauer wrote:  
> > > memorg->ntargets is initialized with '1'. It should be initialized with
> > > the maxchips argument from nand_scan() instead. Otherwise multi chip
> > > support errors out on the secondary chip selects when trying to call
> > > nand_reset() on them:
> > > 
> > > WARNING: CPU: 0 PID: 1 at drivers/mtd/nand/raw/internals.h:114
> > > nand_reset_op+0x194/0x1c4
> > > 
> > > With this memorg->ntargets is initialized with the maximum number of
> > > chip selects supported by the driver. After having detected the number
> > > of actually connected chips memory->ntargets is updated with that
> > > number.
> > > 
> > > Fixes: 32813e288414 ("mtd: rawnand: Get rid of chip->numchips")
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>    
> > 
> > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.  
> 
> Are you sure it's mtd/next? I'd expect it to be queued in mtd/fixes not
> mtd/next.

Yes, I failed to checkout the right branch :)
I meant mtd/fixes, will move the patch.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2019-05-21  9:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  8:43 [PATCH v2] mtd: rawnand: initialize ntargets with maxchips Sascha Hauer
2019-05-21  8:44 ` Boris Brezillon
2019-05-21  9:04 ` Miquel Raynal
2019-05-21  9:40   ` Boris Brezillon
2019-05-21  9:48     ` Miquel Raynal [this message]
2019-06-21 10:32       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521114808.76c56e27@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=boris.brezillon@collabora.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.