From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>,
wsa@the-dreams.de, linux-i2c@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
benjamin.tissoires@redhat.com, jbroadus@gmail.com,
patches@opensource.cirrus.com,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [PATCH 3/5] i2c: core: Move ACPI IRQ handling to probe time
Date: Tue, 21 May 2019 15:57:04 +0300 [thread overview]
Message-ID: <20190521125704.GF9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190521112728.GX2781@lahna.fi.intel.com>
On Tue, May 21, 2019 at 02:27:28PM +0300, Mika Westerberg wrote:
> On Mon, May 20, 2019 at 09:49:34AM +0100, Charles Keepax wrote:
> > Bring the ACPI path in sync with the device tree path and handle all the
> > IRQ fetching at probe time. This leaves the only IRQ handling at device
> > registration time being that which is passed directly through the board
> > info as either a resource or an actual IRQ number.
>
> I don't see issues with this approach. Cc'd Jarkko and Andy just in case
> I missed something.
I failed to see the i2c_acpi_get_irq() in the current code.
What kernel version do you use?
Can we see the changes against vanilla / i2c-next?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-05-21 12:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 8:49 [PATCH 0/5] I2C IRQ Probe Improvements Charles Keepax
2019-05-20 8:49 ` Charles Keepax
2019-05-20 8:49 ` [PATCH 1/5] i2c: acpi: Factor out getting the IRQ from ACPI Charles Keepax
2019-05-20 8:49 ` Charles Keepax
2019-05-21 11:17 ` Mika Westerberg
2019-05-20 8:49 ` [PATCH 2/5] i2c: acpi: Use available IRQ helper functions Charles Keepax
2019-05-20 8:49 ` Charles Keepax
2019-05-20 8:49 ` [PATCH 3/5] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax
2019-05-20 8:49 ` Charles Keepax
2019-05-21 11:27 ` Mika Westerberg
2019-05-21 12:57 ` Andy Shevchenko [this message]
2019-05-21 13:11 ` Charles Keepax
2019-05-21 13:11 ` Charles Keepax
2019-05-21 13:20 ` Andy Shevchenko
2019-05-20 8:49 ` [PATCH 4/5] i2c: core: Move ACPI gpio IRQ handling into i2c_acpi_get_irq Charles Keepax
2019-05-20 8:49 ` Charles Keepax
2019-05-21 11:37 ` Mika Westerberg
2019-05-20 8:49 ` [PATCH 5/5] i2c: core: Tidy up handling of init_irq Charles Keepax
2019-05-20 8:49 ` Charles Keepax
-- strict thread matches above, loose matches on Subject: below --
2019-05-21 15:04 [PATCH 0/5] I2C IRQ Probe Improvements Charles Keepax
2019-05-21 15:05 ` [PATCH 3/5] i2c: core: Move ACPI IRQ handling to probe time Charles Keepax
2019-05-21 15:05 ` Charles Keepax
2019-05-21 17:18 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521125704.GF9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jbroadus@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@opensource.cirrus.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.