From: Stephen Boyd <sboyd@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>,
Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: linux-clk@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH 1/2] clk: sprd: Switch from of_iomap() to devm_ioremap_resource()
Date: Tue, 21 May 2019 11:57:13 -0700 [thread overview]
Message-ID: <20190521185713.E24632173C@mail.kernel.org> (raw)
In-Reply-To: <CAMz4kuLjOjKGXn7QtOO5Gizo-FZ7CDf2SiczTNPwDgjAKzm2pw@mail.gmail.com>
Quoting Baolin Wang (2019-05-20 23:38:03)
> On Tue, 21 May 2019 at 14:15, Chunyan Zhang <zhang.chunyan@linaro.org> wrote:
> > &sprdclk_regmap_config);
> > - if (IS_ERR_OR_NULL(regmap)) {
> > + if (IS_ERR(regmap)) {
>
> You did not mention this fix in your commit message, and it's better
> to move into one separate patch.
>
Please resend with it split out.
next prev parent reply other threads:[~2019-05-21 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 6:09 [PATCH 0/2] Return immediately if sprd_clk_regmap_init() fails Chunyan Zhang
2019-05-21 6:09 ` [PATCH 1/2] clk: sprd: Switch from of_iomap() to devm_ioremap_resource() Chunyan Zhang
2019-05-21 6:38 ` Baolin Wang
2019-05-21 18:57 ` Stephen Boyd [this message]
2019-05-21 6:09 ` [PATCH 2/2] clk: sprd: Add check for return value of sprd_clk_regmap_init() Chunyan Zhang
2019-05-21 6:38 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521185713.E24632173C@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.chunyan@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.