From: Aleksa Sarai <cyphar@cyphar.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: Aleksa Sarai <cyphar@cyphar.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Rik van Riel <riel@surriel.com>, Nicolai Stange <nstange@suse.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
zfs-devel@list.zfsonlinux.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] x86/fpu: allow kernel_fpu_{begin,end} to be used by non-GPL modules
Date: Wed, 22 May 2019 14:42:04 +1000 [thread overview]
Message-ID: <20190522044204.24207-1-cyphar@cyphar.com> (raw)
Prior to [1], all non-GPL modules were able to make use of SIMD on x86
by making use of the __kernel_fpu_* API. Given that __kernel_fpu_* were
both EXPORT_SYMBOL'd and kernel_fpu_* are such trivial wrappers around
the now-static __kernel_fpu_*, it seems to me that there is no reason to
have different licensing rules for them.
In the case of OpenZFS, the lack of SIMD on newer Linux kernels has
caused significant performance problems (since ZFS uses SIMD for
calculation of blkptr checksums as well as raidz calculations).
[1]: commit 12209993e98c ("x86/fpu: Don't export __kernel_fpu_{begin,end}()")
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
---
arch/x86/kernel/fpu/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c
index 2e5003fef51a..8de5687a470d 100644
--- a/arch/x86/kernel/fpu/core.c
+++ b/arch/x86/kernel/fpu/core.c
@@ -127,14 +127,14 @@ void kernel_fpu_begin(void)
preempt_disable();
__kernel_fpu_begin();
}
-EXPORT_SYMBOL_GPL(kernel_fpu_begin);
+EXPORT_SYMBOL(kernel_fpu_begin);
void kernel_fpu_end(void)
{
__kernel_fpu_end();
preempt_enable();
}
-EXPORT_SYMBOL_GPL(kernel_fpu_end);
+EXPORT_SYMBOL(kernel_fpu_end);
/*
* Save the FPU state (mark it for reload if necessary):
--
2.21.0
next reply other threads:[~2019-05-22 4:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 4:42 Aleksa Sarai [this message]
2019-05-22 10:09 ` [PATCH] x86/fpu: allow kernel_fpu_{begin,end} to be used by non-GPL modules Greg KH
2019-05-23 16:52 ` [zfs-devel] " Mason Loring Bliss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522044204.24207-1-cyphar@cyphar.com \
--to=cyphar@cyphar.com \
--cc=Jason@zx2c4.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nstange@suse.de \
--cc=riel@surriel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zfs-devel@list.zfsonlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.