From: Jeremy Sowden <jeremy@azazel.net>
To: Fabio Lima <fabiolima39@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH] staging: rtl8723bs: Add missing blank lines
Date: Wed, 22 May 2019 08:57:16 +0100 [thread overview]
Message-ID: <20190522075716.GA16243@azazel.net> (raw)
In-Reply-To: <20190522004655.20138-1-fabiolima39@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
On 2019-05-21, at 21:46:55 -0300, Fabio Lima wrote:
> This patch resolves the following warning from checkpatch.pl
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Fabio Lima <fabiolima39@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_debug.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_debug.c b/drivers/staging/rtl8723bs/core/rtw_debug.c
> index 9f8446ccf..853362381 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_debug.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_debug.c
> @@ -382,6 +382,7 @@ ssize_t proc_set_roam_tgt_addr(struct file *file, const char __user *buffer, siz
> if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) {
>
> int num = sscanf(tmp, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx", addr, addr+1, addr+2, addr+3, addr+4, addr+5);
> +
> if (num == 6)
> memcpy(adapter->mlmepriv.roam_tgt_addr, addr, ETH_ALEN);
>
> @@ -1348,6 +1349,7 @@ int proc_get_btcoex_dbg(struct seq_file *m, void *v)
> struct net_device *dev = m->private;
> struct adapter *padapter;
> char buf[512] = {0};
> +
> padapter = (struct adapter *)rtw_netdev_priv(dev);
>
> rtw_btcoex_GetDBG(padapter, buf, 512);
> --
> 2.11.0
Looks good to me.
J.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-05-22 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 0:46 [PATCH] staging: rtl8723bs: Add missing blank lines Fabio Lima
2019-05-22 7:57 ` Jeremy Sowden [this message]
2019-05-22 9:41 ` Dan Carpenter
2019-05-29 0:18 ` Fabio Lima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522075716.GA16243@azazel.net \
--to=jeremy@azazel.net \
--cc=devel@driverdev.osuosl.org \
--cc=fabiolima39@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.