From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jan Luebbe <jlu@pengutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
John Ogness <john.ogness@linutronix.de>,
Andy Lutomirski <luto@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] proc: report eip and esp for all threads when coredumping
Date: Wed, 22 May 2019 20:13:27 +0300 [thread overview]
Message-ID: <20190522171327.GA2111@avx2> (raw)
In-Reply-To: <20190522161614.628-1-jlu@pengutronix.de>
On Wed, May 22, 2019 at 06:16:14PM +0200, Jan Luebbe wrote:
> --- a/fs/proc/array.c
> +++ b/fs/proc/array.c
> @@ -462,7 +462,7 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
> * a program is not able to use ptrace(2) in that case. It is
> * safe because the task has stopped executing permanently.
> */
> - if (permitted && (task->flags & PF_DUMPCORE)) {
> + if (permitted && (!!mm->core_state)) {
You don't need both "!!" and "()", it is a regular pointer after all.
next prev parent reply other threads:[~2019-05-22 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 16:16 [PATCH] proc: report eip and esp for all threads when coredumping Jan Luebbe
2019-05-22 17:13 ` Alexey Dobriyan [this message]
2019-05-22 18:00 ` Andrew Morton
2019-05-23 8:15 ` Jan Lübbe
2019-05-24 23:50 ` John Ogness
[not found] ` <20190525143220.e771b7915d17f22dad1438fa@linux-foundation.org>
2019-05-26 19:41 ` John Ogness
2019-05-29 8:55 ` [PATCHv2] fs/proc: allow reporting eip/esp for all coredumping threads John Ogness
2019-05-29 21:55 ` Andrew Morton
2019-05-30 0:58 ` [PATCHv3] " John Ogness
2019-05-30 1:14 ` Andrew Morton
2019-06-03 19:54 ` Jan Lübbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190522171327.GA2111@avx2 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jlu@pengutronix.de \
--cc=john.ogness@linutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.