From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH] drm/i915: Fix the interpretation of MAX_PRE-EMPHASIS_REACHED bit inorder to pass Link Layer compliance test number 400.3.1.15 Date: Wed, 22 May 2019 12:25:13 -0700 Message-ID: <20190522192512.GB2502@intel.com> References: <20190520232541.16085-1-khaled.almahallawy@intel.com> <20190521132458.GZ24299@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B3B1989BA3 for ; Wed, 22 May 2019 19:23:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190521132458.GZ24299@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXkgMjEsIDIwMTkgYXQgMDQ6MjQ6NThQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIE1vbiwgTWF5IDIwLCAyMDE5IGF0IDA0OjI1OjQxUE0gLTA3MDAsIEtoYWxl ZCBBbG1haGFsbGF3eSB3cm90ZToKPiA+IEFjY29yZGluZyB0byBEUCAxLjQgc3RhbmRhcmQsIGlm IHRoZSBzb3VyY2Ugc3VwcG9ydHMgZm91ciBwcmUtZW1waGFzaXMgbGV2ZWxzLCB0aGVuIHRoZSBz b3VyY2Ugc2hhbGwgc2V0IHRoZSBiaXQgTUFYX1BSRS1FTVBIQVNJU19SRUFDSEVEID0gMSBvbmx5 IHdoZW4gdHJhc21pdHRlciBwcm9ncmFtbWVkIFBSRS1FTVBIQVNJU19TRVQgZmllbGQgKGJpdHMg NDozKSB0byAxMWIgKExldmVsIDMpLiBQcmUtZW1waGFzaXMgbGV2ZWwgMyBpcyB0aGUgbWF4aW11 bSBwcmUtZW1waGFzaXMgbGV2ZWwgdGhhdCB0aGUgc291cmNlIHN1cHBvcnRzLgo+ID4gQ3VycmVu dGx5IHRoZSBNQVhfUFJFLUVNUEhBU0lTX1JFQUNIRUQgYml0IGlzIGludGVycHJldGVkIGFzIHRo ZSBNYXggUHJlLUVtcGhhc2lzIGxldmVsIGZvciBjZXJ0YWluIFN3aW5nIExldmVsLiBUaGlzIGlu dGVycHJldGF0aW9uIGZhaWxzIExpbmsgTGF5ZXIgY29tcGxpYW5jZSB0ZXN0IDQwMC4zLjEuMTUg c3RlcCAxNyBhY2NvcmRpbmcgdG8gdGhlIGZvbGxvd2luZyBGYWlsIGNvbmRpdGlvbjogVFJBSU5J TkdfTEFORXhfU0VULk1BWF9QUkUtRU1QSEFTSVNfUkVBQ0hFRCA9IDEgKGNoZWNrIGFsbCBhY3Rp dmUgbGFuZXMpIGFuZCB0aGUgU291cmNlIERVVCBzdXBwb3J0cyBwcmUtZW1waGFzaXMgbGV2ZWwg MyAoOS41ZGIpLgo+IAo+IEhtbS4gSSBndWVzcyB0aGF0J3MgY29ycmVjdC4gVGhlIHNwZWMgZG9l c24ndCBzYXkgYW55dGhpbmcgYWJvdXQKPiBwZXItdnN3aW5nIHByZS1lbXBoYXNpcyB3aGVuIHRh bGtpbmcgYWJvdXQgdGhlICdtYXggcmVhY2hlZCcgYml0Lgo+IAo+ID4gCj4gPiBDYzogQ2xpbnQg VGF5bG9yIDxDbGludG9uLkEuVGF5bG9yQGludGVsLmNvbT4KPiA+IENjOiBNYW5hc2kgTmF2YXJl IDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogS2hhbGVkIEFs bWFoYWxsYXd5IDxraGFsZWQuYWxtYWhhbGxhd3lAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgfCAyMCAtLS0tLS0tLS0tLS0tLS0tLS0tLQo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgIHwgIDIgKy0KPiA+ICAyIGZpbGVz IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyMSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGRpLmMKPiA+IGluZGV4IDBhZjQ3ZjM0M2ZhYS4uNjU0MGM5NzljMDk4IDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiBAQCAtMjIzOSwyNiArMjIzOSw2 IEBAIHU4IGludGVsX2RkaV9kcF92b2x0YWdlX21heChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5j b2RlcikKPiA+ICAJCURQX1RSQUlOX1ZPTFRBR0VfU1dJTkdfTUFTSzsKPiA+ICB9Cj4gPiAgCj4g PiAtLyoKPiA+IC0gKiBXZSBhc3N1bWUgdGhhdCB0aGUgZnVsbCBzZXQgb2YgcHJlLWVtcGhhc2lz IHZhbHVlcyBjYW4gYmUKPiA+IC0gKiB1c2VkIG9uIGFsbCBEREkgcGxhdGZvcm1zLiBTaG91bGQg dGhhdCBjaGFuZ2Ugd2UgbmVlZCB0bwo+ID4gLSAqIHJldGhpbmsgdGhpcyBjb2RlLgo+ID4gLSAq Lwo+ID4gLXU4IGludGVsX2RkaV9kcF9wcmVfZW1waGFzaXNfbWF4KHN0cnVjdCBpbnRlbF9lbmNv ZGVyICplbmNvZGVyLCB1OCB2b2x0YWdlX3N3aW5nKQo+ID4gLXsKPiA+IC0Jc3dpdGNoICh2b2x0 YWdlX3N3aW5nICYgRFBfVFJBSU5fVk9MVEFHRV9TV0lOR19NQVNLKSB7Cj4gPiAtCWNhc2UgRFBf VFJBSU5fVk9MVEFHRV9TV0lOR19MRVZFTF8wOgo+ID4gLQkJcmV0dXJuIERQX1RSQUlOX1BSRV9F TVBIX0xFVkVMXzM7Cj4gPiAtCWNhc2UgRFBfVFJBSU5fVk9MVEFHRV9TV0lOR19MRVZFTF8xOgo+ ID4gLQkJcmV0dXJuIERQX1RSQUlOX1BSRV9FTVBIX0xFVkVMXzI7Cj4gPiAtCWNhc2UgRFBfVFJB SU5fVk9MVEFHRV9TV0lOR19MRVZFTF8yOgo+ID4gLQkJcmV0dXJuIERQX1RSQUlOX1BSRV9FTVBI X0xFVkVMXzE7Cj4gPiAtCWNhc2UgRFBfVFJBSU5fVk9MVEFHRV9TV0lOR19MRVZFTF8zOgo+ID4g LQlkZWZhdWx0Ogo+ID4gLQkJcmV0dXJuIERQX1RSQUlOX1BSRV9FTVBIX0xFVkVMXzA7Cj4gPiAt CX0KPiA+IC19Cj4gPiAtCj4gPiAgc3RhdGljIHZvaWQgY25sX2RkaV92c3dpbmdfcHJvZ3JhbShz dHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+ICAJCQkJICAgaW50IGxldmVsLCBlbnVt IGludGVsX291dHB1dF90eXBlIHR5cGUpCj4gPiAgewo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5j Cj4gPiBpbmRleCA3N2JhNGRhNmI5ODEuLmY5NDc1OWU0NTg2MiAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMKPiA+IEBAIC0zNTQxLDcgKzM1NDEsNyBAQCBpbnRlbF9kcF9wcmVfZW1w aGFzaXNfbWF4KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHU4IHZvbHRhZ2Vfc3dpbmcpCj4g PiAgCWVudW0gcG9ydCBwb3J0ID0gZW5jb2Rlci0+cG9ydDsKPiA+ICAKPiA+ICAJaWYgKEhBU19E REkoZGV2X3ByaXYpKSB7Cj4gPiAtCQlyZXR1cm4gaW50ZWxfZGRpX2RwX3ByZV9lbXBoYXNpc19t YXgoZW5jb2Rlciwgdm9sdGFnZV9zd2luZyk7Cj4gPiArCQlyZXR1cm4gRFBfVFJBSU5fUFJFX0VN UEhfTEVWRUxfMzsKPiAKPiBXZSdyZSBnb2luZyB0byBoYXZlIHRvIGNoYW5nZSB0aGlzIGZvciBh bGwgcGxhdGZvcm1zLgo+IAo+IEFsc28gd2UgbmVlZCB0byB1cGRhdGUgdGhlIGNvZGUgdG8gcGlj ayB0aGUgY29ycmVjdCBzd2luZy9wcmUtZW1waGFzaXMKPiB3aGVuIHdlIGNhbid0IGRvIHdoYXQg aXMgYmVpbmcgcmVxdWVzdGVkLgoKVGhpcyBjaGVjayB3aWxsIG5lZWQgdG8gYmUgYWRkZWQgaW4g YWRqdXN0X3RyYWluKCkgZnVuY3Rpb24KCj4gCj4gVGhlIHNwZWMgc2F5czoKPiAiV2hlbiB0aGUg Y29tYmluYXRpb24gb2YgdGhlIHJlcXVlc3RlZCBwcmUtZW1waGFzaXMgbGV2ZWwgYW5kIHZvbHRh Z2UKPiAgc3dpbmcgZXhjZWVkcyB0aGUgY2FwYWJpbGl0eSBvZiBhIERQVFgsIHRoZSBEUFRYIHNo YWxsIHNldCB0aGUgcHJlLWVtcGhhc2lzCj4gIGxldmVsIGFjY29yZGluZyB0byB0aGUgcmVxdWVz dCBhbmQgdXNlIHRoZSBoaWdoZXN0IHZvbHRhZ2Ugc3dpbmcgaXQgY2FuCj4gIG91dHB1dCB3aXRo IHRoZSBnaXZlbiBwcmUtZW1waGFzaXMgbGV2ZWwuIgo+IGFuZAo+ICJXaGVuIGEgRFBUWCByZWFk cyBhIHJlcXVlc3QgYmV5b25kIHRoZSBsaW1pdHMgb2YgdGhpcyBTdGFuZGFyZCwgdGhlCj4gIERQ VFggc2hhbGwgc2V0IHRoZSBwcmUtZW1waGFzaXMgbGV2ZWwgYWNjb3JkaW5nIHRvIHRoZSByZXF1 ZXN0IGFuZCBzZXQKPiAgdGhlIGhpZ2hlc3Qgdm9sdGFnZSBzd2luZyBsZXZlbCBpdCBjYW4gb3V0 cHV0IHdpdGggdGhlIGdpdmVuIHByZS1lbXBoYXNpcwo+ICBsZXZlbC4gSWYgYSBEUFRYIGlzIHJl cXVlc3RlZCBmb3IgOS41ZEIgb2YgcHJlLWVtcGhhc2lzIGxldmVsIChtYXkgYmUgCj4gIHN1cHBv cnRlZCBmb3IgYSBEUFRYKSBhbmQgY2Fubm90IHN1cHBvcnQgdGhhdCBsZXZlbCwgaXQgc2hhbGwg c2V0IHRoZQo+ICBwcmUtZW1waGFzaXMgbGV2ZWwgdG8gdGhlIG5leHQgaGlnaGVzdCBsZXZlbCwg NmRCLiIKClNvIG15IGludGVycHJldGF0aW9uIG9mIHRoaXMgaXMgOgoKSW4gYWRqdXN0X3RyYWlu KCkgZnVuY3Rpb246Cgp2c3dpbmdfbWF4ID0gaW50ZWxfZHBfdm9sdGFnZV9tYXgoKSB3aGljaCBp cyBzZXQgcGVyIHBsYXRmb3JtCnByZV9lbXBoYXNpc19tYXggPSBzZXQgdG8gbGV2ZWwgMyAKIAp2 ID0gZ2V0X3JlcXVlc3RlZF92b2x0YWdlX3N3aW5nKCkgLSBMaW1pdCB0aGlzIHRvIHZtYXgKcCA9 IGdldF9yZXF1ZXN0ZWRfcHJlX2VtcGhhc2lzKCkgLSBMaW1pdCB0aGlzIHRvIHBtYXgKCk5vdyBy ZXdyaXRlIHRoZSBpbnRlbF9kZGlfZHBfcHJlX2VtcGhhc2lzX21heCgpIGZ1bmN0aW9uIHRvIGNh bGwgaXQgaW50ZWxfZGRpX2RwX3Bvc3NpYmxlX3Zzd2luZ19tYXgoKQp3aGVyZSB3ZSBzZXQgdGhl IHBvc3NpYmxlIHZzd2luZyBtYXggYmFzZWQgb24gcmVxdWVzdGVkIHByZSBlbXBoYXNpcyBhbmQg dGFibGUgaW4gdGhlIGJzcGVjCkVnOiBpZiByZXF1ZXN0ZWQgcHJlIGVtcGhhc2lzIGlzIDMsIHRo ZSB2c3dpbmcgaXMgMCB3aGljaCBpcyB0aGUgbWF4IHZzd2luZyB2YWx1ZQppdCBjYW4gb3VwdXQg d2l0aCB0aGF0IHByZSBlbXBoYXNpcyBsZXZlbCBiYXNlZCBvbiB0aGUgYnNwZWMgdnN3aW5nIHBy b2dyYW1taW5nIHZhbHVlcwoKU2V0IHYgPSB0aGF0IHZhbHVlCnAgPSByZXF1ZXN0ZWQKCkxpbmsg dHJhaW4KClZpbGxlLCBpcyB0aGlzIGxvZ2ljIGNvcnJlY3Q/IAoKUmVnYXJkcwpNYW5hc2kKCgo+ IAo+IAo+IAo+ID4gIAl9IGVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NI RVJSWVZJRVcoZGV2X3ByaXYpKSB7Cj4gPiAgCQlzd2l0Y2ggKHZvbHRhZ2Vfc3dpbmcgJiBEUF9U UkFJTl9WT0xUQUdFX1NXSU5HX01BU0spIHsKPiA+ICAJCWNhc2UgRFBfVFJBSU5fVk9MVEFHRV9T V0lOR19MRVZFTF8wOgo+ID4gLS0gCj4gPiAyLjE3LjEKPiA+IAo+ID4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gVmls bGUgU3lyasOkbMOkCj4gSW50ZWwKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4