From: Christoph Hellwig <hch@lst.de>
To: "Koenig, Christian" <Christian.Koenig@amd.com>
Cc: Christoph Hellwig <hch@lst.de>,
Logan Gunthorpe <logang@deltatee.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI/P2PDMA: Root complex whitelist should not apply when an IOMMU is present
Date: Thu, 23 May 2019 12:26:08 +0200 [thread overview]
Message-ID: <20190523102608.GA15800@lst.de> (raw)
In-Reply-To: <b09d61f0-cc6d-5043-1cb3-6891e589a872@amd.com>
On Thu, May 23, 2019 at 10:06:28AM +0000, Koenig, Christian wrote:
> Ok, we certainly don't have a system which exercise this user case.
> Could ask around if we have an ARM SOC with that properties somewhere.
>
> But asking the other way around: Where is the right place to start
> fixing all this? dma_map_resource()?
That is the the big gorrilla in the room. The offset applies to the
device whos BARs/resources we map. The current dma_map_resource API
does not even have the right information. So I think we need to
enhance the API to pass a second struct device and we could fix it
there and then in the next steps add a map_sg version of
dma_map_resource and eventually also convert the PCIe P2P map_sg
over to that.
next prev parent reply other threads:[~2019-05-23 10:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a98bff67-a76e-4ddc-a317-96f2bdc9af72@email.android.com>
2019-05-22 20:41 ` [PATCH] PCI/P2PDMA: Root complex whitelist should not apply when an IOMMU is present Logan Gunthorpe
2019-05-23 8:12 ` Koenig, Christian
2019-05-23 9:43 ` Christoph Hellwig
2019-05-23 9:48 ` Koenig, Christian
2019-05-23 9:50 ` Christoph Hellwig
2019-05-23 10:06 ` Koenig, Christian
2019-05-23 10:26 ` Christoph Hellwig [this message]
2019-05-23 15:59 ` Logan Gunthorpe
2019-05-23 15:53 ` Logan Gunthorpe
2019-05-23 15:59 ` Christoph Hellwig
2019-05-24 12:40 ` Koenig, Christian
2019-05-24 14:12 ` Christoph Hellwig
2019-05-24 16:18 ` Logan Gunthorpe
2019-05-24 16:06 ` Logan Gunthorpe
2019-05-23 16:14 ` Logan Gunthorpe
2019-05-23 15:47 ` Logan Gunthorpe
2019-05-22 20:12 Logan Gunthorpe
2019-06-18 20:40 ` Bjorn Helgaas
2019-06-18 20:51 ` Logan Gunthorpe
2019-06-18 23:50 ` Logan Gunthorpe
2019-06-19 9:26 ` Koenig, Christian
2019-06-19 9:29 ` Christoph Hellwig
2019-06-19 9:39 ` Koenig, Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523102608.GA15800@lst.de \
--to=hch@lst.de \
--cc=Christian.Koenig@amd.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.