From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: Check DDM existence in transceiver before access
Date: Thu, 23 May 2019 14:20:17 -0700 [thread overview]
Message-ID: <20190523142017.00005c59@intel.com> (raw)
In-Reply-To: <20190523191112.14572-1-maurosr@linux.vnet.ibm.com>
On Thu, 23 May 2019 16:11:12 -0300 Mauro wrote:
> Some transceivers may comply with SFF-8472 but not implement the Digital
> Diagnostic Monitoring (DDM) interface described in it. The existence of
> such area is specified by bit 6 of byte 92, set to 1 if implemented.
>
> Currently, due to not checking this bit ixgbe fails trying to read sfp
> module's eeprom with the follow message:
>
> ethtool -m enP51p1s0f0
> Cannot get Module EEPROM data: Input/output error
>
> Because it fails to read the additional 256 bytes in which it was assumed
> to exist the DDM data.
>
> This issue was noticed using a Mellanox Passive DAC PN 01FT738. The eeprom
> data was confirmed by Mellanox as correct and present in other Passive
> DACs in from other manufacturers.
>
> Signed-off-by: Mauro S. M. Rodrigues <maurosr@linux.vnet.ibm.com>
Looks reasonable, thanks for the patch!
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2019-05-23 21:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 19:11 [Intel-wired-lan] [PATCH] ixgbe: Check DDM existence in transceiver before access Mauro S. M. Rodrigues
2019-05-23 21:20 ` Jesse Brandeburg [this message]
2019-06-13 21:27 ` Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523142017.00005c59@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.