From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 891F0C282DD for ; Thu, 23 May 2019 16:19:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65ED92175B for ; Thu, 23 May 2019 16:19:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731662AbfEWQTW (ORCPT ); Thu, 23 May 2019 12:19:22 -0400 Received: from tartarus.angband.pl ([54.37.238.230]:38484 "EHLO tartarus.angband.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731117AbfEWQTV (ORCPT ); Thu, 23 May 2019 12:19:21 -0400 Received: from kilobyte by tartarus.angband.pl with local (Exim 4.92) (envelope-from ) id 1hTqQv-0002uo-JE; Thu, 23 May 2019 18:19:09 +0200 Date: Thu, 23 May 2019 18:19:09 +0200 From: Adam Borowski To: Jan Kara Cc: Goldwyn Rodrigues , linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, david@fromorbit.com, willy@infradead.org, hch@lst.de, darrick.wong@oracle.com, dsterba@suse.cz, nborisov@suse.com, linux-nvdimm@lists.01.org, Goldwyn Rodrigues Subject: Re: [PATCH 12/18] btrfs: allow MAP_SYNC mmap Message-ID: <20190523161909.GA10771@angband.pl> References: <20190429172649.8288-1-rgoldwyn@suse.de> <20190429172649.8288-13-rgoldwyn@suse.de> <20190523134449.GC2949@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190523134449.GC2949@quack2.suse.cz> X-Junkbait: aaron@angband.pl, zzyx@angband.pl User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: kilobyte@angband.pl X-SA-Exim-Scanned: No (on tartarus.angband.pl); SAEximRunCond expanded to false Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, May 23, 2019 at 03:44:49PM +0200, Jan Kara wrote: > On Mon 29-04-19 12:26:43, Goldwyn Rodrigues wrote: > > From: Adam Borowski > > > > Used by userspace to detect DAX. > > [rgoldwyn@suse.com: Added CONFIG_FS_DAX around mmap_supported_flags] > > Why the CONFIG_FS_DAX bit? Your mmap(2) implementation understands > implications of MAP_SYNC flag and that's all that's needed to set > .mmap_supported_flags. Good point. Also, that check will need to be updated when the pmem-virtio patchset goes in. > > Signed-off-by: Adam Borowski > > Signed-off-by: Goldwyn Rodrigues > > --- > > fs/btrfs/file.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c > > index 9d5a3c99a6b9..362a9cf9dcb2 100644 > > --- a/fs/btrfs/file.c > > +++ b/fs/btrfs/file.c > > @@ -16,6 +16,7 @@ > > #include > > #include > > #include > > +#include > > #include "ctree.h" > > #include "disk-io.h" > > #include "transaction.h" > > @@ -3319,6 +3320,9 @@ const struct file_operations btrfs_file_operations = { > > .splice_read = generic_file_splice_read, > > .write_iter = btrfs_file_write_iter, > > .mmap = btrfs_file_mmap, > > +#ifdef CONFIG_FS_DAX > > + .mmap_supported_flags = MAP_SYNC, > > +#endif > > .open = btrfs_file_open, > > .release = btrfs_release_file, > > .fsync = btrfs_sync_file, > > -- > > 2.16.4 > > > -- > Jan Kara > SUSE Labs, CR > -- ⢀⣴⠾⠻⢶⣦⠀ Latin: meow 4 characters, 4 columns, 4 bytes ⣾⠁⢠⠒⠀⣿⡁ Greek: μεου 4 characters, 4 columns, 8 bytes ⢿⡄⠘⠷⠚⠋ Runes: ᛗᛖᛟᚹ 4 characters, 4 columns, 12 bytes ⠈⠳⣄⠀⠀⠀⠀ Chinese: 喵 1 character, 2 columns, 3 bytes <-- best! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tartarus.angband.pl (tartarus.angband.pl [IPv6:2001:41d0:602:dbe::8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0F4C321276B81 for ; Thu, 23 May 2019 09:19:31 -0700 (PDT) Date: Thu, 23 May 2019 18:19:09 +0200 From: Adam Borowski Subject: Re: [PATCH 12/18] btrfs: allow MAP_SYNC mmap Message-ID: <20190523161909.GA10771@angband.pl> References: <20190429172649.8288-1-rgoldwyn@suse.de> <20190429172649.8288-13-rgoldwyn@suse.de> <20190523134449.GC2949@quack2.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190523134449.GC2949@quack2.suse.cz> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Jan Kara Cc: darrick.wong@oracle.com, nborisov@suse.com, Goldwyn Rodrigues , linux-nvdimm@lists.01.org, david@fromorbit.com, dsterba@suse.cz, willy@infradead.org, Goldwyn Rodrigues , linux-fsdevel@vger.kernel.org, hch@lst.de, linux-btrfs@vger.kernel.org List-ID: T24gVGh1LCBNYXkgMjMsIDIwMTkgYXQgMDM6NDQ6NDlQTSArMDIwMCwgSmFuIEthcmEgd3JvdGU6 Cj4gT24gTW9uIDI5LTA0LTE5IDEyOjI2OjQzLCBHb2xkd3luIFJvZHJpZ3VlcyB3cm90ZToKPiA+ IEZyb206IEFkYW0gQm9yb3dza2kgPGtpbG9ieXRlQGFuZ2JhbmQucGw+Cj4gPiAKPiA+IFVzZWQg YnkgdXNlcnNwYWNlIHRvIGRldGVjdCBEQVguCj4gPiBbcmdvbGR3eW5Ac3VzZS5jb206IEFkZGVk IENPTkZJR19GU19EQVggYXJvdW5kIG1tYXBfc3VwcG9ydGVkX2ZsYWdzXQo+IAo+IFdoeSB0aGUg Q09ORklHX0ZTX0RBWCBiaXQ/IFlvdXIgbW1hcCgyKSBpbXBsZW1lbnRhdGlvbiB1bmRlcnN0YW5k cwo+IGltcGxpY2F0aW9ucyBvZiBNQVBfU1lOQyBmbGFnIGFuZCB0aGF0J3MgYWxsIHRoYXQncyBu ZWVkZWQgdG8gc2V0Cj4gLm1tYXBfc3VwcG9ydGVkX2ZsYWdzLgoKR29vZCBwb2ludC4KCkFsc28s IHRoYXQgY2hlY2sgd2lsbCBuZWVkIHRvIGJlIHVwZGF0ZWQgd2hlbiB0aGUgcG1lbS12aXJ0aW8g cGF0Y2hzZXQgZ29lcwppbi4KCj4gPiBTaWduZWQtb2ZmLWJ5OiBBZGFtIEJvcm93c2tpIDxraWxv Ynl0ZUBhbmdiYW5kLnBsPgo+ID4gU2lnbmVkLW9mZi1ieTogR29sZHd5biBSb2RyaWd1ZXMgPHJn b2xkd3luQHN1c2UuY29tPgo+ID4gLS0tCj4gPiAgZnMvYnRyZnMvZmlsZS5jIHwgNCArKysrCj4g PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEv ZnMvYnRyZnMvZmlsZS5jIGIvZnMvYnRyZnMvZmlsZS5jCj4gPiBpbmRleCA5ZDVhM2M5OWE2Yjku LjM2MmE5Y2Y5ZGNiMiAxMDA2NDQKPiA+IC0tLSBhL2ZzL2J0cmZzL2ZpbGUuYwo+ID4gKysrIGIv ZnMvYnRyZnMvZmlsZS5jCj4gPiBAQCAtMTYsNiArMTYsNyBAQAo+ID4gICNpbmNsdWRlIDxsaW51 eC9idHJmcy5oPgo+ID4gICNpbmNsdWRlIDxsaW51eC91aW8uaD4KPiA+ICAjaW5jbHVkZSA8bGlu dXgvaXZlcnNpb24uaD4KPiA+ICsjaW5jbHVkZSA8bGludXgvbW1hbi5oPgo+ID4gICNpbmNsdWRl ICJjdHJlZS5oIgo+ID4gICNpbmNsdWRlICJkaXNrLWlvLmgiCj4gPiAgI2luY2x1ZGUgInRyYW5z YWN0aW9uLmgiCj4gPiBAQCAtMzMxOSw2ICszMzIwLDkgQEAgY29uc3Qgc3RydWN0IGZpbGVfb3Bl cmF0aW9ucyBidHJmc19maWxlX29wZXJhdGlvbnMgPSB7Cj4gPiAgCS5zcGxpY2VfcmVhZAk9IGdl bmVyaWNfZmlsZV9zcGxpY2VfcmVhZCwKPiA+ICAJLndyaXRlX2l0ZXIJPSBidHJmc19maWxlX3dy aXRlX2l0ZXIsCj4gPiAgCS5tbWFwCQk9IGJ0cmZzX2ZpbGVfbW1hcCwKPiA+ICsjaWZkZWYgQ09O RklHX0ZTX0RBWAo+ID4gKwkubW1hcF9zdXBwb3J0ZWRfZmxhZ3MgPSBNQVBfU1lOQywKPiA+ICsj ZW5kaWYKPiA+ICAJLm9wZW4JCT0gYnRyZnNfZmlsZV9vcGVuLAo+ID4gIAkucmVsZWFzZQk9IGJ0 cmZzX3JlbGVhc2VfZmlsZSwKPiA+ICAJLmZzeW5jCQk9IGJ0cmZzX3N5bmNfZmlsZSwKPiA+IC0t IAo+ID4gMi4xNi40Cj4gPiAKPiAtLSAKPiBKYW4gS2FyYSA8amFja0BzdXNlLmNvbT4KPiBTVVNF IExhYnMsIENSCj4gCgotLSAK4qKA4qO04qC+4qC74qK24qOm4qCAIExhdGluOiAgIG1lb3cgNCBj aGFyYWN0ZXJzLCA0IGNvbHVtbnMsICA0IGJ5dGVzCuKjvuKggeKioOKgkuKggOKjv+KhgSBHcmVl azogICDOvM61zr/PhSA0IGNoYXJhY3RlcnMsIDQgY29sdW1ucywgIDggYnl0ZXMK4qK/4qGE4qCY 4qC34qCa4qCLICBSdW5lczogICDhm5fhm5bhm5/hmrkgNCBjaGFyYWN0ZXJzLCA0IGNvbHVtbnMs IDEyIGJ5dGVzCuKgiOKgs+KjhOKggOKggOKggOKggCBDaGluZXNlOiDllrUgICAxIGNoYXJhY3Rl ciwgIDIgY29sdW1ucywgIDMgYnl0ZXMgPC0tIGJlc3QhCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW52ZGltbSBtYWlsaW5nIGxpc3QKTGludXgt bnZkaW1tQGxpc3RzLjAxLm9yZwpodHRwczovL2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LW52ZGltbQo=