From: Christoph Hellwig <hch@infradead.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jaewon Kim <jaewon31.kim@gmail.com>,
linux-mm@kvack.org, gregkh@linuxfoundation.org,
Jaewon Kim <jaewon31.kim@samsung.com>,
m.szyprowski@samsung.com, ytk.lee@samsung.com,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [RFC PATCH] usb: host: xhci: allow __GFP_FS in dma allocation
Date: Thu, 23 May 2019 09:35:49 -0700 [thread overview]
Message-ID: <20190523163549.GA8692@infradead.org> (raw)
In-Reply-To: <1558614729.3994.5.camel@suse.com>
On Thu, May 23, 2019 at 02:32:09PM +0200, Oliver Neukum wrote:
> > Please switch to use memalloc_noio_save() instead.
>
> Thinking about this again, we have a problem. We introduced
> memalloc_noio_save() in 3.10 . Hence the code should have been
> correct in v4.14. Which means that either
> 6518202970c1 "(mm/cma: remove unsupported gfp_mask
> parameter from cma_alloc()"
> is buggy, or the original issue with a delay of 2 seconds
> still exist.
>
> Do we need to do something?
cma_alloc calls into alloc_contig_range to do the actual allocation,
which then calls current_gfp_context() to pick up the adjustments
from memalloc_noio_save and friends. So at least in current mainline
we should be fine.
prev parent reply other threads:[~2019-05-23 16:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 16:02 [RFC PATCH] usb: host: xhci: allow __GFP_FS in dma allocation Jaewon Kim
2019-05-17 16:34 ` Matthew Wilcox
2019-05-18 1:53 ` Jaewon Kim
2019-05-20 5:56 ` Christoph Hellwig
2019-05-20 9:09 ` Oliver Neukum
2019-05-20 10:12 ` Christoph Hellwig
2019-05-20 14:16 ` Alan Stern
2019-05-20 14:23 ` Christoph Hellwig
2019-05-21 8:54 ` Oliver Neukum
2019-05-21 13:27 ` Christoph Hellwig
2019-05-21 13:11 ` Oliver Neukum
2019-05-21 14:00 ` Alan Stern
2019-05-22 6:31 ` Oliver Neukum
2019-05-22 14:56 ` Alan Stern
2019-05-22 20:47 ` Oliver Neukum
2019-05-23 14:01 ` Alan Stern
2019-05-28 12:34 ` Oliver Neukum
2019-05-28 14:25 ` Alan Stern
2019-05-23 12:32 ` Oliver Neukum
2019-05-23 16:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190523163549.GA8692@infradead.org \
--to=hch@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jaewon31.kim@gmail.com \
--cc=jaewon31.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=oneukum@suse.com \
--cc=ytk.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.