From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Date: Thu, 23 May 2019 17:12:37 +0000 Subject: Re: [PATCH] drm/edid: Fix docbook in drm_hdmi_infoframe_set_hdr_metadata() Message-Id: <20190523171237.GD17077@art_vandelay> List-Id: References: <20190523135504.184354-1-sean@poorly.run> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: "Shankar, Uma" Cc: "linux-fbdev@vger.kernel.org" , Bartlomiej Zolnierkiewicz , Maxime Ripard , "dri-devel@lists.freedesktop.org" , Hans Verkuil , David Airlie , Sean Paul , Sean Paul On Thu, May 23, 2019 at 02:38:37PM +0000, Shankar, Uma wrote: >=20 >=20 > >-----Original Message----- > >From: Sean Paul [mailto:sean@poorly.run] > >Sent: Thursday, May 23, 2019 7:25 PM > >To: dri-devel@lists.freedesktop.org > >Cc: Sean Paul ; Shankar, Uma ; > >Sharma, Shashank ; Ville Syrj=E4l=E4 > >; Maarten Lankhorst > >; Maxime Ripard > >; Sean Paul ; David Airlie > >; Daniel Vetter ; Bartlomiej Zolnierk= iewicz > >; Hans Verkuil ; linux- > >fbdev@vger.kernel.org > >Subject: [PATCH] drm/edid: Fix docbook in drm_hdmi_infoframe_set_hdr_met= adata() > > > >From: Sean Paul > > > >Fixes the following warnings: > >../drivers/gpu/drm/drm_edid.c:4925: warning: Function parameter or member > >'conn_state' not described in 'drm_hdmi_infoframe_set_hdr_metadata' > >../drivers/gpu/drm/drm_edid.c:4925: warning: Excess function parameter > >'hdr_metadata' description in 'drm_hdmi_infoframe_set_hdr_metadata' >=20 > Thanks Sean Paul for fixing this. > Reviewed-by: Uma Shankar Pushed to -misc-next, thank you for the review! Sean >=20 > >Fixes: 2cdbfd66a829 ("drm: Enable HDR infoframe support") > >Cc: Uma Shankar > >Cc: Shashank Sharma > >Cc: Ville Syrj=E4l=E4 > >Cc: Maarten Lankhorst > >Cc: Maxime Ripard > >Cc: Sean Paul > >Cc: David Airlie > >Cc: Daniel Vetter > >Cc: Bartlomiej Zolnierkiewicz > >Cc: "Ville Syrj=E4l=E4" > >Cc: Hans Verkuil > >Cc: dri-devel@lists.freedesktop.org > >Cc: linux-fbdev@vger.kernel.org > >Signed-off-by: Sean Paul > >--- > > drivers/gpu/drm/drm_edid.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c ind= ex > >262510c2a670..d87f574feeca 100644 > >--- a/drivers/gpu/drm/drm_edid.c > >+++ b/drivers/gpu/drm/drm_edid.c > >@@ -4914,7 +4914,7 @@ static inline bool is_eotf_supported(u8 output_eot= f, u8 > >sink_eotf) > > * drm_hdmi_infoframe_set_hdr_metadata() - fill an HDMI DRM infoframe w= ith > > * HDR metadata from userspace > > * @frame: HDMI DRM infoframe > >- * @hdr_metadata: hdr_source_metadata info from userspace > >+ * @conn_state: Connector state containing HDR metadata > > * > > * Return: 0 on success or a negative error code on failure. > > */ > >-- > >Sean Paul, Software Engineer, Google / Chromium OS >=20 --=20 Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH] drm/edid: Fix docbook in drm_hdmi_infoframe_set_hdr_metadata() Date: Thu, 23 May 2019 13:12:37 -0400 Message-ID: <20190523171237.GD17077@art_vandelay> References: <20190523135504.184354-1-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1C826E03E for ; Thu, 23 May 2019 17:12:39 +0000 (UTC) Received: by mail-qt1-x842.google.com with SMTP id k24so7608205qtq.7 for ; Thu, 23 May 2019 10:12:39 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Shankar, Uma" Cc: "linux-fbdev@vger.kernel.org" , Bartlomiej Zolnierkiewicz , Maxime Ripard , "dri-devel@lists.freedesktop.org" , Hans Verkuil , David Airlie , Sean Paul , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXkgMjMsIDIwMTkgYXQgMDI6Mzg6MzdQTSArMDAwMCwgU2hhbmthciwgVW1hIHdy b3RlOgo+IAo+IAo+ID4tLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID5Gcm9tOiBTZWFuIFBh dWwgW21haWx0bzpzZWFuQHBvb3JseS5ydW5dCj4gPlNlbnQ6IFRodXJzZGF5LCBNYXkgMjMsIDIw MTkgNzoyNSBQTQo+ID5UbzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID5DYzog U2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+OyBTaGFua2FyLCBVbWEgPHVtYS5zaGFu a2FyQGludGVsLmNvbT47Cj4gPlNoYXJtYSwgU2hhc2hhbmsgPHNoYXNoYW5rLnNoYXJtYUBpbnRl bC5jb20+OyBWaWxsZSBTeXJqw6Rsw6QKPiA+PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t PjsgTWFhcnRlbiBMYW5raG9yc3QKPiA+PG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNv bT47IE1heGltZSBSaXBhcmQKPiA+PG1heGltZS5yaXBhcmRAYm9vdGxpbi5jb20+OyBTZWFuIFBh dWwgPHNlYW5AcG9vcmx5LnJ1bj47IERhdmlkIEFpcmxpZQo+ID48YWlybGllZEBsaW51eC5pZT47 IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD47IEJhcnRsb21pZWogWm9sbmllcmtpZXdp Y3oKPiA+PGIuem9sbmllcmtpZUBzYW1zdW5nLmNvbT47IEhhbnMgVmVya3VpbCA8aGFuc3ZlcmtA Y2lzY28uY29tPjsgbGludXgtCj4gPmZiZGV2QHZnZXIua2VybmVsLm9yZwo+ID5TdWJqZWN0OiBb UEFUQ0hdIGRybS9lZGlkOiBGaXggZG9jYm9vayBpbiBkcm1faGRtaV9pbmZvZnJhbWVfc2V0X2hk cl9tZXRhZGF0YSgpCj4gPgo+ID5Gcm9tOiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVtLm9y Zz4KPiA+Cj4gPkZpeGVzIHRoZSBmb2xsb3dpbmcgd2FybmluZ3M6Cj4gPi4uL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZWRpZC5jOjQ5MjU6IHdhcm5pbmc6IEZ1bmN0aW9uIHBhcmFtZXRlciBvciBtZW1i ZXIKPiA+J2Nvbm5fc3RhdGUnIG5vdCBkZXNjcmliZWQgaW4gJ2RybV9oZG1pX2luZm9mcmFtZV9z ZXRfaGRyX21ldGFkYXRhJwo+ID4uLi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYzo0OTI1OiB3 YXJuaW5nOiBFeGNlc3MgZnVuY3Rpb24gcGFyYW1ldGVyCj4gPidoZHJfbWV0YWRhdGEnIGRlc2Ny aXB0aW9uIGluICdkcm1faGRtaV9pbmZvZnJhbWVfc2V0X2hkcl9tZXRhZGF0YScKPiAKPiBUaGFu a3MgU2VhbiBQYXVsIGZvciBmaXhpbmcgdGhpcy4KPiBSZXZpZXdlZC1ieTogVW1hIFNoYW5rYXIg PHVtYS5zaGFua2FyQGludGVsLmNvbT4KClB1c2hlZCB0byAtbWlzYy1uZXh0LCB0aGFuayB5b3Ug Zm9yIHRoZSByZXZpZXchCgpTZWFuCgo+IAo+ID5GaXhlczogMmNkYmZkNjZhODI5ICgiZHJtOiBF bmFibGUgSERSIGluZm9mcmFtZSBzdXBwb3J0IikKPiA+Q2M6IFVtYSBTaGFua2FyIDx1bWEuc2hh bmthckBpbnRlbC5jb20+Cj4gPkNjOiBTaGFzaGFuayBTaGFybWEgPHNoYXNoYW5rLnNoYXJtYUBp bnRlbC5jb20+Cj4gPkNjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+ID5DYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4 LmludGVsLmNvbT4KPiA+Q2M6IE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBhcmRAYm9vdGxpbi5j b20+Cj4gPkNjOiBTZWFuIFBhdWwgPHNlYW5AcG9vcmx5LnJ1bj4KPiA+Q2M6IERhdmlkIEFpcmxp ZSA8YWlybGllZEBsaW51eC5pZT4KPiA+Q2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5j aD4KPiA+Q2M6IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogPGIuem9sbmllcmtpZUBzYW1zdW5n LmNvbT4KPiA+Q2M6ICJWaWxsZSBTeXJqw6Rsw6QiIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiA+Q2M6IEhhbnMgVmVya3VpbCA8aGFuc3ZlcmtAY2lzY28uY29tPgo+ID5DYzogZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID5DYzogbGludXgtZmJkZXZAdmdlci5rZXJu ZWwub3JnCj4gPlNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3Jn Pgo+ID4tLS0KPiA+IGRyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIHwgMiArLQo+ID4gMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPgo+ID5kaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQu YyBpbmRleAo+ID4yNjI1MTBjMmE2NzAuLmQ4N2Y1NzRmZWVjYSAxMDA2NDQKPiA+LS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9lZGlkLmMKPiA+KysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlk LmMKPiA+QEAgLTQ5MTQsNyArNDkxNCw3IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpc19lb3RmX3N1 cHBvcnRlZCh1OCBvdXRwdXRfZW90ZiwgdTgKPiA+c2lua19lb3RmKQo+ID4gICogZHJtX2hkbWlf aW5mb2ZyYW1lX3NldF9oZHJfbWV0YWRhdGEoKSAtIGZpbGwgYW4gSERNSSBEUk0gaW5mb2ZyYW1l IHdpdGgKPiA+ICAqICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBIRFIg bWV0YWRhdGEgZnJvbSB1c2Vyc3BhY2UKPiA+ICAqIEBmcmFtZTogSERNSSBEUk0gaW5mb2ZyYW1l Cj4gPi0gKiBAaGRyX21ldGFkYXRhOiBoZHJfc291cmNlX21ldGFkYXRhIGluZm8gZnJvbSB1c2Vy c3BhY2UKPiA+KyAqIEBjb25uX3N0YXRlOiBDb25uZWN0b3Igc3RhdGUgY29udGFpbmluZyBIRFIg bWV0YWRhdGEKPiA+ICAqCj4gPiAgKiBSZXR1cm46IDAgb24gc3VjY2VzcyBvciBhIG5lZ2F0aXZl IGVycm9yIGNvZGUgb24gZmFpbHVyZS4KPiA+ICAqLwo+ID4tLQo+ID5TZWFuIFBhdWwsIFNvZnR3 YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBPUwo+IAoKLS0gClNlYW4gUGF1bCwgU29m dHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==