Re: [PATCH 01/10] drm/i915/dmc: use kernel types

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, May 23, 2019 at 01:24:11AM -0700, Lucas De Marchi wrote:
> Change all fields in intel_package_header and intel_dmc_header whose
> meaning are 1-byte numbers to use u8.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_csr.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 4527b9662330..b05e7a6aebc7 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -130,12 +130,12 @@ struct intel_fw_info {
>  
>  struct intel_package_header {
>  	/* DMC container header length in dwords */
> -	unsigned char header_len;
> +	u8 header_len;
>  
>  	/* always value would be 0x01 */
> -	unsigned char header_ver;
> +	u8 header_ver;
>  
> -	unsigned char reserved[10];
> +	u8 reserved[10];
>  
>  	/* Number of valid entries in the FWInfo array below */
>  	u32 num_entries;
> @@ -148,10 +148,10 @@ struct intel_dmc_header {
>  	u32 signature;
>  
>  	/* DMC binary header length */
> -	unsigned char header_len;
> +	u8 header_len;
>  
>  	/* 0x01 */
> -	unsigned char header_ver;
> +	u8 header_ver;
>  
>  	/* Reserved */
>  	u16 dmcc_ver;
> -- 
> 2.21.0
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx