All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: "Bernhard M. Wiedemann" <bwiedemann@suse.de>,
	bsd@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] i386: Fix nested SVM on older Opterons
Date: Thu, 23 May 2019 18:27:08 -0300	[thread overview]
Message-ID: <20190523212708.GD10764@habkost.net> (raw)
In-Reply-To: <20190523185737.GB2994@work-vm>

On Thu, May 23, 2019 at 07:57:38PM +0100, Dr. David Alan Gilbert wrote:
> * Bernhard M. Wiedemann (bwiedemann@suse.de) wrote:
> > Without this patch, a VM on a Opteron G3 host will have the svm flag, but
> > the kvm-amd module fails to load in there, complaining that it needs
> > cpuid 0x8000000a
> > 
> > I have successfully built and tested this for 3+ years in production
> > on Opteron G3 servers.

Have you reproduced the bug on QEMU 2.8 or newer?  The problem
you describe should be fixed by the following commit (from ~2.5
years ago).

commit 0c3d7c0051576d220e6da0a8ac08f2d8482e2f0b
Author: Eduardo Habkost <ehabkost@redhat.com>
Date:   Wed Sep 21 15:01:35 2016 -0300

    target-i386: Enable CPUID[0x8000000A] if SVM is enabled

    SVM needs CPUID[0x8000000A] to be available. So if SVM is enabled
    in a CPU model or explicitly in the command-line, adjust CPUID
    xlevel to expose the CPUID[0x8000000A] leaf.

    Reviewed-by: Richard Henderson <rth@twiddle.net>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

-- 
Eduardo


  reply	other threads:[~2019-05-23 21:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 12:58 [Qemu-devel] [PATCH] i386: Fix nested SVM on older Opterons Bernhard M. Wiedemann
2019-05-23 18:57 ` Dr. David Alan Gilbert
2019-05-23 21:27   ` Eduardo Habkost [this message]
2019-05-27  7:49     ` Bernhard M. Wiedemann
  -- strict thread matches above, loose matches on Subject: below --
2019-05-16 14:38 Bernhard M. Wiedemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190523212708.GD10764@habkost.net \
    --to=ehabkost@redhat.com \
    --cc=bsd@redhat.com \
    --cc=bwiedemann@suse.de \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.