From: Greg KH <gregkh@linuxfoundation.org>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ks7010: Remove initialisation
Date: Fri, 24 May 2019 09:42:32 +0200 [thread overview]
Message-ID: <20190524074231.GA29172@kroah.com> (raw)
In-Reply-To: <aae76db5-8768-d277-e527-9e166a02f46e@gmail.com>
On Fri, May 24, 2019 at 12:31:19PM +0530, Nishka Dasgupta wrote:
> On 24/05/19 12:22 PM, Greg KH wrote:
> > On Fri, May 24, 2019 at 11:26:02AM +0530, Nishka Dasgupta wrote:
> > > As the initial value of the return variable result is never used, it can
> > > be removed.
> > > Issue found with Coccinelle.
> > >
> > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> > > ---
> > > drivers/staging/ks7010/ks7010_sdio.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Didn't you already send this?
>
> I sent two patches about removing initialisation in ks7010 today, but I
> couldn't make it a patch series because the different files had different
> maintainers. I don't think I've sent this patch before, but it's possible I
> made a mistake because my local tree has not been the best organised lately.
> I apologise for the confusion.
>
I saw two patches with the same subject line, if I messed up, please
resend.
> > And please run a spell-checker on your subject line when you resend
> > this :)
>
> Is this about "initialise" (and now also "organised", "apologise", etc)? As
> far as I'm aware whether the word ends in "-ise"/"-ize" depends on local
> varieties of English, so I went with the variety I'm more used to. Should I
> stick with American/Canadian spelling variants (including "-or" over "-our"
> etc) from now on?
Ah, didn't realize that was a valid spelling, sorry.
greg k-h
next prev parent reply other threads:[~2019-05-24 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 5:56 [PATCH] staging: ks7010: Remove initialisation Nishka Dasgupta
2019-05-24 6:52 ` Greg KH
2019-05-24 7:01 ` Nishka Dasgupta
2019-05-24 7:42 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-05-24 5:52 Nishka Dasgupta
2019-05-24 7:04 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524074231.GA29172@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.