From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH v3 2/3] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel Date: Fri, 24 May 2019 09:54:48 -0300 Message-ID: <20190524095448.5eeddc06@coco.lan> References: <20190422093722.4344-1-paul@crapouillou.net> <20190422093722.4344-2-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190422093722.4344-2-paul@crapouillou.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Cercueil Cc: Mark Rutland , devicetree@vger.kernel.org, od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans Verkuil , Rob Herring , linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org RW0gTW9uLCAyMiBBcHIgMjAxOSAxMTozNzoyMSArMDIwMApQYXVsIENlcmN1ZWlsIDxwYXVsQGNy YXBvdWlsbG91Lm5ldD4gZXNjcmV2ZXU6Cgo+IFRoZSBHaWFudFBsdXMgR1BNOTQwQjAgaXMgYSAy NC1iaXQgVEZUIHBhbmVsIHdoZXJlIHRoZSBSR0IgY29tcG9uZW50cwo+IGFyZSB0cmFuc2ZlcnJl ZCBzZXF1ZW50aWFsbHkgb24gYSA4LWJpdCBidXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogUGF1bCBD ZXJjdWVpbCA8cGF1bEBjcmFwb3VpbGxvdS5uZXQ+Cj4gLS0tCj4gCj4gTm90ZXM6Cj4gICAgIHYy OiBOZXcgcGF0Y2gKPiAgICAgCj4gICAgIHYzOiBObyBjaGFuZ2UKPiAKPiAgaW5jbHVkZS91YXBp L2xpbnV4L21lZGlhLWJ1cy1mb3JtYXQuaCB8IDQgKysrLQo+ICAxIGZpbGUgY2hhbmdlZCwgMyBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvdWFw aS9saW51eC9tZWRpYS1idXMtZm9ybWF0LmggYi9pbmNsdWRlL3VhcGkvbGludXgvbWVkaWEtYnVz LWZvcm1hdC5oCj4gaW5kZXggZDZhNWEzYmZlNmM0Li5mMzE3MjRkNmNkNDAgMTAwNjQ0Cj4gLS0t IGEvaW5jbHVkZS91YXBpL2xpbnV4L21lZGlhLWJ1cy1mb3JtYXQuaAo+ICsrKyBiL2luY2x1ZGUv dWFwaS9saW51eC9tZWRpYS1idXMtZm9ybWF0LmgKPiBAQCAtMzQsNyArMzQsNyBAQAo+ICAKPiAg I2RlZmluZSBNRURJQV9CVVNfRk1UX0ZJWEVECQkJMHgwMDAxCj4gIAo+IC0vKiBSR0IgLSBuZXh0 IGlzCTB4MTAxYiAqLwo+ICsvKiBSR0IgLSBuZXh0IGlzCTB4MTAxZCAqLwo+ICAjZGVmaW5lIE1F RElBX0JVU19GTVRfUkdCNDQ0XzFYMTIJCTB4MTAxNgo+ICAjZGVmaW5lIE1FRElBX0JVU19GTVRf UkdCNDQ0XzJYOF9QQURISV9CRQkweDEwMDEKPiAgI2RlZmluZSBNRURJQV9CVVNfRk1UX1JHQjQ0 NF8yWDhfUEFESElfTEUJMHgxMDAyCj4gQEAgLTU0LDYgKzU0LDggQEAKPiAgI2RlZmluZSBNRURJ QV9CVVNfRk1UX1JHQjg4OF8xWDI0CQkweDEwMGEKPiAgI2RlZmluZSBNRURJQV9CVVNfRk1UX1JH Qjg4OF8yWDEyX0JFCQkweDEwMGIKPiAgI2RlZmluZSBNRURJQV9CVVNfRk1UX1JHQjg4OF8yWDEy X0xFCQkweDEwMGMKPiArI2RlZmluZSBNRURJQV9CVVNfRk1UX1JHQjg4OF8zWDhfQkUJCTB4MTAx Ygo+ICsjZGVmaW5lIE1FRElBX0JVU19GTVRfUkdCODg4XzNYOF9MRQkJMHgxMDFjCj4gICNkZWZp bmUgTUVESUFfQlVTX0ZNVF9SR0I4ODhfMVg3WDRfU1BXRwkJMHgxMDExCj4gICNkZWZpbmUgTUVE SUFfQlVTX0ZNVF9SR0I4ODhfMVg3WDRfSkVJREEJMHgxMDEyCj4gICNkZWZpbmUgTUVESUFfQlVT X0ZNVF9BUkdCODg4OF8xWDMyCQkweDEwMGQKCllvdSBzaG91bGQgYWxzbyBwYXRjaCB0aGUgZG9j dW1lbnRhdGlvbiB0ZXh0IGF0OgoKCURvY3VtZW50YXRpb24vbWVkaWEvdWFwaS92NGwvc3ViZGV2 LWZvcm1hdHMucnN0CgpJbiBvcmRlciB0byBkZXNjcmliZSB0aGUgbmV3IGZvcm1hdHMgdGhhdCB3 aWxsIGJlIGluY2x1ZGVkLgoKKGFsc28gcGF0Y2ggbmVlZHMgdG8gYmUgcmViYXNlZCwgYXMgaXQg Y29uZmxpY3RzIHRvIHNvbWUgb3RoZXIKbmV3IGZvcm1hdHMgYWRkZWQgdGhlcmUpCgpUaGFua3Ms Ck1hdXJvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB0FC072B5 for ; Fri, 24 May 2019 12:55:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FDFA20879 for ; Fri, 24 May 2019 12:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558702516; bh=BQFHtZ5dEmvH4qkll2wnSHnFe4of3FdDHtHbvRIZnpo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=PlcxB63C5C9kkwk8cm9PXNo2XMN/W2ucwmUFm6Krqluwczf9zyRXMIQt6HYr+7XjW vrFtwjExYbuS3gnssyeEhk6aeUlWj1i/ih1HrjBgQmml101tmb0DtuGNI0+8H+qx// /pHpCVhZcSO2k3YeKfbTtseW8YPHg9pGGztmrtzM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391316AbfEXMzI (ORCPT ); Fri, 24 May 2019 08:55:08 -0400 Received: from casper.infradead.org ([85.118.1.10]:52268 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390946AbfEXMzH (ORCPT ); Fri, 24 May 2019 08:55:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cyQ2oCePc4465xvjRRiSWu3xnwrETc8dIcA8pz3EwJ0=; b=E4iX4UX6mglLfAHRlj9/ZWx+Pu yjmQqjwNzpxIGvni7RskChjxO4ZkWz+4AxWjRGdL/6NO5FLorU4dYd5TmXiM8JGzpnn2J0v82gsPf oap2Y2VrPjk8iSXtkTbSk5vr3DIKak5KbRd3qKasC28pEf8aVn+a5aCiXaeImaL5VKHV5kxDl+8rL DsC2gwUE9Qy87vP6utPhnfZeTZP+gCCKcj8BxEuy+9oKbpuSf6UK8Pj+l8+B5TcI/BthdUA897BIi iaRO0las5/BQy59Sv+piPNCgL/9LhSMmy3jISAVESqnN2tFQ3Sbo91uVu5WwTB+7vmY0prvMP3Mvo cLGtF+rw==; Received: from 177.97.63.247.dynamic.adsl.gvt.net.br ([177.97.63.247] helo=coco.lan) by casper.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hU9io-0006hg-JZ; Fri, 24 May 2019 12:54:55 +0000 Date: Fri, 24 May 2019 09:54:48 -0300 From: Mauro Carvalho Chehab To: Paul Cercueil Cc: Rob Herring , Mark Rutland , Hans Verkuil , od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v3 2/3] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel Message-ID: <20190524095448.5eeddc06@coco.lan> In-Reply-To: <20190422093722.4344-2-paul@crapouillou.net> References: <20190422093722.4344-1-paul@crapouillou.net> <20190422093722.4344-2-paul@crapouillou.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Mon, 22 Apr 2019 11:37:21 +0200 Paul Cercueil escreveu: > The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB components > are transferred sequentially on a 8-bit bus. > > Signed-off-by: Paul Cercueil > --- > > Notes: > v2: New patch > > v3: No change > > include/uapi/linux/media-bus-format.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h > index d6a5a3bfe6c4..f31724d6cd40 100644 > --- a/include/uapi/linux/media-bus-format.h > +++ b/include/uapi/linux/media-bus-format.h > @@ -34,7 +34,7 @@ > > #define MEDIA_BUS_FMT_FIXED 0x0001 > > -/* RGB - next is 0x101b */ > +/* RGB - next is 0x101d */ > #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 > @@ -54,6 +54,8 @@ > #define MEDIA_BUS_FMT_RGB888_1X24 0x100a > #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b > #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c > +#define MEDIA_BUS_FMT_RGB888_3X8_BE 0x101b > +#define MEDIA_BUS_FMT_RGB888_3X8_LE 0x101c > #define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011 > #define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012 > #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d You should also patch the documentation text at: Documentation/media/uapi/v4l/subdev-formats.rst In order to describe the new formats that will be included. (also patch needs to be rebased, as it conflicts to some other new formats added there) Thanks, Mauro