From: kbusch@kernel.org (Keith Busch)
Subject: [PATCH RFC] nvme: Common subsys and controller instances IDA
Date: Fri, 24 May 2019 08:07:53 -0600 [thread overview]
Message-ID: <20190524140753.GC15192@localhost.localdomain> (raw)
In-Reply-To: <ccd37b33-6fa3-8435-9ac4-9c62f4525c1a@grimberg.me>
On Fri, May 24, 2019@01:03:07AM -0700, Sagi Grimberg wrote:
>
> >> maybe we can improve it and print also the namespace during the "nvme
> >> list-subsys" command.
> >>
> >> something like:
> >>
> >> [root at server50 ~]# nvme list-subsys
> >> nvme-subsys0 - NQN=testsubsystem_0
> >> \
> >> ?+- nvme0 rdma traddr=11.212.140.146 trsvcid=4420
> >> ?\
> >> ? +- nvme0n1 SN=cf8bbff661502c51 Model=Linux
> >> ? +- nvme0n2 SN=cf8bbff661502c51 Model=Linux
> >>
> >>
> >> and we'll get subsys/ctrl/ns relations in 1 cmd.
> >>
> >> thoughts ?
> >
> > Yes, this is very useful! I'd like to add this as soon as possible.
> > Do you have a patch, or is this just an example? The only change I'd
> > recommend is remove SN and Model since those are controller properties
> > rather than from the namespace.
>
> This now gives some context to the series Max posted :)
>
> I still don't understand how this is helping more than the existing
> list-subsys for what you're trying to achieve keith.
>
> Your use-case was "I want to understand what is my controller for
> /dev/nvme0n1". This information is already available in nvme list
> subsys. Why do you need the mpath-slave devices listed as well?
The current 'list-subsys' does not show us any namespaces, actually.
You have to dig through sysfs on your own to see which namespaces belong
to which controllers, but Max has added a more user friendly way to
view this.
next prev parent reply other threads:[~2019-05-24 14:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 21:33 [PATCH RFC] nvme: Common subsys and controller instances IDA Keith Busch
2019-05-16 6:46 ` Christoph Hellwig
2019-05-16 7:03 ` Hannes Reinecke
2019-05-16 14:44 ` Keith Busch
2019-05-16 14:51 ` Christoph Hellwig
2019-05-16 14:58 ` Martin K. Petersen
2019-05-21 9:54 ` Max Gurtovoy
2019-05-21 14:35 ` Keith Busch
2019-05-21 14:51 ` Max Gurtovoy
2019-05-21 14:58 ` Keith Busch
2019-05-24 8:03 ` Sagi Grimberg
2019-05-24 14:07 ` Keith Busch [this message]
2019-05-24 16:17 ` Sagi Grimberg
2019-05-24 19:14 ` Max Gurtovoy
2019-05-24 23:23 ` Sagi Grimberg
2019-05-24 23:30 ` Keith Busch
2019-05-16 14:40 ` Keith Busch
2019-05-16 14:57 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524140753.GC15192@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.