From mboxrd@z Thu Jan 1 00:00:00 1970 From: "hch@lst.de" Subject: Re: [PATCH] drm/vmwgfx: fix a warning due to missing dma_parms Date: Fri, 24 May 2019 16:10:11 +0200 Message-ID: <20190524141011.GA23514@lst.de> References: <20190524023719.1495-1-cai@lca.pw> <20190524061936.GA2337@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Thomas Hellstrom Cc: "hch@lst.de" , "cai@lca.pw" , "daniel@ffwll.ch" , "robin.murphy@arm.com" , "m.szyprowski@samsung.com" , "dri-devel@lists.freedesktop.org" , Linux-graphics-maintainer , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org On Fri, May 24, 2019 at 11:57:04AM +0000, Thomas Hellstrom wrote: > It's a PCI device. The struct device * used in dma_map_sg() is the same > as the &pci_dev->dev handed to the probe() callback. But at probe time, > the struct device::dma_parms is non-NULL, at least on my system so > there shouldn't really be a need to kzalloc() it. Then there is something really odd going on in the OPs setup..