From: kbusch@kernel.org (Keith Busch)
Subject: [RFC PATCH] nvme: Ignore timeouts while a PCIe reset is pending
Date: Fri, 24 May 2019 15:05:02 -0600 [thread overview]
Message-ID: <20190524210501.GA17343@localhost.localdomain> (raw)
In-Reply-To: <e01d7206-dc2c-b3cf-548a-4cb5ffc5bd19@grimberg.me>
On Thu, May 23, 2019@11:45:28PM -0700, Sagi Grimberg wrote:
> Keith,
>
> > I think we should do the above anyway, but it isn't going to help if
> > commands dispatched outside disabling timeout. This should fix that.
> > Note, we never needed to have a sync'ed reset on reset_done(), but
> > this makes it necessary.
>
> With async reset on reset_done() what guarantees that nvme_dev_disable
> does not run concurrently with another context of nvme_reset_work? both
> mangle with the same queues assuming that they are not running
> concurrently.
>
> quick archive browse got me to:
> http://lists.infradead.org/pipermail/linux-nvme/2017-December/014599.html
>
> discussion on my patch, but I think that it was a side effect from
> ming's tests..
Oh, you're right. I think Ming must have been writing to the pc reset
repeatedly, in which case this proposal will have a problem coordinating.
prev parent reply other threads:[~2019-05-24 21:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 0:37 [RFC PATCH] nvme: Ignore timeouts while a PCIe reset is pending Kenneth Heitke
2019-05-22 19:26 ` Keith Busch
2019-05-22 20:09 ` Keith Busch
2019-05-23 21:57 ` Heitke, Kenneth
2019-05-23 21:59 ` Keith Busch
2019-05-24 6:45 ` Sagi Grimberg
2019-05-24 21:05 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524210501.GA17343@localhost.localdomain \
--to=kbusch@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.