From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/5] gstreamer1: Plugin work
Date: Sun, 26 May 2019 21:28:10 +0200 [thread overview]
Message-ID: <20190526212810.7ea8d8a4@windsurf> (raw)
In-Reply-To: <20190509224624.80437-1-aduskett@gmail.com>
Hello Adam,
On Thu, 9 May 2019 18:46:18 -0400
aduskett at gmail.com wrote:
> Adam Duskett (5):
> package/gstreamer1/gst1-plugins-good: Add twolame plugin
> package/gstreamer1/gst1-plugins-good: Add jack plugin
> package/gstreamer1/gst1-plugins-bad: add proxy plugin
> package/gstreamer1/gst1-plugins-bad: add audiolatency plugin
> package/gstreamer1/gst1-plugins-bad: Add bluez plugin
I've applied to next, with some changes. First, the commit titles are
not consistent in terms of lower-case vs. upper-case. You use "add" or
"Add". I personally prefer lower-case.
Secondly, the patches are not adding plugins, but adding options, so
"add twolame plugin option" is more correct.
I did some other changes to one patch, I'll reply to that one
specifically.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-05-26 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 22:46 [Buildroot] [PATCH 0/5] gstreamer1: Plugin work aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 1/5] package/gstreamer1/gst1-plugins-good: Add twolame plugin aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 2/5] package/gstreamer1/gst1-plugins-good: Add jack plugin aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 3/5] package/gstreamer1/gst1-plugins-bad: add proxy plugin aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 4/5] package/gstreamer1/gst1-plugins-bad: add audiolatency plugin aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 4/4] package/gstreamer1/gst1-plugins-bad: Add bluez plugin aduskett at gmail.com
2019-05-09 22:46 ` [Buildroot] [PATCH 5/5] " aduskett at gmail.com
2019-05-26 19:31 ` Thomas Petazzoni
2019-05-26 19:28 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190526212810.7ea8d8a4@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.