From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/exiv2: cleanup options and licenses
Date: Mon, 27 May 2019 09:06:33 +0200 [thread overview]
Message-ID: <20190527090633.36b30cb6@windsurf> (raw)
In-Reply-To: <2ae7ca95-3cca-4be4-3aee-96eb194124d8@mind.be>
Hello,
On Sun, 26 May 2019 23:50:15 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> > And if there's a reason for it, why is it done as part of the patch
> > dropping the _COMMERCIAL option ?
>
> This was discussed in v1 of the patch (and indeed should have been part of the
> commit log).
>
> The BR2_PACKAGE_EXIV2_LENSDATA option only existed as a separate option because
> of hte license concerns (incompatibility with the commercial license). Since
> these concerns have gone away, and the license database is only 80KB, remove
> this option as well.
>
> It could have been done in a separate patch, but since anyway the help text
> would have to change in this patch, I think it's not worth splitting off.
Thanks for the additional explanation. It should have been part of the
commit log indeed.
What do we do now? Nicolas, do you submit a v3 with an improved commit
log? Do we resurrect v2 from patchwork, and adjust the commit log when
applying?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-27 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 10:32 [Buildroot] [PATCH v2] package/exiv2: cleanup options and licenses Nicolas Serafini
2019-05-26 20:36 ` Thomas Petazzoni
2019-05-26 21:50 ` Arnout Vandecappelle
2019-05-27 7:06 ` Thomas Petazzoni [this message]
2019-06-03 8:49 ` Nicolas Serafini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527090633.36b30cb6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.