From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] net: ll_temac: Cleanup multicast filter on change
Date: Mon, 27 May 2019 10:05:39 +0000 [thread overview]
Message-ID: <20190527100539.GA31007@mwanda> (raw)
Hello Esben Haabendal,
The patch 1b3fa5cf859b: "net: ll_temac: Cleanup multicast filter on
change" from May 23, 2019, leads to the following static checker
warning:
drivers/net/ethernet/xilinx/ll_temac_main.c:490 temac_set_multicast_list()
error: uninitialized symbol 'i'.
drivers/net/ethernet/xilinx/ll_temac_main.c
451 static void temac_set_multicast_list(struct net_device *ndev)
452 {
453 struct temac_local *lp = netdev_priv(ndev);
454 u32 multi_addr_msw, multi_addr_lsw;
455 int i;
^^^^^
456 unsigned long flags;
457 bool promisc_mode_disabled = false;
458
459 if (ndev->flags & (IFF_PROMISC | IFF_ALLMULTI) ||
460 (netdev_mc_count(ndev) > MULTICAST_CAM_TABLE_NUM)) {
461 temac_indirect_out32(lp, XTE_AFM_OFFSET, XTE_AFM_EPPRM_MASK);
462 dev_info(&ndev->dev, "Promiscuous mode enabled.\n");
463 return;
464 }
465
466 spin_lock_irqsave(lp->indirect_lock, flags);
467
468 if (!netdev_mc_empty(ndev)) {
469 struct netdev_hw_addr *ha;
470
471 i = 0;
^^^^^
This is not initialized on the false path.
472 netdev_for_each_mc_addr(ha, ndev) {
473 if (WARN_ON(i >= MULTICAST_CAM_TABLE_NUM))
474 break;
475 multi_addr_msw = ((ha->addr[3] << 24) |
476 (ha->addr[2] << 16) |
477 (ha->addr[1] << 8) |
478 (ha->addr[0]));
479 temac_indirect_out32_locked(lp, XTE_MAW0_OFFSET,
480 multi_addr_msw);
481 multi_addr_lsw = ((ha->addr[5] << 8) |
482 (ha->addr[4]) | (i << 16));
483 temac_indirect_out32_locked(lp, XTE_MAW1_OFFSET,
484 multi_addr_lsw);
485 i++;
486 }
487 }
488
489 /* Clear all or remaining/unused address table entries */
490 while (i < MULTICAST_CAM_TABLE_NUM) {
^
Uninitialized.
491 temac_indirect_out32_locked(lp, XTE_MAW0_OFFSET, 0);
492 temac_indirect_out32_locked(lp, XTE_MAW1_OFFSET, i << 16);
493 i++;
494 }
regards,
dan carpenter
reply other threads:[~2019-05-27 10:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527100539.GA31007@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.