From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9500C07542 for ; Mon, 27 May 2019 09:28:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A146F2173B for ; Mon, 27 May 2019 09:28:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qahRakGs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A146F2173B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8CezyDx1PGMYXISVBqvSNRgwdpDtzVHYPMb1+pUMKvA=; b=qahRakGsMvWa3v 3RWdwQggmUiZM7AwxLwehNd9l/26eSa7ImThgBQLA88X/r20TcPHP9j2x2j95KbjBdgnAvtBgC7dD io5DetA1DTmzDEBuyhRMbl/quPkUgEazpsZdG+TkuytH1MpM05oVVxUutkQeAfdYYNGbxa8atZI1o NvRb4OiVrAaD1val4EeVoIgG7FSRN+0SLD0nlRIDvDHNCZpdxQruuSvUkrh1KeFEa8X14XGMJwgPL sIo7Nk7J4dvqhFkbpF4R9cq/yaHKO+HyMDJGylkVXW8LTaoHOG32+bM/Ai4Wk5Is2oec3aqNXl2zU q83ncBMjKaPPR5+vke/g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVBvZ-0007El-L2; Mon, 27 May 2019 09:28:21 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVBvV-0007EH-SS for linux-mtd@lists.infradead.org; Mon, 27 May 2019 09:28:19 +0000 Received: from xps13 (aaubervilliers-681-1-27-134.w90-88.abo.wanadoo.fr [90.88.147.134]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id EC5A420000F; Mon, 27 May 2019 09:28:03 +0000 (UTC) Date: Mon, 27 May 2019 11:28:02 +0200 From: Miquel Raynal To: Schrempf Frieder Subject: Re: [PATCH v4 3/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG Message-ID: <20190527112802.08b86fa5@xps13> In-Reply-To: <34004a59-5643-e405-13ca-3581659fc745@kontron.de> References: <20190522220555.11626-1-lede@allycomm.com> <20190522220555.11626-4-lede@allycomm.com> <34004a59-5643-e405-13ca-3581659fc745@kontron.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190527_022818_071046_9422AA0A X-CRM114-Status: GOOD ( 22.31 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Jeff Kletsky Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgU2NocmVtcGYsCgpTY2hyZW1wZiBGcmllZGVyIDxmcmllZGVyLnNjaHJlbXBmQGtvbnRyb24u ZGU+IHdyb3RlIG9uIE1vbiwgMjcgTWF5CjIwMTkgMDY6MzU6NTkgKzAwMDA6Cgo+IEhpIEplZmYs Cj4gCj4gT24gMjQuMDUuMTkgMDI6MTIsIEplZmYgS2xldHNreSB3cm90ZToKPiA+IChyZWR1Y2Vk IGRpcmVjdCBhZGRyZXNzZWVzLCB0aG91Z2ggc3RpbGwgb24gbGlzdHMpCj4gPiAKPiA+IE9uIDUv MjIvMTkgMTE6NDIgUE0sIFNjaHJlbXBmIEZyaWVkZXIgd3JvdGU6Cj4gPiAgIAo+ID4+IE9uIDIz LjA1LjE5IDAwOjA1LCBKZWZmIEtsZXRza3kgd3JvdGU6ICAKPiA+Pj4gRnJvbTogSmVmZiBLbGV0 c2t5IDxnaXQtY29tbWl0c0BhbGx5Y29tbS5jb20+Cj4gPj4+Cj4gPj4+IFRoZSBHaWdhRGV2aWNl IEdENUYxR1E0VUZ4eEcgU1BJIE5BTkQgaXMgaW4gY3VycmVudCBwcm9kdWN0aW9uIGRldmljZXMK PiA+Pj4gYW5kLCB3aGlsZSBpdCBoYXMgdGhlIHNhbWUgbG9naWNhbCBsYXlvdXQgYXMgdGhlIEUt c2VyaWVzIGRldmljZXMsCj4gPj4+IGl0IGRpZmZlcnMgaW4gdGhlIFNQSSBpbnRlcmZhY2luZyBp biBzaWduaWZpY2FudCB3YXlzLgo+ID4+Pgo+ID4+PiBUaGlzIHN1cHBvcnQgaXMgY29udGluZ2Vu dCBvbiBwcmV2aW91cyBjb21taXRzIHRvOgo+ID4+Pgo+ID4+PiDCoMKgwqAgKiBBZGQgc3VwcG9y dCBmb3IgdHdvLWJ5dGUgZGV2aWNlIElEcwo+ID4+PiDCoMKgwqAgKiBEZWZpbmUgbWFjcm9zIGZv ciBwYWdlLXJlYWQgb3BzIHdpdGggdGhyZWUtYnl0ZSBhZGRyZXNzZXMKPiA+Pj4KPiA+Pj4gaHR0 cDovL3d3dy5naWdhZGV2aWNlLmNvbS9kYXRhc2hlZXQvZ2Q1ZjFncTR4Znh4Zy8KPiA+Pj4KPiA+ Pj4gU2lnbmVkLW9mZi1ieTogSmVmZiBLbGV0c2t5IDxnaXQtY29tbWl0c0BhbGx5Y29tbS5jb20+ ICAKPiA+PiBSZXZpZXdlZC1ieTogRnJpZWRlciBTY2hyZW1wZiA8ZnJpZWRlci5zY2hyZW1wZkBr b250cm9uLmRlPgo+ID4+ICAKPiA+Pj4gUmVwb3J0ZWQtYnk6IGtidWlsZCB0ZXN0IHJvYm90IDxs a3BAaW50ZWwuY29tPiAgCj4gPj4gSSBkb250J3QgdGhpbmsgdGhhdCB0aGlzIFJlcG9ydGVkLWJ5 IHRhZyBzaG91bGQgYmUgdXNlZCBoZXJlLiBUaGUgYm90Cj4gPj4gcmVwb3J0ZWQgYnVpbGQgZXJy b3JzIGNhdXNlZCBieSB5b3VyIHBhdGNoIGFuZCB5b3UgZml4ZWQgaXQgaW4gYSBuZXcKPiA+PiB2 ZXJzaW9uLiBBcyBmYXIgYXMgSSB1bmRlcnN0YW5kIHRoaXMgdGFnLCBpdCByZWZlcmVuY2VzIHNv bWVvbmUgd2hvCj4gPj4gcmVwb3J0ZWQgYSBmbGF3L2J1ZyB0aGF0IGxlZCB0byB0aGlzIGNoYW5n ZSBpbiB0aGUgZmlyc3QgcGxhY2UuCj4gPj4gVGhlIHZlcnNpb24gaGlzdG9yeSBvZiB0aGUgY2hh bmdlcyB3b24ndCBiZSB2aXNpYmxlIGluIHRoZSBnaXQgaGlzdG9yeQo+ID4+IGxhdGVyLCBidXQg dGhlIHRhZyB3aWxsIGJlIGFuZCB3b3VsZCBiZSByYXRoZXIgY29uZnVzaW5nLiAgCj4gPiAKPiA+ IFRoYW5rIHlvdSBmb3IgeW91ciBwYXRpZW5jZSBhbmQgZXhwbGFuYXRpb25zLiBJJ3ZlIGJlZW4g YmVpbmcgY29uc2VydmF0aXZlCj4gPiBhcyBJJ20gbm90IGEgInNlYXNvbmVkLCBMaW51eCBwcm9m ZXNzaW9uYWwiIGFuZCBhbSBzdGlsbCBnZXR0aW5nIG15Cj4gPiBnaXQgc2VuZC1lbWFpbCBjb25m aWcgLyBjb21tYW5kIGxpbmUgZm9yIExpbnV4IHByb3Blcmx5IHN0cmFpZ2h0ZW5lZCBvdXQuICAK PiAKPiBCZWluZyBjb25zZXJ2YXRpdmUgaW4gc3VjaCBjYXNlcyBpcyBub3QgYSBmYXVsdCBhdCBh bGwuIEknbSBub3QgYW4gCj4gZXhwZXJ0IGVpdGhlci4gSSdtIGp1c3QgcmVjb21tZW5kaW5nIHdo YXQgSSB0aGluayBtaWdodCBiZSB0aGUgImNvcnJlY3QiIAo+IHdheSB0byBkbyBpdC4KPiAKPiA+ IFNob3VsZCBJIHNlbmQgYW5vdGhlciBwYXRjaCBzZXQgd2l0aCB0aGUgYGtidWlsZC4uLmAgdGFn IHJlbW92ZWQsCj4gPiBvciB3b3VsZCBpdCBiZSByZW1vdmVkIGluIHRoZSBwcm9jZXNzIG9mIGFu IGFwcHJvcHJpYXRlIG1lbWJlcgo+ID4gb2YgdGhlIExpbnV4IE1URCB0ZWFtIGFkZGluZyB0aGVp ciB0YWcgZm9yIGFwcHJvdmFsLCBpZiBhbmQgd2hlbgo+ID4gdGhhdCBoYXBwZW5zPyAgCj4gCj4g SSBkb24ndCB0aGluayB0aGF0J3MgbmVjZXNzYXJ5LiBNaXF1w6hsIGlzIHRoZSBvbmUgdG8gcGlj ayB1cCB0aGUgcGF0Y2gsIAo+IHNvIGhlIGNvdWxkIHByb2JhYmx5IGRyb3AgdGhlICJSZXBvcnRl ZC1ieToga2J1aWxkIiB3aGVuIGhlIGFwcGxpZXMgaXQuCgpJIHdpbGwgZHJvcCBpdC4KCkFsc28s IHBsZWFzZSBkbyBub3QgYWRkIGFuIGVtcHR5IGxpbmUgYmV0d2VlbiB0YWdzLCB0aGV5IHNob3Vs ZCBiZSBhCnNpbmdsZSBibG9jay4gSSB3aWxsIGFsc28gbW9kaWZ5IHlvdXIgY29tbWl0cyBmb3Ig dGhpcyB0aW1lLgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBs aXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRk Lwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10990C07542 for ; Mon, 27 May 2019 09:28:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2C0C2173B for ; Mon, 27 May 2019 09:28:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbfE0J2I convert rfc822-to-8bit (ORCPT ); Mon, 27 May 2019 05:28:08 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:34671 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725940AbfE0J2H (ORCPT ); Mon, 27 May 2019 05:28:07 -0400 Received: from xps13 (aaubervilliers-681-1-27-134.w90-88.abo.wanadoo.fr [90.88.147.134]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id EC5A420000F; Mon, 27 May 2019 09:28:03 +0000 (UTC) Date: Mon, 27 May 2019 11:28:02 +0200 From: Miquel Raynal To: Schrempf Frieder Cc: Jeff Kletsky , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 3/3] mtd: spinand: Add support for GigaDevice GD5F1GQ4UFxxG Message-ID: <20190527112802.08b86fa5@xps13> In-Reply-To: <34004a59-5643-e405-13ca-3581659fc745@kontron.de> References: <20190522220555.11626-1-lede@allycomm.com> <20190522220555.11626-4-lede@allycomm.com> <34004a59-5643-e405-13ca-3581659fc745@kontron.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Schrempf, Schrempf Frieder wrote on Mon, 27 May 2019 06:35:59 +0000: > Hi Jeff, > > On 24.05.19 02:12, Jeff Kletsky wrote: > > (reduced direct addressees, though still on lists) > > > > On 5/22/19 11:42 PM, Schrempf Frieder wrote: > > > >> On 23.05.19 00:05, Jeff Kletsky wrote: > >>> From: Jeff Kletsky > >>> > >>> The GigaDevice GD5F1GQ4UFxxG SPI NAND is in current production devices > >>> and, while it has the same logical layout as the E-series devices, > >>> it differs in the SPI interfacing in significant ways. > >>> > >>> This support is contingent on previous commits to: > >>> > >>>     * Add support for two-byte device IDs > >>>     * Define macros for page-read ops with three-byte addresses > >>> > >>> http://www.gigadevice.com/datasheet/gd5f1gq4xfxxg/ > >>> > >>> Signed-off-by: Jeff Kletsky > >> Reviewed-by: Frieder Schrempf > >> > >>> Reported-by: kbuild test robot > >> I dont't think that this Reported-by tag should be used here. The bot > >> reported build errors caused by your patch and you fixed it in a new > >> version. As far as I understand this tag, it references someone who > >> reported a flaw/bug that led to this change in the first place. > >> The version history of the changes won't be visible in the git history > >> later, but the tag will be and would be rather confusing. > > > > Thank you for your patience and explanations. I've been being conservative > > as I'm not a "seasoned, Linux professional" and am still getting my > > git send-email config / command line for Linux properly straightened out. > > Being conservative in such cases is not a fault at all. I'm not an > expert either. I'm just recommending what I think might be the "correct" > way to do it. > > > Should I send another patch set with the `kbuild...` tag removed, > > or would it be removed in the process of an appropriate member > > of the Linux MTD team adding their tag for approval, if and when > > that happens? > > I don't think that's necessary. Miquèl is the one to pick up the patch, > so he could probably drop the "Reported-by: kbuild" when he applies it. I will drop it. Also, please do not add an empty line between tags, they should be a single block. I will also modify your commits for this time. Thanks, Miquèl