From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6740C04AB3 for ; Mon, 27 May 2019 11:41:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A6D02146F for ; Mon, 27 May 2019 11:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558957318; bh=J5mxz3lsAdesKPBlaZXG7xa+WnIOQtaO1JlYDeS713o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=D5ndzn863I1EM95sRWIZqCewvCeb9iT4b2CN8mdXpYj7Jl7tuiV5Z4niEkFMw4/Sk mQeZQAijxk9SfNquXO6EWEgcnuflcJ+TijM3U70AIVbISVfj/k+0CYsfrwmVzisVER v5fnj5c2xdFyh+9kem16mmrYaw+TVWOONfKnkJNM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725991AbfE0Ll5 (ORCPT ); Mon, 27 May 2019 07:41:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:49522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbfE0Ll5 (ORCPT ); Mon, 27 May 2019 07:41:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1072820815; Mon, 27 May 2019 11:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558957316; bh=J5mxz3lsAdesKPBlaZXG7xa+WnIOQtaO1JlYDeS713o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M5OxsDKCaTQtCcsJcdqVHsjA/8skIXO2ITZisTGLHIqalr6VEn8hWVeBcwpeso+al fCk9VYafaRHlGw2NzMouqBhnfsVoOS6V/PkEJGle+0sB+8M0yX5T6IDJZJ6wS156Q2 QPHqILlVBsw1zY8nUEywKJiq/7n1k1Lb5Gigm6Ho= Date: Mon, 27 May 2019 13:41:53 +0200 From: Greg Kroah-Hartman To: Amir Goldstein Cc: Jan Kara , David Sterba , Christoph Hellwig , Joel Becker , John Johansen , Trond Myklebust , Anna Schumaker , Steven Rostedt , Al Viro , linux-fsdevel Subject: Re: [PATCH v3 00/10] Sort out fsnotify_nameremove() mess Message-ID: <20190527114153.GA5562@kroah.com> References: <20190526143411.11244-1-amir73il@gmail.com> <20190527082457.GE21124@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, May 27, 2019 at 12:49:23PM +0300, Amir Goldstein wrote: > On Mon, May 27, 2019 at 11:25 AM Greg Kroah-Hartman > wrote: > > > > On Sun, May 26, 2019 at 05:34:01PM +0300, Amir Goldstein wrote: > > > Jan, > > > > > > For v3 I went with a straight forward approach. > > > Filesystems that have fsnotify_{create,mkdir} hooks also get > > > explicit fsnotify_{unlink,rmdir} hooks. > > > > > > Hopefully, this approach is orthogonal to whatever changes Al is > > > planning for recursive tree remove code, because in many of the > > > cases, the hooks are added at the entry point for the recursive > > > tree remove. > > > > > > After looking closer at all the filesystems that were converted to > > > simple_remove in v2, I decided to exempt another 3 filesystems from > > > the fsnotify delete hooks: hypfs,qibfs and aafs. > > > hypfs is pure cleanup (*). qibfs and aafs can remove dentry on user > > > configuration change, but they do not generate create events, so it > > > is less likely that users depend on the delete events. > > > > > > That leaves configfs the only filesystem that gets the new delete hooks > > > even though it does not have create hooks. > > > > why doesn't configfs have create hooks? That's what userspace does in > > configfs, shouldn't it be notified about it? Keeping it "unequal" seems > > odd to me. > > > > So it's not exactly that configfs has no create hooks at all. > For "normal" filesystems mkdir (for example) is only possible > by mkdir(2) syscall and there is create hook in vfs_mkdir(). Ah, ok, missed that. thanks, greg k-h