From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
Grzegorz Jaszczyk <jaz@semihalf.com>
Subject: Re: [PATCH] dt-bindings: phy: mvebu-comphy: Update references to CP110 nodes
Date: Mon, 27 May 2019 14:09:28 +0200 [thread overview]
Message-ID: <20190527140928.5df3f704@xps13> (raw)
In-Reply-To: <CAL_JsqJ=gFK604Wbd0D4NN__L4ZfKDO7+j8OGh_buq06oA6deQ@mail.gmail.com>
Hi Rob,
Rob Herring <robh+dt@kernel.org> wrote on Wed, 22 May 2019 08:15:27
-0500:
> On Tue, May 21, 2019 at 9:35 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > From: Grzegorz Jaszczyk <jaz@semihalf.com>
> >
> > The CP110 DT nodes references have changed, reflect these changes in
> > COMPHY documentation.
>
> This change isn't necessary. The examples are just examples. They
> don't have to match anything exactly.
Ok then, let's drop it.
>
> >
> > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com>
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > .../devicetree/bindings/phy/phy-mvebu-comphy.txt | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> > index cf2cd86db267..af2402c18513 100644
> > --- a/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> > +++ b/Documentation/devicetree/bindings/phy/phy-mvebu-comphy.txt
> > @@ -35,19 +35,19 @@ Required properties (child nodes):
> >
> > Examples:
> >
> > - cpm_comphy: phy@120000 {
> > + CP110_LABEL(comphy): phy@120000 {
>
> Also, as we convert bindings to schema, the examples are compiled and
> this won't without CP110_LABEL defined.
I didn't thought about the YAML schema conversion issue (IIRC there are
already occurrences of such macro in the bindings).
Thanks,
Miquèl
prev parent reply other threads:[~2019-05-27 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 14:35 [PATCH] dt-bindings: phy: mvebu-comphy: Update references to CP110 nodes Miquel Raynal
2019-05-22 13:15 ` Rob Herring
2019-05-27 12:09 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527140928.5df3f704@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=antoine.tenart@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=jaz@semihalf.com \
--cc=kishon@ti.com \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.