All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	David Airlie <airlied@linux.ie>, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v2 0/7] drm: make headers self-contained and drop drmP.h
Date: Mon, 27 May 2019 20:05:46 +0200	[thread overview]
Message-ID: <20190527180546.GA21925@ravnborg.org> (raw)
In-Reply-To: <20190527061835.GH21222@phenom.ffwll.local>

On Mon, May 27, 2019 at 08:18:35AM +0200, Daniel Vetter wrote:
> On Sun, May 26, 2019 at 07:35:28PM +0200, Sam Ravnborg wrote:
> > While removing use of drmP.h from files in drm/* I
> > noticed that I had to add the same include files due to
> > dependencies in the header files.
> > 
> > It is better to let the header files be self-contained and
> > let the users pull in only the additional headers files required.
> > So I went ahead and made the relevant header files self-contained.
> > (I did not check if this made any includes redundant in some files,
> > I do not have tooling in place to do so).
> > 
> > Daniel suggested to add support for testing that they stay
> > self contained.
> > Jani Nikula has sent a patch to kbuild to make this part of the
> > kbuild machinery. I have used it locally and as soon as it
> > lands in kbuild I will start using it for drm.
> > We could have duplicated the infrastructure now but that seemed
> > too much code chrunch.
> > 
> > This patchset include the actual removal of drmP.h as one big patch.
> > This is build tested on alpha (always interesting), arm, arm64, x86 etc.
> > 
> > For all files touched the following was done:
> > - include files divided up in blocks in following order:
> >     	linux/*
> > 	video/*
> > 	drm/*
> > 	""
> > - within each block the include files are sorted alphabetically
> > 
> > v2:
> > - use same ordering af blocks
> > - move includes down below license text
> > - added patch with actual drmP.h removal
> > - reworded some subjects to make them more descriptive
> > - fixed a few spelling erros in changelogs (but a few may remain)
> > 
> >         Sam
> 
> On the series:
> 
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> Did a bit of scrolling, looks all reasonable, but definitely didn't check
> things in-depth.
Thanks, applied and will be pushed out in a minute.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-05-27 18:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-26 17:35 [PATCH v2 0/7] drm: make headers self-contained and drop drmP.h Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 1/7] drm: make drm/drm_auth.h self contained Sam Ravnborg
2019-05-28 12:54   ` Jani Nikula
2019-05-28 13:07     ` Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 2/7] drm: make drm/drm_legacy.h self-contained Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 3/7] drm: make drm_crtc_internal.h self-contained Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 4/7] drm: make drm_internal.h self-contained Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 5/7] drm: make drm_legacy.h self-contained Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 6/7] drm: make drm_trace.h self-contained Sam Ravnborg
2019-05-26 17:35 ` [PATCH v2 7/7] drm: drop use of drmP.h in drm/* Sam Ravnborg
2019-05-26 18:05 ` ✗ Fi.CI.CHECKPATCH: warning for drm: make headers self-contained and drop drmP.h Patchwork
2019-05-26 18:08 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-05-26 18:25 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-27  6:18 ` [PATCH v2 0/7] " Daniel Vetter
2019-05-27  6:54   ` Sam Ravnborg
2019-05-27 18:05   ` Sam Ravnborg [this message]
2019-05-27 12:00 ` ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190527180546.GA21925@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.