From: Kalle Valo <kvalo@codeaurora.org>
To: Gen Zhang <blackgod016574@gmail.com>
Cc: davem@davemloft.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wlcore: spi: Fix a memory leaking bug in wl1271_probe()
Date: Tue, 28 May 2019 11:39:23 +0000 (UTC) [thread overview]
Message-ID: <20190528113923.062376077A@smtp.codeaurora.org> (raw)
In-Reply-To: <20190524030117.GA6024@zhanggen-UX430UQ>
Gen Zhang <blackgod016574@gmail.com> wrote:
> In wl1271_probe(), 'glue->core' is allocated by platform_device_alloc(),
> when this allocation fails, ENOMEM is returned. However, 'pdev_data'
> and 'glue' are allocated by devm_kzalloc() before 'glue->core'. When
> platform_device_alloc() returns NULL, we should also free 'pdev_data'
> and 'glue' before wl1271_probe() ends to prevent leaking memory.
>
> Similarly, we shoulf free 'pdev_data' when 'glue' is NULL. And we should
> free 'pdev_data' and 'glue' when 'glue->reg' is error and when 'ret' is
> error.
>
> Further, we should free 'glue->core', 'pdev_data' and 'glue' when this
> function normally ends to prevent leaking memory.
>
> Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
Same questions as with similar SDIO patch:
https://patchwork.kernel.org/patch/10959049/
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/10959053/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-05-28 11:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 3:02 [PATCH] wlcore: spi: Fix a memory leaking bug in wl1271_probe() Gen Zhang
2019-05-28 11:39 ` Kalle Valo [this message]
[not found] ` <20190528113922.E2B1060312@smtp.codeaurora.org>
2019-05-28 12:14 ` Gen Zhang
2019-05-28 12:33 ` Kalle Valo
2019-05-28 12:38 ` Gen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528113923.062376077A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=blackgod016574@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.