From: Christoph Hellwig <hch@infradead.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] powerpc/configs: Rename foo_basic_defconfig to foo_base.config
Date: Tue, 28 May 2019 05:10:09 -0700 [thread overview]
Message-ID: <20190528121009.GA11901@infradead.org> (raw)
In-Reply-To: <20190528081614.26096-1-mpe@ellerman.id.au>
On Tue, May 28, 2019 at 06:16:14PM +1000, Michael Ellerman wrote:
> We have several "defconfigs" that are not actually full defconfigs
> they are just a base set of options which are then merged with other
> fragments to produce a working defconfig.
>
> The most obvious example is corenet_basic_defconfig which only
> contains one symbol CONFIG_CORENET_GENERIC=y. But there is also
> mpc85xx_base_defconfig which doesn't actually enable CONFIG_PPC_85xx.
>
> To avoid confusion, rename these config fragments to "foo_base.config"
> to make it clearer that they are not full defconfigs.
Adding linux-kbuild, maybe we can make the handling of these fragments
generic and actually document it..
>
> Reported-by: Christophe Leroy <christophe.leroy@c-s.fr>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> arch/powerpc/Makefile | 12 ++++++------
> .../{corenet_basic_defconfig => corenet_base.config} | 0
> .../{mpc85xx_basic_defconfig => mpc85xx_base.config} | 0
> .../{mpc86xx_basic_defconfig => mpc86xx_base.config} | 0
> 4 files changed, 6 insertions(+), 6 deletions(-)
> rename arch/powerpc/configs/{corenet_basic_defconfig => corenet_base.config} (100%)
> rename arch/powerpc/configs/{mpc85xx_basic_defconfig => mpc85xx_base.config} (100%)
> rename arch/powerpc/configs/{mpc86xx_basic_defconfig => mpc86xx_base.config} (100%)
>
> diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> index c345b79414a9..94f735db2229 100644
> --- a/arch/powerpc/Makefile
> +++ b/arch/powerpc/Makefile
> @@ -333,32 +333,32 @@ PHONY += powernv_be_defconfig
>
> PHONY += mpc85xx_defconfig
> mpc85xx_defconfig:
> - $(call merge_into_defconfig,mpc85xx_basic_defconfig,\
> + $(call merge_into_defconfig,mpc85xx_base.config,\
> 85xx-32bit 85xx-hw fsl-emb-nonhw)
>
> PHONY += mpc85xx_smp_defconfig
> mpc85xx_smp_defconfig:
> - $(call merge_into_defconfig,mpc85xx_basic_defconfig,\
> + $(call merge_into_defconfig,mpc85xx_base.config,\
> 85xx-32bit 85xx-smp 85xx-hw fsl-emb-nonhw)
>
> PHONY += corenet32_smp_defconfig
> corenet32_smp_defconfig:
> - $(call merge_into_defconfig,corenet_basic_defconfig,\
> + $(call merge_into_defconfig,corenet_base.config,\
> 85xx-32bit 85xx-smp 85xx-hw fsl-emb-nonhw dpaa)
>
> PHONY += corenet64_smp_defconfig
> corenet64_smp_defconfig:
> - $(call merge_into_defconfig,corenet_basic_defconfig,\
> + $(call merge_into_defconfig,corenet_base.config,\
> 85xx-64bit 85xx-smp altivec 85xx-hw fsl-emb-nonhw dpaa)
>
> PHONY += mpc86xx_defconfig
> mpc86xx_defconfig:
> - $(call merge_into_defconfig,mpc86xx_basic_defconfig,\
> + $(call merge_into_defconfig,mpc86xx_base.config,\
> 86xx-hw fsl-emb-nonhw)
>
> PHONY += mpc86xx_smp_defconfig
> mpc86xx_smp_defconfig:
> - $(call merge_into_defconfig,mpc86xx_basic_defconfig,\
> + $(call merge_into_defconfig,mpc86xx_base.config,\
> 86xx-smp 86xx-hw fsl-emb-nonhw)
>
> PHONY += ppc32_allmodconfig
> diff --git a/arch/powerpc/configs/corenet_basic_defconfig b/arch/powerpc/configs/corenet_base.config
> similarity index 100%
> rename from arch/powerpc/configs/corenet_basic_defconfig
> rename to arch/powerpc/configs/corenet_base.config
> diff --git a/arch/powerpc/configs/mpc85xx_basic_defconfig b/arch/powerpc/configs/mpc85xx_base.config
> similarity index 100%
> rename from arch/powerpc/configs/mpc85xx_basic_defconfig
> rename to arch/powerpc/configs/mpc85xx_base.config
> diff --git a/arch/powerpc/configs/mpc86xx_basic_defconfig b/arch/powerpc/configs/mpc86xx_base.config
> similarity index 100%
> rename from arch/powerpc/configs/mpc86xx_basic_defconfig
> rename to arch/powerpc/configs/mpc86xx_base.config
> --
> 2.20.1
>
---end quoted text---
next prev parent reply other threads:[~2019-05-28 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 8:16 [PATCH] powerpc/configs: Rename foo_basic_defconfig to foo_base.config Michael Ellerman
2019-05-28 12:10 ` Christoph Hellwig [this message]
2019-05-29 1:02 ` Masahiro Yamada
2019-05-29 1:02 ` Masahiro Yamada
2019-05-29 13:55 ` Michael Ellerman
2019-10-30 12:14 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528121009.GA11901@infradead.org \
--to=hch@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.