All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Juan Quintela" <quintela@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI
Date: Tue, 28 May 2019 15:42:04 +0100	[thread overview]
Message-ID: <20190528144204.GF2724@work-vm> (raw)
In-Reply-To: <20190528135144.24028-1-philmd@redhat.com>

* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> This started to fail 6 months ago [1] and lately occurs too
> often on the main Travis CI.
> 
> Travis CI set the CONTINUOUS_INTEGRATION variable in the process
> environment [2]. Let's use it to disable it when running this test
> there.
> 
> [1] https://travis-ci.org/philmd/qemu/jobs/466594203#L4430
> [2] https://docs.travis-ci.com/user/environment-variables/#default-environment-variables

I think the right solution here is to disable it under TCG.

Dave

> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  tests/migration-test.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index bd3f5c3125..c5091e1fb1 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -764,6 +764,11 @@ static void test_postcopy(void)
>  {
>      QTestState *from, *to;
>  
> +    if (getenv("CONTINUOUS_INTEGRATION")) {
> +        /* Test failing on Travis-CI */
> +        g_test_skip("Running on Travis-CI");
> +    }
> +
>      if (migrate_postcopy_prepare(&from, &to, false)) {
>          return;
>      }
> -- 
> 2.20.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK


  reply	other threads:[~2019-05-28 14:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28 13:51 [Qemu-devel] [PATCH] tests/migration: Disable /migration/postcopy/unix qtest on Travis-CI Philippe Mathieu-Daudé
2019-05-28 14:42 ` Dr. David Alan Gilbert [this message]
2019-05-28 14:46   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190528144204.GF2724@work-vm \
    --to=dgilbert@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=fam@euphon.net \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.