From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [RESEND PATCH v2 2/2] drm/panfrost: Expose perf counters through debugfs Date: Tue, 28 May 2019 15:53:48 +0200 Message-ID: <20190528155348.597b332a@collabora.com> References: <20190514104801.20448-1-boris.brezillon@collabora.com> <20190514104801.20448-3-boris.brezillon@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id CA22089C1B for ; Tue, 28 May 2019 13:53:52 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Steven Price Cc: Rob Herring , kernel@collabora.com, Alyssa Rosenzweig , dri-devel List-Id: dri-devel@lists.freedesktop.org SGkgU3RldmUsCgpPbiBUaHUsIDE2IE1heSAyMDE5IDE3OjIxOjM5ICswMTAwClN0ZXZlbiBQcmlj ZSA8c3RldmVuLnByaWNlQGFybS5jb20+IHdyb3RlOgoKCj4gPj4gK3N0YXRpYyB2b2lkIHBhbmZy b3N0X3BlcmZjbnRfc2V0dXAoc3RydWN0IHBhbmZyb3N0X2RldmljZSAqcGZkZXYpCj4gPj4gK3sK PiA+PiArICAgICAgIHUzMiBjZmc7Cj4gPj4gKwo+ID4+ICsgICAgICAgLyoKPiA+PiArICAgICAg ICAqIEFsd2F5cyB1c2UgYWRkcmVzcyBzcGFjZSAwIGZvciBub3cuCj4gPj4gKyAgICAgICAgKiBG SVhNRTogdGhpcyBuZWVkcyB0byBiZSB1cGRhdGVkIHdoZW4gd2Ugc3RhcnQgdXNpbmcgZGlmZmVy ZW50Cj4gPj4gKyAgICAgICAgKiBhZGRyZXNzIHNwYWNlLgo+ID4+ICsgICAgICAgICovCj4gPj4g KyAgICAgICBjZmcgPSBHUFVfUEVSRkNOVF9DRkdfQVMoMCk7Cj4gPj4gKyAgICAgICBpZiAocGFu ZnJvc3RfbW9kZWxfY21wKHBmZGV2LCAweDEwMDApID49IDApICAKPiA+IAo+ID4gWW91J3ZlIGdv dCBhIGNvdXBsZSBvZiB0aGVzZS4gUGVyaGFwcyB3ZSBzaG91bGQgYWRkIGVpdGhlciBhCj4gPiBt b2RlbF9pc19iaWZyb3N0KCkgaGVscGVyIG9yIGFuIGlzX2JpZnJvc3QgdmFyaWFibGUgdG8gdXNl Lgo+ID4gICAKPiA+PiArICAgICAgICAgICAgICAgY2ZnIHw9IEdQVV9QRVJGQ05UX0NGR19TRVRT RUwoMSk7ICAKPiAKPiBtYWxpX2tiYXNlIG9ubHkgc2V0cyB0aGlzIGlmIENPTkZJR19NQUxJX1BS RkNOVF9TRVRfU0VDT05EQVJZIGlzIGRlZmluZWQKPiAtIGkuZS4gdGhpcyBzZWxlY3RzIGEgZGlm ZmVyZW50IHNlbGVjdGlvbiBvZiBjb3VudGVycy4gQXQgYXQgdGhlIHZlcnkKPiBsZWFzdCB0aGlz IHNob3VsZCBiZSBhbiBvcHRpb25hbCBmbGFnIHRoYXQgY2FuIGJlIHNldCwgYnV0IEkgc3VzcGVj dCB0aGUKPiBwcmltYXJ5IHNldCBhcmUgdGhlIG9uZXMgeW91IGFyZSBpbnRlcmVzdGVkIGluLgoK SSdsbCBhZGQgYSBwYXJhbSB0byBwYXNzIHRoZSBzZXQgb2YgY291bnRlcnMgdG8gbW9uaXRvci4K Cj4gCj4gPj4gKwo+ID4+ICsgICAgICAgZ3B1X3dyaXRlKHBmZGV2LCBHUFVfUEVSRkNOVF9DRkcs Cj4gPj4gKyAgICAgICAgICAgICAgICAgY2ZnIHwgR1BVX1BFUkZDTlRfQ0ZHX01PREUoR1BVX1BF UkZDTlRfQ0ZHX01PREVfT0ZGKSk7Cj4gPj4gKwo+ID4+ICsgICAgICAgaWYgKCFwZmRldi0+cGVy ZmNudC0+ZW5hYmxlZCkKPiA+PiArICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4+ICsKPiA+PiAr ICAgICAgIGdwdV93cml0ZShwZmRldiwgR1BVX1BSRkNOVF9KTV9FTiwgMHhmZmZmZmZmZik7Cj4g Pj4gKyAgICAgICBncHVfd3JpdGUocGZkZXYsIEdQVV9QUkZDTlRfU0hBREVSX0VOLCAweGZmZmZm ZmZmKTsKPiA+PiArICAgICAgIGdwdV93cml0ZShwZmRldiwgR1BVX1BSRkNOVF9NTVVfTDJfRU4s IDB4ZmZmZmZmZmYpOwo+ID4+ICsKPiA+PiArICAgICAgIC8qCj4gPj4gKyAgICAgICAgKiBEdWUg dG8gUFJMQU0tODE4NiB3ZSBuZWVkIHRvIGRpc2FibGUgdGhlIFRpbGVyIGJlZm9yZSB3ZSBlbmFi bGUgSFcKPiA+PiArICAgICAgICAqIGNvdW50ZXJzLiAgCj4gPiAKPiA+IFNlZW1zIGxpa2UgeW91 IGNvdWxkIGp1c3QgYWx3YXlzIGFwcGx5IHRoZSB3b3JrLWFyb3VuZD8gSXQgZG9lc24ndAo+ID4g bG9vayBsaWtlIGl0IHdvdWxkIGJlIG11Y2ggZGlmZmVyZW50LiAgCj4gCj4gVGVjaG5pY2FsbHkg dGhlIHdvcmthcm91bmQgY2F1c2VzIHRoZSBkcml2ZXIgdG8gcGVyZm9ybSB0aGUgb3BlcmF0aW9u IGluCj4gdGhlIHdyb25nIG9yZGVyIGJlbG93ICh3cml0ZSBUSUxFUl9FTiB3aGVuIHRoZSBtb2Rl IGlzIE1BTlVBTCkgLSB0aGlzIGlzCj4gYSB3b3JrYXJvdW5kIGZvciB0aGUgaGFyZHdhcmUgaXNz dWUgKGFuZCB0aGVyZWZvcmUgd29ya3Mgb24gdGhhdAo+IGhhcmR3YXJlKS4gQnV0IEkgd291bGRu J3QgbGlrZSB0byBzYXkgaXQgd29ya3Mgb24gb3RoZXIgaGFyZHdhcmUgd2hpY2gKPiBkb2Vzbid0 IGhhdmUgdGhlIGlzc3VlLgoKT2theSwgSSdsbCBrZWVwIHRoZSB3b3JrYXJvdW5kIG9ubHkgZm9y IEhXIHRoYXQgYXJlIGltcGFjdGVkIGJ5IHRoZSBidWcuCgo+IAo+ID4+ICsgICAgICAgICovCj4g Pj4gKyAgICAgICBpZiAocGFuZnJvc3RfaGFzX2h3X2lzc3VlKHBmZGV2LCBIV19JU1NVRV84MTg2 KSkKPiA+PiArICAgICAgICAgICAgICAgZ3B1X3dyaXRlKHBmZGV2LCBHUFVfUFJGQ05UX1RJTEVS X0VOLCAwKTsKPiA+PiArICAgICAgIGVsc2UKPiA+PiArICAgICAgICAgICAgICAgZ3B1X3dyaXRl KHBmZGV2LCBHUFVfUFJGQ05UX1RJTEVSX0VOLCAweGZmZmZmZmZmKTsKPiA+PiArCj4gPj4gKyAg ICAgICBncHVfd3JpdGUocGZkZXYsIEdQVV9QRVJGQ05UX0NGRywKPiA+PiArICAgICAgICAgICAg ICAgICBjZmcgfCBHUFVfUEVSRkNOVF9DRkdfTU9ERShHUFVfUEVSRkNOVF9DRkdfTU9ERV9NQU5V QUwpKTsKPiA+PiArCj4gPj4gKyAgICAgICBpZiAocGFuZnJvc3RfaGFzX2h3X2lzc3VlKHBmZGV2 LCBIV19JU1NVRV84MTg2KSkKPiA+PiArICAgICAgICAgICAgICAgZ3B1X3dyaXRlKHBmZGV2LCBH UFVfUFJGQ05UX1RJTEVSX0VOLCAweGZmZmZmZmZmKTsKPiA+PiArfQoKWy4uLl0KCj4gPj4gK2lu dCBwYW5mcm9zdF9wZXJmY250X2luaXQoc3RydWN0IHBhbmZyb3N0X2RldmljZSAqcGZkZXYpCj4g Pj4gK3sKPiA+PiArICAgICAgIHN0cnVjdCBwYW5mcm9zdF9wZXJmY250ICpwZXJmY250Owo+ID4+ ICsgICAgICAgc3RydWN0IGRybV9nZW1fc2htZW1fb2JqZWN0ICpibzsKPiA+PiArICAgICAgIHNp emVfdCBzaXplOwo+ID4+ICsgICAgICAgdTMyIHN0YXR1czsKPiA+PiArICAgICAgIGludCByZXQ7 Cj4gPj4gKwo+ID4+ICsgICAgICAgaWYgKHBhbmZyb3N0X2hhc19od19mZWF0dXJlKHBmZGV2LCBI V19GRUFUVVJFX1Y0KSkgewo+ID4+ICsgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgbmNvcmVn cm91cHM7Cj4gPj4gKwo+ID4+ICsgICAgICAgICAgICAgICBuY29yZWdyb3VwcyA9IGh3ZWlnaHQ2 NChwZmRldi0+ZmVhdHVyZXMubDJfcHJlc2VudCk7Cj4gPj4gKyAgICAgICAgICAgICAgIHNpemUg PSBuY29yZWdyb3VwcyAqIEJMT0NLU19QRVJfQ09SRUdST1VQICoKPiA+PiArICAgICAgICAgICAg ICAgICAgICAgIENPVU5URVJTX1BFUl9CTE9DSyAqIEJZVEVTX1BFUl9DT1VOVEVSOwo+ID4+ICsg ICAgICAgfSBlbHNlIHsKPiA+PiArICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG5sMmMsIG5j b3JlczsKPiA+PiArCj4gPj4gKyAgICAgICAgICAgICAgIC8qCj4gPj4gKyAgICAgICAgICAgICAg ICAqIFRPRE86IGRlZmluZSBhIG1hY3JvIHRvIGV4dHJhY3QgdGhlIG51bWJlciBvZiBsMiBjYWNo ZXMgZnJvbQo+ID4+ICsgICAgICAgICAgICAgICAgKiBtZW1fZmVhdHVyZXMuCj4gPj4gKyAgICAg ICAgICAgICAgICAqLwo+ID4+ICsgICAgICAgICAgICAgICBubDJjID0gKChwZmRldi0+ZmVhdHVy ZXMubWVtX2ZlYXR1cmVzID4+IDgpICYgR0VOTUFTSygzLCAwKSkgKyAxOwo+ID4+ICsKPiA+PiAr ICAgICAgICAgICAgICAgLyoKPiA+PiArICAgICAgICAgICAgICAgICogVGhlIEFSTSBkcml2ZXIg aXMgZ3JvdXBpbmcgY29yZXMgcGVyIGNvcmUgZ3JvdXAgYW5kIHRoZW4KPiA+PiArICAgICAgICAg ICAgICAgICogb25seSB1c2luZyB0aGUgbnVtYmVyIG9mIGNvcmVzIGluIGdyb3VwIDAgdG8gY2Fs Y3VsYXRlIHRoZQo+ID4+ICsgICAgICAgICAgICAgICAgKiBzaXplLiBOb3Qgc3VyZSB3aHkgdGhp cyBpcyBkb25lIGxpa2UgdGhhdCwgYnV0IEkgZ3Vlc3MKPiA+PiArICAgICAgICAgICAgICAgICog c2hhZGVyX3ByZXNlbnQgd2lsbCBvbmx5IHNob3cgY29yZXMgaW4gdGhlIGZpcnN0IGdyb3VwCj4g Pj4gKyAgICAgICAgICAgICAgICAqIGFueXdheS4KPiA+PiArICAgICAgICAgICAgICAgICovICAK PiAKPiBJJ20gbm90IHN1cmUgSSB1bmRlcnN0YW5kIHRoaXMgY29tbWVudC4gSSdtIG5vdCBzdXJl IHdoaWNoIHZlcnNpb24gb2YKPiB0aGUgZHJpdmVyIHlvdSBhcmUgbG9va2luZyBhdCwgYnV0IHNo YWRlcl9wcmVzZW50IHNob3VsZCBjb250YWluIGFsbCB0aGUKPiBjb3JlcyAoaW4gZXZlcnkgY29y ZSBncm91cCkuCj4gCj4gVGhlIGtiYXNlIGRyaXZlciAoaW4gcGFuZnJvc3QncyBnaXQgdHJlZVsx XSksIGNvbnRhaW5zOgo+IAo+IAliYXNlX2dwdV9wcm9wcyAqcHJvcHMgPSAma2JkZXYtPmdwdV9w cm9wcy5wcm9wczsKPiAJdTMyIG5yX2wyID0gcHJvcHMtPmwyX3Byb3BzLm51bV9sMl9zbGljZXM7 Cj4gCXU2NCBjb3JlX21hc2sgPSBwcm9wcy0+Y29oZXJlbmN5X2luZm8uZ3JvdXBbMF0uY29yZV9t YXNrOwo+IAo+IAl1MzIgbnJfYmxvY2tzID0gZmxzNjQoY29yZV9tYXNrKTsKPiAKPiAJLyogSk0g YW5kIHRpbGVyIGNvdW50ZXIgYmxvY2tzIGFyZSBhbHdheXMgcHJlc2VudCAqLwo+IAlkdW1wX3Np emUgPSAoMiArIG5yX2wyICsgbnJfYmxvY2tzKSAqCj4gCQkJTlJfQ05UX1BFUl9CTE9DSyAqCj4g CQkJTlJfQllURVNfUEVSX0NOVDsKPiAKPiBbMV0KPiBodHRwczovL2dpdGxhYi5mcmVlZGVza3Rv cC5vcmcvcGFuZnJvc3QvbWFsaV9rYmFzZS9ibG9iL21hc3Rlci9kcml2ZXIvcHJvZHVjdC9rZXJu ZWwvZHJpdmVycy9ncHUvYXJtL21pZGdhcmQvbWFsaV9rYmFzZV92aW5zdHIuYwo+IAo+IGkuZS4g dGhlIG51bWJlciBvZiBjb3JlcyArIG51bWJlciBvZiBMMiBjYWNoZXMgKHBsdXMgMiBmb3IgSk0v dGlsZXIpCj4gbXVsdGlwbGllZCBieSB0aGUgYmxvY2sgc2l6ZS4KCkFjdHVhbGx5LCBJIHdhcyBy ZWZlcnJpbmcgdG8gd2hhdCdzIGRvbmUgaW4Ka2Jhc2VfZ3B1cHJvcHNfY29uc3RydWN0X2NvaGVy ZW50X2dyb3VwcygpIFsyXS4KCj4gCj4gQWxzbyBhbm90aGVyIGRpZmZlcmVuY2Ugd2l0aCB0aGUg YmVsb3cgaXMgdGhhdCBmbHM2NCBhbmQgaHdlaWdodDY0IGRvbid0Cj4gcmV0dXJuIHRoZSBzYW1l IG51bWJlcnMuIElmIHRoZSBjb3JlIG1hc2sgaXMgbm9uLWNvbnRpZ3VvdXMgdGhpcyB3aWxsCj4g cmV0dXJuIGRpZmZlcmVudCB2YWx1ZXMuCgpSaWdodCwgSSBzaG91bGQgdXNlIGZsczY0KCkgbm90 IGh3ZWlnaHQ2NCgpLgoKUmVnYXJkcywKCkJvcmlzCgpbMl1odHRwczovL2dpdGxhYi5mcmVlZGVz a3RvcC5vcmcvcGFuZnJvc3QvbWFsaV9rYmFzZS9ibG9iL21hc3Rlci9kcml2ZXIvcHJvZHVjdC9r ZXJuZWwvZHJpdmVycy9ncHUvYXJtL21pZGdhcmQvbWFsaV9rYmFzZV9ncHVwcm9wcy5jI0w3MQpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=