From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH 5/5] [RFC] devlink: Fix uninitialized error code in devlink_fmsg_prepare_skb() Date: Wed, 29 May 2019 10:04:52 +0200 Message-ID: <20190529080452.GE2252@nanopsycho> References: <20190528142424.19626-1-geert@linux-m68k.org> <20190528142424.19626-6-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190528142424.19626-6-geert@linux-m68k.org> Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Igor Konopko , David Howells , "Mohit P . Tahiliani" , Takashi Sakamoto , Eran Ben Elisha , Matias Bjorling , Jiri Pirko , "David S . Miller" , Jamal Hadi Salim , Cong Wang , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Joe Perches , Arnd Bergmann , Dan Carpenter , linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org Tue, May 28, 2019 at 04:24:24PM CEST, geert@linux-m68k.org wrote: >With gcc 4.1: > > net/core/devlink.c: In function ‘devlink_fmsg_prepare_skb’: > net/core/devlink.c:4325: warning: ‘err’ may be used uninitialized in this function > >Indeed, if the list has less than *start entries, an uninitialized error >code will be returned. > >Fix this by preinitializing err to zero. > >Fixes: 1db64e8733f65381 ("devlink: Add devlink formatted message (fmsg) API") >Signed-off-by: Geert Uytterhoeven >--- >I don't know if this can really happen, and if this is the right fix. >Perhaps err should be initialized to some valid error code instead? 0 is correct here. Acked-by: Jiri Pirko Thanks! >--- > net/core/devlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/net/core/devlink.c b/net/core/devlink.c >index d43bc52b8840d76b..91377e4eae9a43c1 100644 >--- a/net/core/devlink.c >+++ b/net/core/devlink.c >@@ -4321,8 +4321,8 @@ devlink_fmsg_prepare_skb(struct devlink_fmsg *fmsg, struct sk_buff *skb, > { > struct devlink_fmsg_item *item; > struct nlattr *fmsg_nlattr; >+ int err = 0; > int i = 0; >- int err; > > fmsg_nlattr = nla_nest_start_noflag(skb, DEVLINK_ATTR_FMSG); > if (!fmsg_nlattr) >-- >2.17.1 >