From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [RESEND PATCH v2 2/2] drm/panfrost: Expose perf counters through debugfs Date: Wed, 29 May 2019 08:55:18 +0200 Message-ID: <20190529085518.65c7550b@collabora.com> References: <20190514104801.20448-1-boris.brezillon@collabora.com> <20190514104801.20448-3-boris.brezillon@collabora.com> <20190528155348.597b332a@collabora.com> <20190528160115.5ef0a9b0@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id D36F689EB8 for ; Wed, 29 May 2019 06:55:23 +0000 (UTC) In-Reply-To: <20190528160115.5ef0a9b0@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Steven Price Cc: Rob Herring , kernel@collabora.com, Alyssa Rosenzweig , dri-devel List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyOCBNYXkgMjAxOSAxNjowMToxNSArMDIwMApCb3JpcyBCcmV6aWxsb24gPGJvcmlz LmJyZXppbGxvbkBjb2xsYWJvcmEuY29tPiB3cm90ZToKCj4gT24gVHVlLCAyOCBNYXkgMjAxOSAx NTo1Mzo0OCArMDIwMAo+IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGNvbGxhYm9y YS5jb20+IHdyb3RlOgo+IAo+ID4gSGkgU3RldmUsCj4gPiAKPiA+IE9uIFRodSwgMTYgTWF5IDIw MTkgMTc6MjE6MzkgKzAxMDAKPiA+IFN0ZXZlbiBQcmljZSA8c3RldmVuLnByaWNlQGFybS5jb20+ IHdyb3RlOgo+ID4gCj4gPiAgIAo+ID4gPiA+PiArc3RhdGljIHZvaWQgcGFuZnJvc3RfcGVyZmNu dF9zZXR1cChzdHJ1Y3QgcGFuZnJvc3RfZGV2aWNlICpwZmRldikKPiA+ID4gPj4gK3sKPiA+ID4g Pj4gKyAgICAgICB1MzIgY2ZnOwo+ID4gPiA+PiArCj4gPiA+ID4+ICsgICAgICAgLyoKPiA+ID4g Pj4gKyAgICAgICAgKiBBbHdheXMgdXNlIGFkZHJlc3Mgc3BhY2UgMCBmb3Igbm93Lgo+ID4gPiA+ PiArICAgICAgICAqIEZJWE1FOiB0aGlzIG5lZWRzIHRvIGJlIHVwZGF0ZWQgd2hlbiB3ZSBzdGFy dCB1c2luZyBkaWZmZXJlbnQKPiA+ID4gPj4gKyAgICAgICAgKiBhZGRyZXNzIHNwYWNlLgo+ID4g PiA+PiArICAgICAgICAqLwo+ID4gPiA+PiArICAgICAgIGNmZyA9IEdQVV9QRVJGQ05UX0NGR19B UygwKTsKPiA+ID4gPj4gKyAgICAgICBpZiAocGFuZnJvc3RfbW9kZWxfY21wKHBmZGV2LCAweDEw MDApID49IDApICAgICAgCj4gPiA+ID4gCj4gPiA+ID4gWW91J3ZlIGdvdCBhIGNvdXBsZSBvZiB0 aGVzZS4gUGVyaGFwcyB3ZSBzaG91bGQgYWRkIGVpdGhlciBhCj4gPiA+ID4gbW9kZWxfaXNfYmlm cm9zdCgpIGhlbHBlciBvciBhbiBpc19iaWZyb3N0IHZhcmlhYmxlIHRvIHVzZS4KPiA+ID4gPiAg ICAgICAKPiA+ID4gPj4gKyAgICAgICAgICAgICAgIGNmZyB8PSBHUFVfUEVSRkNOVF9DRkdfU0VU U0VMKDEpOyAgICAgIAo+ID4gPiAKPiA+ID4gbWFsaV9rYmFzZSBvbmx5IHNldHMgdGhpcyBpZiBD T05GSUdfTUFMSV9QUkZDTlRfU0VUX1NFQ09OREFSWSBpcyBkZWZpbmVkCj4gPiA+IC0gaS5lLiB0 aGlzIHNlbGVjdHMgYSBkaWZmZXJlbnQgc2VsZWN0aW9uIG9mIGNvdW50ZXJzLiBBdCBhdCB0aGUg dmVyeQo+ID4gPiBsZWFzdCB0aGlzIHNob3VsZCBiZSBhbiBvcHRpb25hbCBmbGFnIHRoYXQgY2Fu IGJlIHNldCwgYnV0IEkgc3VzcGVjdCB0aGUKPiA+ID4gcHJpbWFyeSBzZXQgYXJlIHRoZSBvbmVz IHlvdSBhcmUgaW50ZXJlc3RlZCBpbi4gICAgCj4gPiAKPiA+IEknbGwgYWRkIGEgcGFyYW0gdG8g cGFzcyB0aGUgc2V0IG9mIGNvdW50ZXJzIHRvIG1vbml0b3IuCj4gPiAgIAo+ID4gPiAgICAgCj4g PiA+ID4+ICsKPiA+ID4gPj4gKyAgICAgICBncHVfd3JpdGUocGZkZXYsIEdQVV9QRVJGQ05UX0NG RywKPiA+ID4gPj4gKyAgICAgICAgICAgICAgICAgY2ZnIHwgR1BVX1BFUkZDTlRfQ0ZHX01PREUo R1BVX1BFUkZDTlRfQ0ZHX01PREVfT0ZGKSk7Cj4gPiA+ID4+ICsKPiA+ID4gPj4gKyAgICAgICBp ZiAoIXBmZGV2LT5wZXJmY250LT5lbmFibGVkKQo+ID4gPiA+PiArICAgICAgICAgICAgICAgcmV0 dXJuOwo+ID4gPiA+PiArCj4gPiA+ID4+ICsgICAgICAgZ3B1X3dyaXRlKHBmZGV2LCBHUFVfUFJG Q05UX0pNX0VOLCAweGZmZmZmZmZmKTsKPiA+ID4gPj4gKyAgICAgICBncHVfd3JpdGUocGZkZXYs IEdQVV9QUkZDTlRfU0hBREVSX0VOLCAweGZmZmZmZmZmKTsKPiA+ID4gPj4gKyAgICAgICBncHVf d3JpdGUocGZkZXYsIEdQVV9QUkZDTlRfTU1VX0wyX0VOLCAweGZmZmZmZmZmKTsKPiA+ID4gPj4g Kwo+ID4gPiA+PiArICAgICAgIC8qCj4gPiA+ID4+ICsgICAgICAgICogRHVlIHRvIFBSTEFNLTgx ODYgd2UgbmVlZCB0byBkaXNhYmxlIHRoZSBUaWxlciBiZWZvcmUgd2UgZW5hYmxlIEhXCj4gPiA+ ID4+ICsgICAgICAgICogY291bnRlcnMuICAgICAgCj4gPiA+ID4gCj4gPiA+ID4gU2VlbXMgbGlr ZSB5b3UgY291bGQganVzdCBhbHdheXMgYXBwbHkgdGhlIHdvcmstYXJvdW5kPyBJdCBkb2Vzbid0 Cj4gPiA+ID4gbG9vayBsaWtlIGl0IHdvdWxkIGJlIG11Y2ggZGlmZmVyZW50LiAgICAgIAo+ID4g PiAKPiA+ID4gVGVjaG5pY2FsbHkgdGhlIHdvcmthcm91bmQgY2F1c2VzIHRoZSBkcml2ZXIgdG8g cGVyZm9ybSB0aGUgb3BlcmF0aW9uIGluCj4gPiA+IHRoZSB3cm9uZyBvcmRlciBiZWxvdyAod3Jp dGUgVElMRVJfRU4gd2hlbiB0aGUgbW9kZSBpcyBNQU5VQUwpIC0gdGhpcyBpcwo+ID4gPiBhIHdv cmthcm91bmQgZm9yIHRoZSBoYXJkd2FyZSBpc3N1ZSAoYW5kIHRoZXJlZm9yZSB3b3JrcyBvbiB0 aGF0Cj4gPiA+IGhhcmR3YXJlKS4gQnV0IEkgd291bGRuJ3QgbGlrZSB0byBzYXkgaXQgd29ya3Mg b24gb3RoZXIgaGFyZHdhcmUgd2hpY2gKPiA+ID4gZG9lc24ndCBoYXZlIHRoZSBpc3N1ZS4gICAg Cj4gPiAKPiA+IE9rYXksIEknbGwga2VlcCB0aGUgd29ya2Fyb3VuZCBvbmx5IGZvciBIVyB0aGF0 IGFyZSBpbXBhY3RlZCBieSB0aGUgYnVnLgo+ID4gICAKPiA+ID4gICAgIAo+ID4gPiA+PiArICAg ICAgICAqLwo+ID4gPiA+PiArICAgICAgIGlmIChwYW5mcm9zdF9oYXNfaHdfaXNzdWUocGZkZXYs IEhXX0lTU1VFXzgxODYpKQo+ID4gPiA+PiArICAgICAgICAgICAgICAgZ3B1X3dyaXRlKHBmZGV2 LCBHUFVfUFJGQ05UX1RJTEVSX0VOLCAwKTsKPiA+ID4gPj4gKyAgICAgICBlbHNlCj4gPiA+ID4+ ICsgICAgICAgICAgICAgICBncHVfd3JpdGUocGZkZXYsIEdQVV9QUkZDTlRfVElMRVJfRU4sIDB4 ZmZmZmZmZmYpOwo+ID4gPiA+PiArCj4gPiA+ID4+ICsgICAgICAgZ3B1X3dyaXRlKHBmZGV2LCBH UFVfUEVSRkNOVF9DRkcsCj4gPiA+ID4+ICsgICAgICAgICAgICAgICAgIGNmZyB8IEdQVV9QRVJG Q05UX0NGR19NT0RFKEdQVV9QRVJGQ05UX0NGR19NT0RFX01BTlVBTCkpOwo+ID4gPiA+PiArCj4g PiA+ID4+ICsgICAgICAgaWYgKHBhbmZyb3N0X2hhc19od19pc3N1ZShwZmRldiwgSFdfSVNTVUVf ODE4NikpCj4gPiA+ID4+ICsgICAgICAgICAgICAgICBncHVfd3JpdGUocGZkZXYsIEdQVV9QUkZD TlRfVElMRVJfRU4sIDB4ZmZmZmZmZmYpOwo+ID4gPiA+PiArfSAgICAKPiA+IAo+ID4gWy4uLl0K PiA+ICAgCj4gPiA+ID4+ICtpbnQgcGFuZnJvc3RfcGVyZmNudF9pbml0KHN0cnVjdCBwYW5mcm9z dF9kZXZpY2UgKnBmZGV2KQo+ID4gPiA+PiArewo+ID4gPiA+PiArICAgICAgIHN0cnVjdCBwYW5m cm9zdF9wZXJmY250ICpwZXJmY250Owo+ID4gPiA+PiArICAgICAgIHN0cnVjdCBkcm1fZ2VtX3No bWVtX29iamVjdCAqYm87Cj4gPiA+ID4+ICsgICAgICAgc2l6ZV90IHNpemU7Cj4gPiA+ID4+ICsg ICAgICAgdTMyIHN0YXR1czsKPiA+ID4gPj4gKyAgICAgICBpbnQgcmV0Owo+ID4gPiA+PiArCj4g PiA+ID4+ICsgICAgICAgaWYgKHBhbmZyb3N0X2hhc19od19mZWF0dXJlKHBmZGV2LCBIV19GRUFU VVJFX1Y0KSkgewo+ID4gPiA+PiArICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG5jb3JlZ3Jv dXBzOwo+ID4gPiA+PiArCj4gPiA+ID4+ICsgICAgICAgICAgICAgICBuY29yZWdyb3VwcyA9IGh3 ZWlnaHQ2NChwZmRldi0+ZmVhdHVyZXMubDJfcHJlc2VudCk7Cj4gPiA+ID4+ICsgICAgICAgICAg ICAgICBzaXplID0gbmNvcmVncm91cHMgKiBCTE9DS1NfUEVSX0NPUkVHUk9VUCAqCj4gPiA+ID4+ ICsgICAgICAgICAgICAgICAgICAgICAgQ09VTlRFUlNfUEVSX0JMT0NLICogQllURVNfUEVSX0NP VU5URVI7Cj4gPiA+ID4+ICsgICAgICAgfSBlbHNlIHsKPiA+ID4gPj4gKyAgICAgICAgICAgICAg IHVuc2lnbmVkIGludCBubDJjLCBuY29yZXM7Cj4gPiA+ID4+ICsKPiA+ID4gPj4gKyAgICAgICAg ICAgICAgIC8qCj4gPiA+ID4+ICsgICAgICAgICAgICAgICAgKiBUT0RPOiBkZWZpbmUgYSBtYWNy byB0byBleHRyYWN0IHRoZSBudW1iZXIgb2YgbDIgY2FjaGVzIGZyb20KPiA+ID4gPj4gKyAgICAg ICAgICAgICAgICAqIG1lbV9mZWF0dXJlcy4KPiA+ID4gPj4gKyAgICAgICAgICAgICAgICAqLwo+ ID4gPiA+PiArICAgICAgICAgICAgICAgbmwyYyA9ICgocGZkZXYtPmZlYXR1cmVzLm1lbV9mZWF0 dXJlcyA+PiA4KSAmIEdFTk1BU0soMywgMCkpICsgMTsKPiA+ID4gPj4gKwo+ID4gPiA+PiArICAg ICAgICAgICAgICAgLyoKPiA+ID4gPj4gKyAgICAgICAgICAgICAgICAqIFRoZSBBUk0gZHJpdmVy IGlzIGdyb3VwaW5nIGNvcmVzIHBlciBjb3JlIGdyb3VwIGFuZCB0aGVuCj4gPiA+ID4+ICsgICAg ICAgICAgICAgICAgKiBvbmx5IHVzaW5nIHRoZSBudW1iZXIgb2YgY29yZXMgaW4gZ3JvdXAgMCB0 byBjYWxjdWxhdGUgdGhlCj4gPiA+ID4+ICsgICAgICAgICAgICAgICAgKiBzaXplLiBOb3Qgc3Vy ZSB3aHkgdGhpcyBpcyBkb25lIGxpa2UgdGhhdCwgYnV0IEkgZ3Vlc3MKPiA+ID4gPj4gKyAgICAg ICAgICAgICAgICAqIHNoYWRlcl9wcmVzZW50IHdpbGwgb25seSBzaG93IGNvcmVzIGluIHRoZSBm aXJzdCBncm91cAo+ID4gPiA+PiArICAgICAgICAgICAgICAgICogYW55d2F5Lgo+ID4gPiA+PiAr ICAgICAgICAgICAgICAgICovICAgICAgCj4gPiA+IAo+ID4gPiBJJ20gbm90IHN1cmUgSSB1bmRl cnN0YW5kIHRoaXMgY29tbWVudC4gSSdtIG5vdCBzdXJlIHdoaWNoIHZlcnNpb24gb2YKPiA+ID4g dGhlIGRyaXZlciB5b3UgYXJlIGxvb2tpbmcgYXQsIGJ1dCBzaGFkZXJfcHJlc2VudCBzaG91bGQg Y29udGFpbiBhbGwgdGhlCj4gPiA+IGNvcmVzIChpbiBldmVyeSBjb3JlIGdyb3VwKS4KPiA+ID4g Cj4gPiA+IFRoZSBrYmFzZSBkcml2ZXIgKGluIHBhbmZyb3N0J3MgZ2l0IHRyZWVbMV0pLCBjb250 YWluczoKPiA+ID4gCj4gPiA+IAliYXNlX2dwdV9wcm9wcyAqcHJvcHMgPSAma2JkZXYtPmdwdV9w cm9wcy5wcm9wczsKPiA+ID4gCXUzMiBucl9sMiA9IHByb3BzLT5sMl9wcm9wcy5udW1fbDJfc2xp Y2VzOwo+ID4gPiAJdTY0IGNvcmVfbWFzayA9IHByb3BzLT5jb2hlcmVuY3lfaW5mby5ncm91cFsw XS5jb3JlX21hc2s7Cj4gPiA+IAo+ID4gPiAJdTMyIG5yX2Jsb2NrcyA9IGZsczY0KGNvcmVfbWFz ayk7Cj4gPiA+IAo+ID4gPiAJLyogSk0gYW5kIHRpbGVyIGNvdW50ZXIgYmxvY2tzIGFyZSBhbHdh eXMgcHJlc2VudCAqLwo+ID4gPiAJZHVtcF9zaXplID0gKDIgKyBucl9sMiArIG5yX2Jsb2Nrcykg Kgo+ID4gPiAJCQlOUl9DTlRfUEVSX0JMT0NLICoKPiA+ID4gCQkJTlJfQllURVNfUEVSX0NOVDsK PiA+ID4gCj4gPiA+IFsxXQo+ID4gPiBodHRwczovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcvcGFu ZnJvc3QvbWFsaV9rYmFzZS9ibG9iL21hc3Rlci9kcml2ZXIvcHJvZHVjdC9rZXJuZWwvZHJpdmVy cy9ncHUvYXJtL21pZGdhcmQvbWFsaV9rYmFzZV92aW5zdHIuYwo+ID4gPiAKPiA+ID4gaS5lLiB0 aGUgbnVtYmVyIG9mIGNvcmVzICsgbnVtYmVyIG9mIEwyIGNhY2hlcyAocGx1cyAyIGZvciBKTS90 aWxlcikKPiA+ID4gbXVsdGlwbGllZCBieSB0aGUgYmxvY2sgc2l6ZS4gICAgCj4gPiAKPiA+IEFj dHVhbGx5LCBJIHdhcyByZWZlcnJpbmcgdG8gd2hhdCdzIGRvbmUgaW4KPiA+IGtiYXNlX2dwdXBy b3BzX2NvbnN0cnVjdF9jb2hlcmVudF9ncm91cHMoKSBbMl0uCj4gPiAgIAo+ID4gPiAKPiA+ID4g QWxzbyBhbm90aGVyIGRpZmZlcmVuY2Ugd2l0aCB0aGUgYmVsb3cgaXMgdGhhdCBmbHM2NCBhbmQg aHdlaWdodDY0IGRvbid0Cj4gPiA+IHJldHVybiB0aGUgc2FtZSBudW1iZXJzLiBJZiB0aGUgY29y ZSBtYXNrIGlzIG5vbi1jb250aWd1b3VzIHRoaXMgd2lsbAo+ID4gPiByZXR1cm4gZGlmZmVyZW50 IHZhbHVlcy4gICAgCj4gPiAKPiA+IFJpZ2h0LCBJIHNob3VsZCB1c2UgZmxzNjQoKSBub3QgaHdl aWdodDY0KCkuICAKPiAKPiBPb3BzLCBmb3Jnb3QgdG8gYXNrIHRoZSBleHRyYSBxdWVzdGlvbiBJ IGhhZC4gTG9va3MgbGlrZSB3aGVuIHRoZSBHUFUKPiBpcyBidXN5IGFuZCBJIGVuYWJsZS9kdW1w L2Rpc2FibGUgcGVyZmNudCB0b28gcXVpY2tseSwgSSBzb21ldGltZSBnZXRzCj4ge0pNLFNIQURF UixNTVVfTDIsVElMRVJ9X0NPVU5URVJbMl0gPSAwIHdoaWxlIEknZCBleHBlY3QgaXQgdG8gYmUg c2V0Cj4gdG8gdGhlIHtKTSxTSEFERVIsTU1VX0wyLFRJTEVSfV9FTiB2YWx1ZSAoMHhmZiBvciAw eGZmZmYgZGVwZW5kaW5nIG9uCj4gdGhlIGJsb2NrKS4gSSBtYWRlIHN1cmUgSSB3YXMgcmVjZWl2 aW5nIHRoZSBTQU1QTEVfRE9ORStDTEVBTl9ET05FCj4gZXZlbnRzLiBBbnkgaWRlYSB3aGF0IGNv dWxkIGNhdXNlIHRoaXM/Cj4gCj4gTm90ZSB0aGF0IHdoZW4gdGhlIEdQVSBpcyBpZGxlLCB7Sk0s U0hBREVSLE1NVV9MMixUSUxFUn1fQ09VTlRFUlsyXSBhcmUKPiBzZXQgdG8gdGhlIHZhbHVlIEkg ZXhwZWN0ICgweGZmIG9yIDB4ZmZmZiBkZXBlbmRpbmcgb24gdGhlIGJsb2NrKS4KCkkgdGhpbmsg SSBmb3VuZCB0aGUgaXNzdWUuIExvb2tzIGxpa2UgZHJtX2dlbV9zaG1lbV92bWFwKCkgaXMgbWFw cGluZwp0aGUgQk8gaW4gY2FjaGVkIG1vZGUgYW5kIHRoZXJlJ3Mgbm8gaGVscGVyIHRvIGRvIGNh Y2hlIG1haW50ZW5hbmNlCm9wZXJhdGlvbiBvbiB0aGlzIEJPIChkbWFfbWFwL3VubWFwX3NnKCkp LiBNYXBwaW5nIGl0IHdyaXRlY29tYmluZQpzZWVtcyB0byBkbyB0aGUgdHJpY2sgKGF0IGxlYXN0 IEkgbm8gbG9uZ2VyIGhhdmUgdGhvc2UgaW5jb25zaXN0ZW5jaWVzCm9uIHtKTSxTSEFERVIsTU1V X0wyLFRJTEVSfV9DT1VOVEVSWzJdKS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbA==