From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 29 May 2019 09:23:07 +0200 Subject: [Buildroot] [PATCH V3 03/10] arch/csky: Add FLOAT_ABI compiler options In-Reply-To: <1559114328-23357-4-git-send-email-guoren@kernel.org> References: <1559114328-23357-1-git-send-email-guoren@kernel.org> <1559114328-23357-4-git-send-email-guoren@kernel.org> Message-ID: <20190529092307.6c78996b@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Wed, 29 May 2019 15:18:41 +0800 guoren at kernel.org wrote: > From: Guo Ren > > This is only for abiv2 and abiv1 don't support FPU. > > Signed-off-by: Guo Ren What is abiv1 vs. abiv2 ? Also, in your next commit, abiv1 is apparently used for ck610, but here this BR2_GCC_TARGET_FLOAT_ABI is defined for all cases, which seems to contradict your commit log. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC1F9C04AB3 for ; Wed, 29 May 2019 07:23:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB7BC21019 for ; Wed, 29 May 2019 07:23:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726102AbfE2HXM (ORCPT ); Wed, 29 May 2019 03:23:12 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:60437 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726005AbfE2HXM (ORCPT ); Wed, 29 May 2019 03:23:12 -0400 X-Originating-IP: 90.88.147.134 Received: from windsurf.home (aaubervilliers-681-1-27-134.w90-88.abo.wanadoo.fr [90.88.147.134]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 5D59AE000D; Wed, 29 May 2019 07:23:08 +0000 (UTC) Date: Wed, 29 May 2019 09:23:07 +0200 From: Thomas Petazzoni To: guoren@kernel.org Cc: Thomas De Schampheleire , arnout@mind.be, linux-csky@vger.kernel.org, buildroot@buildroot.org, Guo Ren Subject: Re: [PATCH V3 03/10] arch/csky: Add FLOAT_ABI compiler options Message-ID: <20190529092307.6c78996b@windsurf.home> In-Reply-To: <1559114328-23357-4-git-send-email-guoren@kernel.org> References: <1559114328-23357-1-git-send-email-guoren@kernel.org> <1559114328-23357-4-git-send-email-guoren@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-csky-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org Hello, On Wed, 29 May 2019 15:18:41 +0800 guoren@kernel.org wrote: > From: Guo Ren > > This is only for abiv2 and abiv1 don't support FPU. > > Signed-off-by: Guo Ren What is abiv1 vs. abiv2 ? Also, in your next commit, abiv1 is apparently used for ck610, but here this BR2_GCC_TARGET_FLOAT_ABI is defined for all cases, which seems to contradict your commit log. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com