From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Wed, 29 May 2019 11:34:58 +0000 Subject: [PATCH] drm/mcde: Fix an uninitialized variable Message-Id: <20190529113458.GG19119@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Walleij Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org We never set "vblank" to "false". Current versions of GCC will initialize it to zero automatically at certain optimization levels so that's probably why this didn't show up in testing. Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/mcde/mcde_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mcde/mcde_display.c b/drivers/gpu/drm/mcde/mcde_display.c index f3ef108a41d9..751454ae3cd1 100644 --- a/drivers/gpu/drm/mcde/mcde_display.c +++ b/drivers/gpu/drm/mcde/mcde_display.c @@ -65,7 +65,7 @@ enum mcde_dsi_formatter { void mcde_display_irq(struct mcde *mcde) { u32 mispp, misovl, mischnl; - bool vblank; + bool vblank = false; /* Handle display IRQs */ mispp = readl(mcde->regs + MCDE_MISPP); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH] drm/mcde: Fix an uninitialized variable Date: Wed, 29 May 2019 14:34:58 +0300 Message-ID: <20190529113458.GG19119@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from aserp2130.oracle.com (aserp2130.oracle.com [141.146.126.79]) by gabe.freedesktop.org (Postfix) with ESMTPS id 57DD56E2DF for ; Wed, 29 May 2019 11:35:14 +0000 (UTC) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij Cc: David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org V2UgbmV2ZXIgc2V0ICJ2YmxhbmsiIHRvICJmYWxzZSIuCgpDdXJyZW50IHZlcnNpb25zIG9mIEdD QyB3aWxsIGluaXRpYWxpemUgaXQgdG8gemVybyBhdXRvbWF0aWNhbGx5IGF0CmNlcnRhaW4gb3B0 aW1pemF0aW9uIGxldmVscyBzbyB0aGF0J3MgcHJvYmFibHkgd2h5IHRoaXMgZGlkbid0IHNob3cg dXAKaW4gdGVzdGluZy4KCkZpeGVzOiA1ZmM1MzdiZmQwMDAgKCJkcm0vbWNkZTogQWRkIG5ldyBk cml2ZXIgZm9yIFNULUVyaWNzc29uIE1DREUiKQpTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVy IDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL21jZGUvbWNk ZV9kaXNwbGF5LmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVs ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWNkZS9tY2RlX2Rpc3BsYXku YyBiL2RyaXZlcnMvZ3B1L2RybS9tY2RlL21jZGVfZGlzcGxheS5jCmluZGV4IGYzZWYxMDhhNDFk OS4uNzUxNDU0YWUzY2QxIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vbWNkZS9tY2RlX2Rp c3BsYXkuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vbWNkZS9tY2RlX2Rpc3BsYXkuYwpAQCAtNjUs NyArNjUsNyBAQCBlbnVtIG1jZGVfZHNpX2Zvcm1hdHRlciB7CiB2b2lkIG1jZGVfZGlzcGxheV9p cnEoc3RydWN0IG1jZGUgKm1jZGUpCiB7CiAJdTMyIG1pc3BwLCBtaXNvdmwsIG1pc2Nobmw7Ci0J Ym9vbCB2Ymxhbms7CisJYm9vbCB2YmxhbmsgPSBmYWxzZTsKIAogCS8qIEhhbmRsZSBkaXNwbGF5 IElSUXMgKi8KIAltaXNwcCA9IHJlYWRsKG1jZGUtPnJlZ3MgKyBNQ0RFX01JU1BQKTsKLS0gCjIu MjAuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs