From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDF43C28CC2 for ; Wed, 29 May 2019 20:16:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4C9124140 for ; Wed, 29 May 2019 20:16:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bwKrSUcA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbfE2UQN (ORCPT ); Wed, 29 May 2019 16:16:13 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:46640 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbfE2UQM (ORCPT ); Wed, 29 May 2019 16:16:12 -0400 Received: by mail-pg1-f194.google.com with SMTP id v9so516941pgr.13 for ; Wed, 29 May 2019 13:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=byH71jcEnWiZocWjFrPDlTMOE7pd8EPRHoYGyukaY04=; b=bwKrSUcAFY5li8JHROxevBRkVdZvfftmbN2jvX4D8l/n4Q/b0ePv+zprqpG2KluSLn rSYJBFUhtygfnfgM4xMNPYR/Vp/NGpVKFovwEIHmtk8emThGP6iRNZH+rg7exn2dW3QV qTeu7YoFimL+W4CSITeRLNxas0G8YpYTWwbHw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=byH71jcEnWiZocWjFrPDlTMOE7pd8EPRHoYGyukaY04=; b=MY6f7BgxEmXgNXJ50txHjQJ/jrdAfzf1dXvGBX7DzKPvYj0vjnIZGq0v4umacgzjx/ vY7ENMu1aGX3QnVUwAOJ7E5InffXAk/aYbeCwZNH6PE+j3TW9VYlYNuSYNQq8SuDiDq4 UdT22j7SXrhjeFfovRqLHuA/qDZTQu43i2g9kN3Rple+n7Yf8aJ7LVouerNhYqqmhRi9 EDkt2K8TPsV6ZzDrrp/BJt3g69u5Jgaz2nryA1iBVR/AyhedikyIvEDVIl186ud/t6EU 4FIqGVNLasOuu71y/+5tDln9F0n0IRtL1Q68lhiXxXm1a/LxpzCn3pkXRObfmqCWmJNY c+eA== X-Gm-Message-State: APjAAAWp6lFVOcGr3rj2MOR+mncWSQSIRiWxLYEVk807aeEYuEehdg7a SM5aZgUPlyMqBdEdBeoCV9VsIw== X-Google-Smtp-Source: APXvYqwOtLbXvQF12v2iQzcTzlTPHXYwr/VbPiH/+9zX0lzSfnaAmA5ZoEnSGfNESsFHQ7AnnjhQoA== X-Received: by 2002:a63:f44b:: with SMTP id p11mr139393871pgk.225.1559160971649; Wed, 29 May 2019 13:16:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u6sm227693pgm.22.2019.05.29.13.16.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 13:16:10 -0700 (PDT) Date: Wed, 29 May 2019 13:16:09 -0700 From: Kees Cook To: Alexandre Ghiti Cc: Andrew Morton , Christoph Hellwig , Russell King , Catalin Marinas , Will Deacon , Ralf Baechle , Paul Burton , James Hogan , Palmer Dabbelt , Albert Ou , Alexander Viro , Luis Chamberlain , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 00/14] Provide generic top-down mmap layout functions Message-ID: <201905291313.1E6BD2DFB@keescook> References: <20190526134746.9315-1-alex@ghiti.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190526134746.9315-1-alex@ghiti.fr> Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sun, May 26, 2019 at 09:47:32AM -0400, Alexandre Ghiti wrote: > This series introduces generic functions to make top-down mmap layout > easily accessible to architectures, in particular riscv which was > the initial goal of this series. > The generic implementation was taken from arm64 and used successively > by arm, mips and finally riscv. As I've mentioned before, I think this is really great. Making this common has long been on my TODO list. Thank you for the work! (I've sent separate review emails for individual patches where my ack wasn't already present...) > - There is no common API to determine if a process is 32b, so I came up with > !IS_ENABLED(CONFIG_64BIT) || is_compat_task() in [PATCH v4 12/14]. Do we need a common helper for this idiom? (Note that I don't think it's worth blocking the series for this.) -Kees -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2BC4C28CC0 for ; Wed, 29 May 2019 20:16:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C8FA924137 for ; Wed, 29 May 2019 20:16:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CwvxYnoz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bwKrSUcA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C8FA924137 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0w6CD2gfWQ1UELVLG0/RICT6LlUFN1Zo+xXtdzkSudI=; b=CwvxYnozOzk77A zhc4zBulyBCJpEHkJkirHXEkJ1jNk3gEwSjFWq8Frmb0B3ZGBceScuFpjyPyNehn6pGWv3fwyxxJX 8pqM61iavWu6ahSkSZh7hAQ5jcu9j/8l5wXikJMuRmAOLo/6dYRSbX0wKGNe6FAKWnl/i8MzpXy2K IrAnCTjzqZksq/Tf8D468/q76qN1JqEKCustl8/BxOe4GTjdxtCzfEdivnRR2wY73WaLGn+yKJwny DTWLYpfIOTVvCRtDOryDvCxjkxlfYsfCvolIM1upPEpls+zycvmWQQpZt52wzj180H/wb8Gr12K6Z 454n62go5WEgA5q+wc5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hW4zk-0001uy-6C; Wed, 29 May 2019 20:16:20 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hW4zc-0001nG-HY for linux-riscv@lists.infradead.org; Wed, 29 May 2019 20:16:13 +0000 Received: by mail-pg1-x542.google.com with SMTP id 20so544661pgr.4 for ; Wed, 29 May 2019 13:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=byH71jcEnWiZocWjFrPDlTMOE7pd8EPRHoYGyukaY04=; b=bwKrSUcAFY5li8JHROxevBRkVdZvfftmbN2jvX4D8l/n4Q/b0ePv+zprqpG2KluSLn rSYJBFUhtygfnfgM4xMNPYR/Vp/NGpVKFovwEIHmtk8emThGP6iRNZH+rg7exn2dW3QV qTeu7YoFimL+W4CSITeRLNxas0G8YpYTWwbHw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=byH71jcEnWiZocWjFrPDlTMOE7pd8EPRHoYGyukaY04=; b=VWH3UaRkANG9W/lOrQ8J8o0eWbPXrDzOwaOTAQ+uZUqM0JT9+asgrq4MXVcW+2GxAC u5RJpt4NwijrOFMydkOzgySe77aSVES1+7a7THYIqYbTdwUgEkoNy1TVoFeBdnbbuhNw H47nRguZ/qhIlxpCovGtbQcaxV8ofLfEpI3PMJYIWcEhdN0mrDhYK0siXJD1/80a7ADo FzWLaFhTSdiSBsj0WUG9CIzffvYjaDPhPwU1lUsCKbLaGTWQCzgaoCa4G+m89g4uYRK0 clsLxkTS8BVH1Q34U3sbtIERDq71mHgKk0qrAt/O1gphlIud2wwug7tOyB6kw3XYCjmW vCfA== X-Gm-Message-State: APjAAAX+oRSnHC6Yu2kInTy2U8a98aJutXUjGFnIZpSVrlM4FYpWK+BU zshZiMkRmaeMtmSvJgURCnuBIQ== X-Google-Smtp-Source: APXvYqwOtLbXvQF12v2iQzcTzlTPHXYwr/VbPiH/+9zX0lzSfnaAmA5ZoEnSGfNESsFHQ7AnnjhQoA== X-Received: by 2002:a63:f44b:: with SMTP id p11mr139393871pgk.225.1559160971649; Wed, 29 May 2019 13:16:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u6sm227693pgm.22.2019.05.29.13.16.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 13:16:10 -0700 (PDT) Date: Wed, 29 May 2019 13:16:09 -0700 From: Kees Cook To: Alexandre Ghiti Subject: Re: [PATCH v4 00/14] Provide generic top-down mmap layout functions Message-ID: <201905291313.1E6BD2DFB@keescook> References: <20190526134746.9315-1-alex@ghiti.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190526134746.9315-1-alex@ghiti.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_131612_613588_AD586749 X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Albert Ou , Catalin Marinas , Palmer Dabbelt , Will Deacon , Russell King , Ralf Baechle , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Paul Burton , linux-riscv@lists.infradead.org, Alexander Viro , James Hogan , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-mips@vger.kernel.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org, Luis Chamberlain Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Sun, May 26, 2019 at 09:47:32AM -0400, Alexandre Ghiti wrote: > This series introduces generic functions to make top-down mmap layout > easily accessible to architectures, in particular riscv which was > the initial goal of this series. > The generic implementation was taken from arm64 and used successively > by arm, mips and finally riscv. As I've mentioned before, I think this is really great. Making this common has long been on my TODO list. Thank you for the work! (I've sent separate review emails for individual patches where my ack wasn't already present...) > - There is no common API to determine if a process is 32b, so I came up with > !IS_ENABLED(CONFIG_64BIT) || is_compat_task() in [PATCH v4 12/14]. Do we need a common helper for this idiom? (Note that I don't think it's worth blocking the series for this.) -Kees -- Kees Cook _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A0EC28CC0 for ; Wed, 29 May 2019 20:16:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E40024137 for ; Wed, 29 May 2019 20:16:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Fg2hNZZu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bwKrSUcA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E40024137 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j11iK3MzaZfe/5uyboOExv418cgIIRZkDxjLYc2wVSI=; b=Fg2hNZZuDN49Is Xk4rcUp1gDyD2I9rmE4L8aU9BYrzQ1rezIGPj8GqAUJCEasxI3Vepq7sAcXxoA3587oI5IWe0Ve1T tBGb5bSEN4FpkpFc16LCphRV01z9rZD9Uxwmm6R0nJe1vGlgO0H5rEZtnVXJP1ovLCvSuGBLusWSl 12my3TkoiK7JtuPsRWkBstkCQxHw4wGie5DeFXbCAmL+3FRDcQIOeJ25jFWnwNXACiWlTVQipW+8A j2JIg64oTBPfuUcocdsjLzeNLgUmXZTjbxIJMVP1337lynAOZtYAR2a42FOV2cbrmV4ErDVuqIqHJ xcktCYT+NNJjMSoJfrCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hW4zf-0001oP-En; Wed, 29 May 2019 20:16:15 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hW4zc-0001nF-HX for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2019 20:16:13 +0000 Received: by mail-pf1-x441.google.com with SMTP id c6so2336780pfa.10 for ; Wed, 29 May 2019 13:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=byH71jcEnWiZocWjFrPDlTMOE7pd8EPRHoYGyukaY04=; b=bwKrSUcAFY5li8JHROxevBRkVdZvfftmbN2jvX4D8l/n4Q/b0ePv+zprqpG2KluSLn rSYJBFUhtygfnfgM4xMNPYR/Vp/NGpVKFovwEIHmtk8emThGP6iRNZH+rg7exn2dW3QV qTeu7YoFimL+W4CSITeRLNxas0G8YpYTWwbHw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=byH71jcEnWiZocWjFrPDlTMOE7pd8EPRHoYGyukaY04=; b=Icd7rYOl6EqSoB380zfUaIuXEkl3KbsujxVgpHyuOivhSKWYnIcS4Gcqq0rZCd20IN zwxIWquA07c3XXfzjscZRrANJULYS+LH3wZIv9H9pxcRjeDc8/L5skDlmEeL5AaROZy6 /OL1Qx/T0KfGDpHu/g2gbyAYI5UNXgAxSEo8N50SBIQMZlOOJOQ86y166eHwV91oZXSd 94fVR6r8wPyHL3BlqCMSyWDXCS3AatKwV/yYT6t3oUJRf2vGYxfSdHTxuO2PxJH36Emk XzUYnt05YJlIfnBfi/RfY+CTL8iAAcY2QSDWCpZP/5tijDa2kRrydohV1e7/J3lG6NmP zliQ== X-Gm-Message-State: APjAAAVsLkkMUsZUqhJ70j+67PfGRnJvZ1P8YgIRMNjlcOYZIdsqPG9V JI7WrwLrgg/TRKy6CEkU/uzP5w== X-Google-Smtp-Source: APXvYqwOtLbXvQF12v2iQzcTzlTPHXYwr/VbPiH/+9zX0lzSfnaAmA5ZoEnSGfNESsFHQ7AnnjhQoA== X-Received: by 2002:a63:f44b:: with SMTP id p11mr139393871pgk.225.1559160971649; Wed, 29 May 2019 13:16:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u6sm227693pgm.22.2019.05.29.13.16.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 May 2019 13:16:10 -0700 (PDT) Date: Wed, 29 May 2019 13:16:09 -0700 From: Kees Cook To: Alexandre Ghiti Subject: Re: [PATCH v4 00/14] Provide generic top-down mmap layout functions Message-ID: <201905291313.1E6BD2DFB@keescook> References: <20190526134746.9315-1-alex@ghiti.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190526134746.9315-1-alex@ghiti.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_131612_614914_FD38C799 X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Albert Ou , Catalin Marinas , Palmer Dabbelt , Will Deacon , Russell King , Ralf Baechle , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Paul Burton , linux-riscv@lists.infradead.org, Alexander Viro , James Hogan , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-mips@vger.kernel.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org, Luis Chamberlain Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 26, 2019 at 09:47:32AM -0400, Alexandre Ghiti wrote: > This series introduces generic functions to make top-down mmap layout > easily accessible to architectures, in particular riscv which was > the initial goal of this series. > The generic implementation was taken from arm64 and used successively > by arm, mips and finally riscv. As I've mentioned before, I think this is really great. Making this common has long been on my TODO list. Thank you for the work! (I've sent separate review emails for individual patches where my ack wasn't already present...) > - There is no common API to determine if a process is 32b, so I came up with > !IS_ENABLED(CONFIG_64BIT) || is_compat_task() in [PATCH v4 12/14]. Do we need a common helper for this idiom? (Note that I don't think it's worth blocking the series for this.) -Kees -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel