All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Ser <simon.ser@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: martin.peres@intel.com
Subject: [igt-dev] [PATCH i-g-t 2/5] lib/tests/igt_audio: add test with missing frequency
Date: Wed, 29 May 2019 16:32:47 +0300	[thread overview]
Message-ID: <20190529133250.27817-3-simon.ser@intel.com> (raw)
In-Reply-To: <20190529133250.27817-1-simon.ser@intel.com>

Make sure detection fails.

Signed-off-by: Simon Ser <simon.ser@intel.com>
---
 lib/tests/igt_audio.c | 39 +++++++++++++++++++++++++++++++++------
 1 file changed, 33 insertions(+), 6 deletions(-)

diff --git a/lib/tests/igt_audio.c b/lib/tests/igt_audio.c
index 0ca3a4342ad9..7b068c255973 100644
--- a/lib/tests/igt_audio.c
+++ b/lib/tests/igt_audio.c
@@ -32,6 +32,10 @@
 #define CHANNELS 1
 #define BUFFER_LEN 2048
 
+static const int test_freqs[] = { 300, 700, 5000 };
+
+static const size_t test_freqs_len = sizeof(test_freqs) / sizeof(test_freqs[0]);
+
 static void test_signal_detect_verbatim(struct audio_signal *signal)
 {
 	double buf[BUFFER_LEN];
@@ -66,21 +70,41 @@ static void test_signal_detect_noise(struct audio_signal *signal)
 	igt_assert(!ok);
 }
 
+static void test_signal_detect_missing(struct audio_signal *signal)
+{
+	double buf[BUFFER_LEN];
+	struct audio_signal *missing;
+	bool ok;
+	size_t i;
+
+	/* Miss the first frequency */
+	missing = audio_signal_init(CHANNELS, SAMPLING_RATE);
+	for (i = 1; i < test_freqs_len; i++) {
+		audio_signal_add_frequency(missing, test_freqs[i], 0);
+	}
+	audio_signal_synthesize(missing);
+
+	audio_signal_fill(missing, buf, BUFFER_LEN / CHANNELS);
+	ok = audio_signal_detect(signal, SAMPLING_RATE, 0, buf, BUFFER_LEN);
+	igt_assert(!ok);
+}
+
 igt_main
 {
 	struct audio_signal *signal;
 	int ret;
+	size_t i;
 
 	igt_subtest_group {
 		igt_fixture {
 			signal = audio_signal_init(CHANNELS, SAMPLING_RATE);
 
-			ret = audio_signal_add_frequency(signal, 300, 0);
-			igt_assert(ret == 0);
-			ret = audio_signal_add_frequency(signal, 700, 0);
-			igt_assert(ret == 0);
-			ret = audio_signal_add_frequency(signal, 5000, 0);
-			igt_assert(ret == 0);
+			for (i = 0; i < test_freqs_len; i++) {
+				ret = audio_signal_add_frequency(signal,
+								 test_freqs[i],
+								 0);
+				igt_assert(ret == 0);
+			}
 
 			audio_signal_synthesize(signal);
 		}
@@ -94,6 +118,9 @@ igt_main
 		igt_subtest("signal-detect-noise")
 			test_signal_detect_noise(signal);
 
+		igt_subtest("signal-detect-missing")
+			test_signal_detect_missing(signal);
+
 		igt_fixture {
 			audio_signal_fini(signal);
 		}
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-05-29 13:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 13:32 [igt-dev] [PATCH i-g-t 0/5] Add igt_audio self-tests and check for noise/pops Simon Ser
2019-05-29 13:32 ` [igt-dev] [PATCH i-g-t 1/5] lib/igt_audio: add basic audio_signal_detect tests Simon Ser
2019-06-03 13:43   ` Martin Peres
2019-06-04  8:00     ` Ser, Simon
2019-05-29 13:32 ` Simon Ser [this message]
2019-06-03 13:46   ` [igt-dev] [PATCH i-g-t 2/5] lib/tests/igt_audio: add test with missing frequency Martin Peres
2019-05-29 13:32 ` [igt-dev] [PATCH i-g-t 3/5] lib/tests/igt_audio: add test with an extra frequency Simon Ser
2019-06-03 13:49   ` Martin Peres
2019-05-29 13:32 ` [igt-dev] [PATCH i-g-t 4/5] lib/igt_audio: detect noise and pops Simon Ser
2019-06-03 14:11   ` Martin Peres
2019-05-29 13:32 ` [igt-dev] [PATCH i-g-t 5/5] lib/tests/igt_audio: add a pop test Simon Ser
2019-06-03 14:14   ` Martin Peres
2019-05-29 14:44 ` [igt-dev] ✓ Fi.CI.BAT: success for Add igt_audio self-tests and check for noise/pops Patchwork
2019-05-29 22:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190529133250.27817-3-simon.ser@intel.com \
    --to=simon.ser@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=martin.peres@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.