From: Jason Gunthorpe <jgg@ziepe.ca>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Ariel Levkovich <lariel@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mlx5: avoid 64-bit division
Date: Wed, 29 May 2019 13:08:00 -0300 [thread overview]
Message-ID: <20190529160800.GA6680@ziepe.ca> (raw)
In-Reply-To: <20190520111902.7104DE0184@unicorn.suse.cz>
On Mon, May 20, 2019 at 01:19:02PM +0200, Michal Kubecek wrote:
> Commit 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
> breaks i386 build by introducing three 64-bit divisions. As the divisor
> is MLX5_SW_ICM_BLOCK_SIZE() which is always a power of 2, we can replace
> the division with bit operations.
>
> Fixes: 25c13324d03d ("IB/mlx5: Add steering SW ICM device memory type")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/mlx5/cmd.c | 9 +++++++--
> drivers/infiniband/hw/mlx5/main.c | 2 +-
> 2 files changed, 8 insertions(+), 3 deletions(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2019-05-29 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 11:19 [PATCH] mlx5: avoid 64-bit division Michal Kubecek
2019-05-20 11:28 ` Leon Romanovsky
2019-05-28 14:01 ` Leon Romanovsky
2019-05-28 14:44 ` Ariel Levkovich
2019-05-27 18:15 ` Jason Gunthorpe
2019-05-27 20:47 ` Michal Kubecek
2019-05-29 16:08 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529160800.GA6680@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=lariel@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mkubecek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.