From: Andrew Lunn <andrew@lunn.ch>
To: "Voon, Weifeng" <weifeng.voon@intel.com>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
biao huang <biao.huang@mediatek.com>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>
Subject: Re: [PATCH net-next v4 1/5] net: stmmac: enable clause 45 mdio support
Date: Thu, 30 May 2019 01:06:41 +0200 [thread overview]
Message-ID: <20190529230641.GD18059@lunn.ch> (raw)
In-Reply-To: <D6759987A7968C4889FDA6FA91D5CBC814707D32@PGSMSX103.gar.corp.intel.com>
On Wed, May 29, 2019 at 05:39:44PM +0000, Voon, Weifeng wrote:
> > > +static void stmmac_mdio_c45_setup(struct stmmac_priv *priv, int phyreg,
> > > + u32 *val, u32 *data)
> > > +{
> > > + unsigned int reg_shift = priv->hw->mii.reg_shift;
> > > + unsigned int reg_mask = priv->hw->mii.reg_mask;
> >
> > Reverse christmas tree here. You also should align the function variables with
> > the opening parenthesis of the function here and in the remaining series.
> >
> > Otherwise this patch looks good to me.
>
> It is already reversed Christmas tree.
Yes.
> Somehow each of the character's width in the
> email is not equal.
Sounds like somebody is using a proportional font in there email
client. Bad idea.
Andrew
next prev parent reply other threads:[~2019-05-29 23:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 16:58 [PATCH net-next v4 0/5] net: stmmac: enable EHL SGMI Voon Weifeng
2019-05-29 16:58 ` [PATCH net-next v4 1/5] net: stmmac: enable clause 45 mdio support Voon Weifeng
2019-05-29 10:16 ` Jose Abreu
2019-05-29 17:39 ` Voon, Weifeng
2019-05-29 23:06 ` Andrew Lunn [this message]
2019-05-29 16:58 ` [PATCH net-next v4 2/5] net: stmmac: introducing support for DWC xPCS logics Voon Weifeng
2019-05-29 10:19 ` Jose Abreu
2019-05-29 16:58 ` [PATCH net-next v4 3/5] net: stmmac: add xpcs function hooks into main driver and ethtool Voon Weifeng
2019-05-29 10:23 ` Jose Abreu
2019-05-29 16:58 ` [PATCH net-next v4 4/5] net: stmmac: add xPCS functions for device with DWMACv5.1 Voon Weifeng
2019-05-29 10:25 ` Jose Abreu
2019-05-29 16:58 ` [PATCH net-next v4 5/5] net: stmmac: add EHL SGMII 1Gbps PCI info and PCI ID Voon Weifeng
2019-05-29 10:28 ` Jose Abreu
2019-05-29 18:00 ` Voon, Weifeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529230641.GD18059@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=biao.huang@mediatek.com \
--cc=boon.leong.ong@intel.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=weifeng.voon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.