From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2E6EC28CC0 for ; Thu, 30 May 2019 03:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B318424A8B for ; Thu, 30 May 2019 03:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186811; bh=nPvomvPQq5adWu3ARBRN8eWC1pZmBx/+VxfUKkmkx04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LLuPEPmVyCXlr9XXXTnK2hYAPTdmYAA3Se0WsmUMadY5hAg8TmosKICqd1z5gBai7 Lv67vMgzopE6mI94FhnvEDz+h6J5MqSYpOss2QR5EmdlrdUQJ6xWtRHCr0CjbvHJUx iOfmLisjlHIxEWG6xD9Zt2fO/PuEYRgSDRM/0xwo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387776AbfE3D0v (ORCPT ); Wed, 29 May 2019 23:26:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:53556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731782AbfE3DTD (ORCPT ); Wed, 29 May 2019 23:19:03 -0400 Received: from localhost (ip67-88-213-2.z213-88-67.customer.algx.net [67.88.213.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75940247F0; Thu, 30 May 2019 03:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559186342; bh=nPvomvPQq5adWu3ARBRN8eWC1pZmBx/+VxfUKkmkx04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L+Ve/SOUYpWXSMan6j9ocsNuMHLK4ngHa3iI5x9CaT96ygAasWiLFpL/0DFHPpvUv J9IPmFwMijfzSjDCM1J8ud7Dx6kc+l3/W1jUm6iJ7w5/RBxeN6AuN/ubL8IpwpP31/ N+SeAXB5ZNBr8z54nb6sWVJ4slquhsvwO/psXpZU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Baluta , Nicolin Chen , Mark Brown , Sasha Levin Subject: [PATCH 4.14 069/193] ASoC: fsl_sai: Update is_slave_mode with correct value Date: Wed, 29 May 2019 20:05:23 -0700 Message-Id: <20190530030458.901771595@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190530030446.953835040@linuxfoundation.org> References: <20190530030446.953835040@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit ddb351145a967ee791a0fb0156852ec2fcb746ba ] is_slave_mode defaults to false because sai structure that contains it is kzalloc'ed. Anyhow, if we decide to set the following configuration SAI slave -> SAI master, is_slave_mode will remain set on true although SAI being master it should be set to false. Fix this by updating is_slave_mode for each call of fsl_sai_set_dai_fmt. Signed-off-by: Daniel Baluta Acked-by: Nicolin Chen Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/fsl_sai.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index 18e5ce81527d2..c1c733b573a7f 100644 --- a/sound/soc/fsl/fsl_sai.c +++ b/sound/soc/fsl/fsl_sai.c @@ -274,12 +274,14 @@ static int fsl_sai_set_dai_fmt_tr(struct snd_soc_dai *cpu_dai, case SND_SOC_DAIFMT_CBS_CFS: val_cr2 |= FSL_SAI_CR2_BCD_MSTR; val_cr4 |= FSL_SAI_CR4_FSD_MSTR; + sai->is_slave_mode = false; break; case SND_SOC_DAIFMT_CBM_CFM: sai->is_slave_mode = true; break; case SND_SOC_DAIFMT_CBS_CFM: val_cr2 |= FSL_SAI_CR2_BCD_MSTR; + sai->is_slave_mode = false; break; case SND_SOC_DAIFMT_CBM_CFS: val_cr4 |= FSL_SAI_CR4_FSD_MSTR; -- 2.20.1