From: David Ahern <dsahern@kernel.org>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: idosch@mellanox.com, saeedm@mellanox.com, kafai@fb.com,
weiwan@google.com, David Ahern <dsahern@gmail.com>
Subject: [PATCH net-next 5/7] mlxsw: Fail attempts to use routes with nexthop objects
Date: Wed, 29 May 2019 20:07:58 -0700 [thread overview]
Message-ID: <20190530030800.1683-6-dsahern@kernel.org> (raw)
In-Reply-To: <20190530030800.1683-1-dsahern@kernel.org>
From: David Ahern <dsahern@gmail.com>
Fail attempts to use nexthop objects with routes until support can be
properly added.
Signed-off-by: David Ahern <dsahern@gmail.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index 4f781358aef1..23f17ea52061 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -6122,6 +6122,20 @@ static int mlxsw_sp_router_fib_event(struct notifier_block *nb,
NL_SET_ERR_MSG_MOD(info->extack, "IPv6 gateway with IPv4 route is not supported");
return notifier_from_errno(-EINVAL);
}
+ if (fen_info->fi->nh) {
+ NL_SET_ERR_MSG_MOD(info->extack, "IPv4 route with nexthop objects is not supported");
+ return notifier_from_errno(-EINVAL);
+ }
+ } else if (info->family == AF_INET6) {
+ struct fib6_entry_notifier_info *fen6_info;
+
+ fen6_info = container_of(info,
+ struct fib6_entry_notifier_info,
+ info);
+ if (fen6_info->rt->nh) {
+ NL_SET_ERR_MSG_MOD(info->extack, "IPv6 route with nexthop objects is not supported");
+ return notifier_from_errno(-EINVAL);
+ }
}
break;
}
--
2.11.0
next prev parent reply other threads:[~2019-05-30 3:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 3:07 [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info David Ahern
2019-05-30 3:07 ` [PATCH net-next 1/7] ipv4: Use accessors for fib_info nexthop data David Ahern
2019-05-30 3:07 ` [PATCH net-next 2/7] ipv4: Prepare for fib6_nh from a nexthop object David Ahern
2019-05-30 3:07 ` [PATCH net-next 3/7] ipv4: Plumb support for nexthop object in a fib_info David Ahern
2019-05-30 3:07 ` [PATCH net-next 4/7] ipv6: Plumb support for nexthop object in a fib6_info David Ahern
2019-05-30 3:07 ` David Ahern [this message]
2019-05-30 8:10 ` [PATCH net-next 5/7] mlxsw: Fail attempts to use routes with nexthop objects Ido Schimmel
2019-05-30 3:07 ` [PATCH net-next 6/7] mlx5: " David Ahern
2019-05-30 3:08 ` [PATCH net-next 7/7] rocker: " David Ahern
2019-05-30 15:06 ` [PATCH net-next 0/7] net: add struct nexthop to fib{6}_info Alexei Starovoitov
2019-05-30 15:15 ` David Ahern
2019-05-30 15:18 ` Alexei Starovoitov
2019-05-30 18:01 ` David Miller
2019-05-30 18:27 ` Alexei Starovoitov
2019-05-30 18:52 ` David Ahern
2019-05-30 18:57 ` David Miller
2019-05-30 18:58 ` David Ahern
2019-05-30 20:01 ` Alexei Starovoitov
2019-05-31 21:29 ` David Miller
2019-05-31 21:38 ` David Ahern
2019-06-01 1:04 ` Eric Dumazet
2019-06-01 2:29 ` David Ahern
2019-06-01 2:34 ` Eric Dumazet
2019-06-01 2:38 ` Eric Dumazet
2019-06-01 2:51 ` Alexei Starovoitov
2019-06-01 2:59 ` David Ahern
2019-06-01 3:10 ` Alexei Starovoitov
2019-06-03 16:50 ` Willem de Bruijn
2019-05-30 18:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530030800.1683-6-dsahern@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.