All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.com>,
	Sebastian Reichel <sre@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel@collabora.com,
	Keerthy <j-keerthy@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCHv6 0/4] omapdrm: DSI command mode panel support
Date: Wed, 29 May 2019 22:46:40 -0700	[thread overview]
Message-ID: <20190530054640.GQ5447@atomide.com> (raw)
In-Reply-To: <20190529081038.GP5447@atomide.com>

* Tony Lindgren <tony@atomide.com> [190529 08:11]:
> * Tomi Valkeinen <tomi.valkeinen@ti.com> [190529 07:06]:
> > On 28/05/2019 13:18, Tony Lindgren wrote:
> > 
> > > > My board is x15 rev A3, attached to AM5 EVM. I've also attached my kernel
> > > > config.
> > > 
> > > Strange that this is not affecting other x15? I think timer12 would
> > > be blocked on HS devices though?
> > 
> > Seems that the kernel config affects. omap2plus_defconfig boots ok.
> 
> OK, this line in your oops:
> 
> Unable to handle kernel paging request at virtual address 5a5a5a5a
> 
> Probably means we hit some slab poison with DEBUG_SLAB set.
> Looks like your config boots fine with DEBUG_SLAB disabled
> for me.
> 
> As this only happens for timer12, I wonder if we're again
> hitting some uncompress issue with corrupted dtb. Changing
> u-boot ftdaddr higher up might possibly make it go away.
> Or else there's a bug elsewhere :)

Oh but CM_WKUPAON_TIMER12_CLKCTRL has no CLKSEL option unlike
CM_WKUPAON_TIMER1_CLKCTRL. Below is one part of the fix, but
it seems like we're missing handling somewhere as trying to
get a non-existing clock should just produce -ENODEV type error.

And the clksel should be just handled with assigned-clocks
in general, but I think we still need it there until we
have drivers/clocksource/ timer drivers updated to boot
using early_platform_device.

Regards,

Tony

8< ---------------
diff --git a/arch/arm/boot/dts/dra7-l4.dtsi b/arch/arm/boot/dts/dra7-l4.dtsi
--- a/arch/arm/boot/dts/dra7-l4.dtsi
+++ b/arch/arm/boot/dts/dra7-l4.dtsi
@@ -4450,8 +4450,6 @@
 			timer12: timer@0 {
 				compatible = "ti,omap5430-timer";
 				reg = <0x0 0x80>;
-				clocks = <&wkupaon_clkctrl DRA7_WKUPAON_TIMER12_CLKCTRL 24>;
-				clock-names = "fck";
 				interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
 				ti,timer-alwon;
 				ti,timer-secure;

  reply	other threads:[~2019-05-30  5:46 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23 20:07 [PATCHv6 0/4] omapdrm: DSI command mode panel support Sebastian Reichel
2019-05-23 20:07 ` [PATCHv6 1/4] drm/omap: use DRM_DEBUG_DRIVER instead of CORE Sebastian Reichel
2019-05-23 20:19   ` Joe Perches
2019-05-23 20:07 ` [PATCHv6 2/4] drm/omap: don't check dispc timings for DSI Sebastian Reichel
2019-05-23 20:07 ` [PATCHv6 3/4] drm/omap: add framedone interrupt support Sebastian Reichel
2019-05-28 10:19   ` Tomi Valkeinen
2019-05-28 10:19     ` Tomi Valkeinen
2019-05-29 21:55     ` Sebastian Reichel
2019-05-31 12:23       ` Tomi Valkeinen
2019-05-31 12:23         ` Tomi Valkeinen
2019-05-23 20:07 ` [PATCHv6 4/4] drm/omap: add support for manually updated displays Sebastian Reichel
2019-05-27 10:51 ` [PATCHv6 0/4] omapdrm: DSI command mode panel support Tomi Valkeinen
2019-05-27 10:51   ` Tomi Valkeinen
2019-05-27 11:21   ` Tony Lindgren
2019-05-28  9:19     ` Tomi Valkeinen
2019-05-28  9:19       ` Tomi Valkeinen
2019-05-28  9:39       ` Tony Lindgren
2019-05-28  9:51         ` Keerthy
2019-05-28  9:51           ` Keerthy
2019-05-28 10:05         ` Tomi Valkeinen
2019-05-28 10:05           ` Tomi Valkeinen
2019-05-28 10:18           ` Tony Lindgren
2019-05-28 10:32             ` Tomi Valkeinen
2019-05-28 10:32               ` Tomi Valkeinen
2019-05-29  9:33               ` Peter Ujfalusi
2019-05-29  9:33                 ` Peter Ujfalusi
2019-05-29  7:06             ` Tomi Valkeinen
2019-05-29  7:06               ` Tomi Valkeinen
2019-05-29  8:10               ` Tony Lindgren
2019-05-30  5:46                 ` Tony Lindgren [this message]
2019-05-30  7:02                   ` Tony Lindgren
2019-06-03  8:29     ` Pavel Machek
2019-06-03  8:29       ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2019-04-03 19:54 [PATCHv5 0/6] " Sebastian Reichel
2019-04-03 20:13 ` [PATCHv6 0/4] " Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190530054640.GQ5447@atomide.com \
    --to=tony@atomide.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hns@goldelico.com \
    --cc=j-keerthy@ti.com \
    --cc=kernel@collabora.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=peter.ujfalusi@ti.com \
    --cc=sebastian.reichel@collabora.com \
    --cc=sre@kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.