From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC82C28CC2 for ; Thu, 30 May 2019 06:54:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBAFB25B99 for ; Thu, 30 May 2019 06:54:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nRO+OPuZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBAFB25B99 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UR3zgtPDHpJ15GCUd5O1nYpY31QlVfFNwi25YzVrUBI=; b=nRO+OPuZgiG8jg 2v7lS0Q6r8uPJhV1B5Q/pvjYYTvSSfqY2pY2BVWcDu3NUzh76pQ+pySbHdkht77y050qjmXyLt6KE wNtdcQcaHh6///7hhNwuRROgvNa3lGM0WiXGspR2E42ZyMK5esJCsVQ+Nbf+iUODluEbMFeuUy7Uv lp0XKdIQNKZC+ybAFmGEZGKYYy6GavCyN5x9VYgvVj4Wi+lqrwUebQrStlJIgL4MDb/aQ6/o8VeDQ WEJDlN5RUhQtYhWdWYutbJ8fU4r6m+SonkpLuFyGhtoUu1VonIXE42sbwrzr5MrqNY4fd/C4so47k l1jbPtWLXRcrQRDjetkg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWExi-00081A-Ef; Thu, 30 May 2019 06:54:54 +0000 Received: from 59-120-53-16.hinet-ip.hinet.net ([59.120.53.16] helo=ATCSQR.andestech.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWExf-00080A-8M for linux-riscv@lists.infradead.org; Thu, 30 May 2019 06:54:52 +0000 Received: from mail.andestech.com (atcpcs16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id x4U6n038060958; Thu, 30 May 2019 14:49:00 +0800 (GMT-8) (envelope-from nickhu@andestech.com) Received: from andestech.com (10.0.15.65) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.123.3; Thu, 30 May 2019 14:54:35 +0800 Date: Thu, 30 May 2019 14:54:36 +0800 From: Nick Hu To: Greentime Ying-Han =?utf-8?B?SHUo6IOh6Iux5ryiKQ==?= , "palmer@sifive.com" , "albert@sifive.com" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "hch@infradead.org" Subject: Re: [PATCH v2] riscv: Fix udelay in RV32. Message-ID: <20190530065436.GA15137@andestech.com> References: <67a14915b99ee5d933ef9e7e056fc6e1935e775e.1559198255.git.nickhu@andestech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <67a14915b99ee5d933ef9e7e056fc6e1935e775e.1559198255.git.nickhu@andestech.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.0.15.65] X-DNSRBL: X-MAIL: ATCSQR.andestech.com x4U6n038060958 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_235451_553020_BAD6481E X-CRM114-Status: GOOD ( 10.86 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "green.hu@gmail.com" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXkgMzAsIDIwMTkgYXQgMDI6NDk6MTBQTSArMDgwMCwgTmljayBDaHVuLU1pbmcg SHUo6IOh5bO76YqYKSB3cm90ZToKPiBJbiBSVjMyLCB1ZGVsYXkgd291bGQgZGVsYXkgdGhlIHdy b25nIGN5Y2xlLiBXaGVuIGl0IHNoaWZ0cyByaWdodAo+ICJVREVMQVlfU0hJVEZUIiBiaXRzLCBp dCBlaXRoZXIgZGVsYXlzIDAgY3ljbGUgb3IgMSBjeWNsZS4gSXQgb25seSB3b3Jrcwo+IGNvcnJl Y3RseSBpbiBSVjY0LiBCZWNhdXNlIHRoZSAndWN5Y2xlcycgYWx3YXlzIG5lZWRzIHRvIGJlIDY0 IGJpdHMKPiB2YXJpYWJsZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBOaWNrIEh1IDxuaWNraHVAYW5k ZXN0ZWNoLmNvbT4KPiAtLS0KPiAgYXJjaC9yaXNjdi9saWIvZGVsYXkuYyB8IDIgKy0KPiAgMSBm aWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2FyY2gvcmlzY3YvbGliL2RlbGF5LmMgYi9hcmNoL3Jpc2N2L2xpYi9kZWxheS5jCj4gaW5k ZXggZGNlOGFlMjRjNmQzLi5lZTY4NTNjMWUzNDEgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9yaXNjdi9s aWIvZGVsYXkuYwo+ICsrKyBiL2FyY2gvcmlzY3YvbGliL2RlbGF5LmMKPiBAQCAtODgsNyArODgs NyBAQCBFWFBPUlRfU1lNQk9MKF9fZGVsYXkpOwo+ICAKPiAgdm9pZCB1ZGVsYXkodW5zaWduZWQg bG9uZyB1c2VjcykKPiAgewo+IC0JdW5zaWduZWQgbG9uZyB1Y3ljbGVzID0gdXNlY3MgKiBscGpf ZmluZSAqIFVERUxBWV9NVUxUOwo+ICsJdTY0IHVjeWNsZXMgPSAodTY0KXVzZWNzICogbHBqX2Zp bmUgKiBVREVMQVlfTVVMVDsKPiAgCj4gIAlpZiAodW5saWtlbHkodXNlY3MgPiBNQVhfVURFTEFZ X1VTKSkgewo+ICAJCV9fZGVsYXkoKHU2NCl1c2VjcyAqIHJpc2N2X3RpbWViYXNlIC8gMTAwMDAw MFVMTCk7Cj4gLS0gCj4gMi4xNy4wCj4KCkhpIEFsbCwgSSBmb3Jnb3QgdG8gYWRkICJSZXZpZXdl ZC1ieTogUGFsbWVyIERhYmJlbHQgPHBhbG1lckBzaWZpdmUuY29tPiIuCkkgd2lsbCBzZW5kIGFu b3RoZXIgcGF0Y2guCgpTb3JyeS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 208B7C072B1 for ; Thu, 30 May 2019 06:54:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F090125AE2 for ; Thu, 30 May 2019 06:54:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727613AbfE3Gy4 (ORCPT ); Thu, 30 May 2019 02:54:56 -0400 Received: from 59-120-53-16.HINET-IP.hinet.net ([59.120.53.16]:56320 "EHLO ATCSQR.andestech.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727297AbfE3Gy4 (ORCPT ); Thu, 30 May 2019 02:54:56 -0400 Received: from mail.andestech.com (atcpcs16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id x4U6n038060958; Thu, 30 May 2019 14:49:00 +0800 (GMT-8) (envelope-from nickhu@andestech.com) Received: from andestech.com (10.0.15.65) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.123.3; Thu, 30 May 2019 14:54:35 +0800 Date: Thu, 30 May 2019 14:54:36 +0800 From: Nick Hu To: Greentime Ying-Han =?utf-8?B?SHUo6IOh6Iux5ryiKQ==?= , "palmer@sifive.com" , "albert@sifive.com" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "hch@infradead.org" CC: "green.hu@gmail.com" Subject: Re: [PATCH v2] riscv: Fix udelay in RV32. Message-ID: <20190530065436.GA15137@andestech.com> References: <67a14915b99ee5d933ef9e7e056fc6e1935e775e.1559198255.git.nickhu@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <67a14915b99ee5d933ef9e7e056fc6e1935e775e.1559198255.git.nickhu@andestech.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.0.15.65] X-DNSRBL: X-MAIL: ATCSQR.andestech.com x4U6n038060958 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 30, 2019 at 02:49:10PM +0800, Nick Chun-Ming Hu(胡峻銘) wrote: > In RV32, udelay would delay the wrong cycle. When it shifts right > "UDELAY_SHITFT" bits, it either delays 0 cycle or 1 cycle. It only works > correctly in RV64. Because the 'ucycles' always needs to be 64 bits > variable. > > Signed-off-by: Nick Hu > --- > arch/riscv/lib/delay.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/lib/delay.c b/arch/riscv/lib/delay.c > index dce8ae24c6d3..ee6853c1e341 100644 > --- a/arch/riscv/lib/delay.c > +++ b/arch/riscv/lib/delay.c > @@ -88,7 +88,7 @@ EXPORT_SYMBOL(__delay); > > void udelay(unsigned long usecs) > { > - unsigned long ucycles = usecs * lpj_fine * UDELAY_MULT; > + u64 ucycles = (u64)usecs * lpj_fine * UDELAY_MULT; > > if (unlikely(usecs > MAX_UDELAY_US)) { > __delay((u64)usecs * riscv_timebase / 1000000ULL); > -- > 2.17.0 > Hi All, I forgot to add "Reviewed-by: Palmer Dabbelt ". I will send another patch. Sorry.