From: Kalle Valo <kvalo@codeaurora.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-wireless@vger.kernel.org,
Amitkumar Karwar <amitkarwar@gmail.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
Xinming Hu <huxinming820@gmail.com>,
huangwen@venustech.com.cn, Solar Designer <solar@openwall.com>,
Marcus Meissner <meissner@suse.de>
Subject: Re: [PATCH 1/2] mwifiex: Fix possible buffer overflows at parsing bss descriptor
Date: Thu, 30 May 2019 11:22:57 +0000 (UTC) [thread overview]
Message-ID: <20190530112257.63D0260A33@smtp.codeaurora.org> (raw)
In-Reply-To: <20190529125220.17066-2-tiwai@suse.de>
Takashi Iwai <tiwai@suse.de> wrote:
> mwifiex_update_bss_desc_with_ie() calls memcpy() unconditionally in
> a couple places without checking the destination size. Since the
> source is given from user-space, this may trigger a heap buffer
> overflow.
>
> Fix it by putting the length check before performing memcpy().
>
> This fix addresses CVE-2019-3846.
>
> Reported-by: huangwen <huangwen@venustech.com.cn>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
2 patches applied to wireless-drivers.git, thanks.
13ec7f10b87f mwifiex: Fix possible buffer overflows at parsing bss descriptor
685c9b7750bf mwifiex: Abort at too short BSS descriptor element
--
https://patchwork.kernel.org/patch/10967049/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-05-30 11:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 12:52 [PATCH 0/2] Buffer overflow / read checks in mwifiex Takashi Iwai
2019-05-29 12:52 ` [PATCH 1/2] mwifiex: Fix possible buffer overflows at parsing bss descriptor Takashi Iwai
2019-05-30 11:22 ` Kalle Valo [this message]
2019-05-29 12:52 ` [PATCH 2/2] mwifiex: Abort at too short BSS descriptor element Takashi Iwai
2019-06-13 17:49 ` Brian Norris
2019-06-13 18:12 ` Takashi Iwai
2019-06-13 18:38 ` Brian Norris
2019-06-13 20:26 ` Brian Norris
2019-06-15 0:19 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530112257.63D0260A33@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=gbhat@marvell.com \
--cc=huangwen@venustech.com.cn \
--cc=huxinming820@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=meissner@suse.de \
--cc=nishants@marvell.com \
--cc=solar@openwall.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.