Re: [meta-oe][PATCH] s-suite: push SRCREV to version 3.4

[Adrian Bunk <bunk@stusta.de>]

On Thu, May 30, 2019 at 02:15:21PM +0200, Paolo Valente wrote:
> 
> 
> > Il giorno 30 mag 2019, alle ore 13:14, Adrian Bunk <bunk@stusta.de> ha scritto:
> > 
> > On Thu, May 30, 2019 at 12:25:39PM +0200, Paolo Valente wrote:
> >> Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
> >> ---
> >> meta-oe/recipes-benchmark/s-suite/s-suite_git.bb | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb b/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb
> >> index 706a55e11..db1945dd0 100644
> >> --- a/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb
> >> +++ b/meta-oe/recipes-benchmark/s-suite/s-suite_git.bb
> >> @@ -2,8 +2,8 @@ SUMMARY = "Small collection of benchmarks for storage I/O"
> >> LICENSE = "GPLv2"
> >> LIC_FILES_CHKSUM = "file://COPYING;md5=b529aaa6a0c50f15d29f89609b5c22f3"
> >> 
> >> -SRCREV = "262227ec9de4be1ab41d9918d32ceb773089f1dd"
> >> -PV = "3.2+git${SRCPV}"
> >> +SRCREV = "8d22ab8a4cc1484622c47ac9c5944fb9a61a5c0f"
> >> +PV = "3.4+git${SRCPV}"
> >> SRC_URI = "git://github.com/Algodev-github/S.git;protocol=https;branch=master"
> >> ...
> > 
> > The problem was already there before, but the upgrade gives the
> > opportunity to get rid of the +git${SRCPV}, which is incorrect
> > when exactly the release is packaged.
> > 
> 
> Sorry,
> you pointed this out already, but then I thought I had solved it.  Now
> I also understand why the previous push-up to 3.3 was not it.
> 
> And now, I'm sorry, but I think I'd better to ask for your help
> explicitly: how should I fix this exactly?

Just remove the +git${SRCPV} from the PV line:

-SRCREV = "262227ec9de4be1ab41d9918d32ceb773089f1dd"
-PV = "3.2+git${SRCPV}"
+SRCREV = "8d22ab8a4cc1484622c47ac9c5944fb9a61a5c0f"
+PV = "3.4"

> Thanks for your patience,
> Paolo


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed