From: Ramalingam C <ramalingam.c@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v2 3/5] test/i915: gem_exec_capture: use the gem_engine_topology library
Date: Thu, 30 May 2019 21:29:57 +0530 [thread overview]
Message-ID: <20190530155956.GA16874@intel.com> (raw)
In-Reply-To: <155923125534.27302.18286647769972227542@skylake-alporthouse-com>
On 2019-05-30 at 16:47:35 +0100, Chris Wilson wrote:
> Quoting Ramalingam C (2019-05-30 16:42:20)
> > @@ -501,7 +502,7 @@ static void userptr(int fd, int dir)
> > igt_assert(posix_memalign(&ptr, 4096, 4096) == 0);
> > igt_require(__gem_userptr(fd, ptr, 4096, 0, 0, &handle) == 0);
> >
> > - __capture1(fd, dir, 0, handle);
> > + __capture1(fd, dir, NULL, handle);
>
> You're missing something here. Using the new iterator NULL results in a
> random engine.
Chris,
engine pointer is passed into __capture1() and following delta handles
the flags for execbuf.
- execbuf.flags = ring;
+ execbuf.flags = e ? e->flags : 0;
Will this be fine?
-Ram
> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-30 15:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 15:42 [igt-dev] [PATCH i-g-t v2 0/5] Engine discovery for few more tests Ramalingam C
2019-05-30 15:42 ` [igt-dev] [PATCH i-g-t v2 1/5] test/i915: gem_bad_reloc: use the gem_engine_topology library Ramalingam C
2019-06-06 14:06 ` Andi Shyti
2019-05-30 15:42 ` [igt-dev] [PATCH i-g-t v2 2/5] test/i915: gem_exec_async: " Ramalingam C
2019-05-30 15:44 ` Chris Wilson
2019-05-30 16:14 ` Ramalingam C
2019-06-06 14:09 ` Andi Shyti
2019-05-30 15:42 ` [igt-dev] [PATCH i-g-t v2 3/5] test/i915: gem_exec_capture: " Ramalingam C
2019-05-30 15:47 ` Chris Wilson
2019-05-30 15:59 ` Ramalingam C [this message]
2019-06-06 14:10 ` Andi Shyti
2019-05-30 15:42 ` [igt-dev] [PATCH i-g-t v2 4/5] test/i915: gem_exec_params: " Ramalingam C
2019-05-30 15:49 ` Chris Wilson
2019-05-30 16:13 ` Ramalingam C
2019-06-06 14:12 ` Andi Shyti
2019-05-30 15:42 ` [igt-dev] [PATCH i-g-t v2 5/5] test/prime_vgem: " Ramalingam C
2019-05-30 15:50 ` Chris Wilson
2019-05-30 16:05 ` Ramalingam C
2019-06-06 14:17 ` Andi Shyti
2019-06-06 14:38 ` Tvrtko Ursulin
2019-06-06 15:31 ` Ramalingam C
2019-06-06 15:34 ` Tvrtko Ursulin
2019-06-06 15:48 ` Ramalingam C
2019-06-06 15:57 ` Tvrtko Ursulin
2019-06-07 10:38 ` Andi Shyti
2019-06-07 10:34 ` Andi Shyti
2019-05-31 11:11 ` [igt-dev] ✓ Fi.CI.BAT: success for Engine discovery for few more tests Patchwork
2019-06-01 2:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190530155956.GA16874@intel.com \
--to=ramalingam.c@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.