From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: dm-init: fix 2 incorrect use of kstrndup() Date: Thu, 30 May 2019 12:11:03 -0400 Message-ID: <20190530161103.GA30026@redhat.com> References: <20190529013320.GA3307@zhanggen-UX430UQ> <20190529152443.GA4076@zhanggen-UX430UQ> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190529152443.GA4076@zhanggen-UX430UQ> Sender: linux-kernel-owner@vger.kernel.org To: Gen Zhang Cc: Bart Van Assche , dm-devel@redhat.com, agk@redhat.com, linux-kernel@vger.kernel.org List-Id: dm-devel.ids On Wed, May 29 2019 at 11:24am -0400, Gen Zhang wrote: > On Wed, May 29, 2019 at 05:23:53AM -0700, Bart Van Assche wrote: > > On 5/28/19 6:33 PM, Gen Zhang wrote: > > > In drivers/md/dm-init.c, kstrndup() is incorrectly used twice. > > > > > > It should be: char *kstrndup(const char *s, size_t max, gfp_t gfp); > > > > Should the following be added to this patch? > > > > Fixes: 6bbc923dfcf5 ("dm: add support to directly boot to a mapped > > device") # v5.1. > > Cc: stable > > > > Thanks, > > > > Bart. > Personally, I am not quite sure about this question, because I am not > the maintainer of this part. Yes, it should have the tags Bart suggested. I'll take care it. Thanks, Mike