From: Vivek Goyal <vgoyal@redhat.com>
To: Liu Bo <bo.liu@linux.alibaba.com>
Cc: virtio-fs@redhat.com, Peng Tao <tao.peng@linux.alibaba.com>
Subject: Re: [Virtio-fs] [PATCH] fuse: refcount FORGET requests
Date: Fri, 31 May 2019 14:59:07 -0400 [thread overview]
Message-ID: <20190531185907.GC26058@redhat.com> (raw)
In-Reply-To: <20190531184454.ybk54uodcf5ozxts@US-160370MP2.local>
On Fri, May 31, 2019 at 11:44:55AM -0700, Liu Bo wrote:
> On Fri, May 31, 2019 at 09:22:28AM -0400, Vivek Goyal wrote:
> > On Fri, May 31, 2019 at 05:24:03PM +0800, Peng Tao wrote:
> > > Right now FORGET requests are not tracked and they might be sent
> > > after DESTROY request.
> >
> > How does that happen?
> >
>
> A bit more details, it is those FORGETs that remain in HIGHPRI vq,
> sent before DESTROY but not yet processed by daemon before DESTROY
> gets back to guest, then they get processed after the 2nd INIT.
I just posted 3 patches to make sure forget request is not sent after
destroy. Can you give it a try and see if it solves the problem.
I also pushed my changes to this branch.
https://github.com/rhvgoyal/linux/commits/flush-forget
Vivek
next prev parent reply other threads:[~2019-05-31 18:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 9:24 [Virtio-fs] [PATCH] fuse: refcount FORGET requests Peng Tao
2019-05-31 13:22 ` Vivek Goyal
2019-05-31 17:38 ` Liu Bo
2019-05-31 17:44 ` Vivek Goyal
2019-05-31 18:35 ` Liu Bo
2019-05-31 18:44 ` Liu Bo
2019-05-31 18:59 ` Vivek Goyal [this message]
2019-05-31 19:53 ` Liu Bo
2019-06-01 1:40 ` Tao Peng
2019-06-03 13:10 ` Vivek Goyal
2019-06-04 3:21 ` Tao Peng
2019-06-03 13:13 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190531185907.GC26058@redhat.com \
--to=vgoyal@redhat.com \
--cc=bo.liu@linux.alibaba.com \
--cc=tao.peng@linux.alibaba.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.