From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/netsurf: disallow on archs requiring ABI specific CFLAGS
Date: Sat, 1 Jun 2019 09:01:23 +0200 [thread overview]
Message-ID: <20190601090123.4ff808f5@windsurf> (raw)
In-Reply-To: <20190601073351.4bf75739@thl530.multi.box>
Hello,
On Sat, 1 Jun 2019 07:33:51 +0200
Thomas Huth <huth@tuxfamily.org> wrote:
> > comment "netsurf needs a toolchain w/ dynamic library"
> > depends on BR2_STATIC_LIBS
> > + depends on BR2_PACKAGE_NETSURF_ARCH_SUPPORTS
>
> First, the comment is now not accurate anymore. It should also say
> something about the architectures where it is not available.
No, we never put comments about architecture dependencies, because
there's nothing the user can do about it.
> Then the logic below says that PACKAGE_NETSURF depends on "!STATIC_LIBS
> *AND* NETSURF_ARCH_SUPPORT". The dependency of the comment above is
> inverted, so I think this rather should be:
>
> depends on BR2_STATIC_LIBS || !BR2_PACKAGE_NETSURF_ARCH_SUPPORTS
No, because we precisely don't want the comment to show up when we're
on an architecture that cannot support the package.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-06-01 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 21:40 [Buildroot] [PATCH] package/netsurf: disallow on archs requiring ABI specific CFLAGS Peter Korsgaard
2019-06-01 5:33 ` Thomas Huth
2019-06-01 7:01 ` Thomas Petazzoni [this message]
2019-06-01 7:04 ` Thomas Petazzoni
2019-06-01 8:15 ` Peter Korsgaard
2019-06-06 15:38 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601090123.4ff808f5@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.