From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A0B7C28CC1 for ; Sat, 1 Jun 2019 13:44:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5488727719 for ; Sat, 1 Jun 2019 13:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559396649; bh=scxhZynwZodEPPgyPa4Jy0luRfXCFIG9QxNi2wfXlKY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=b0a6P7jYztOqGRIiUpFJmpyr5bkNPMso7tZLgPZu7dusN2moLilQ+EpBbfVNHLKwL oRn2TeLSGYCrDf2KJTWHrNN/jmDXI5Ltk8sKmc+7TY/cKhaWIfTFXn7XrWWjAr/h/H Ql8mfN2lzhBHHvU+Htq/Ei0/VVH4Vjn0uoS1TdSA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727359AbfFANRQ (ORCPT ); Sat, 1 Jun 2019 09:17:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:41944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727348AbfFANRP (ORCPT ); Sat, 1 Jun 2019 09:17:15 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8061827227; Sat, 1 Jun 2019 13:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559395034; bh=scxhZynwZodEPPgyPa4Jy0luRfXCFIG9QxNi2wfXlKY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MMbyILE5MCNZMfK70LuvMQvHLVF/vFCMdvbovVxzUdGbm5sBADDhGn6X+BQLb5bt5 /TQnh0lA/NO0AoI/xkUlpOTTicgTtAnau13b6jgFZtsLOm9azsSuO6e6G8zjJ2Qh8I CzOyBtXErF0WVDE6C8eebLtPnYgDGJFQIRAfBv68= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Brian Masney , Sean Paul , Sasha Levin , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.1 007/186] drm/msm: correct attempted NULL pointer dereference in debugfs Date: Sat, 1 Jun 2019 09:13:43 -0400 Message-Id: <20190601131653.24205-7-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190601131653.24205-1-sashal@kernel.org> References: <20190601131653.24205-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Brian Masney [ Upstream commit 90f94660e53189755676543954101de78c26253b ] msm_gem_describe() would attempt to dereference a NULL pointer via the address space pointer when no IOMMU is present. Correct this by adding the appropriate check. Signed-off-by: Brian Masney Fixes: 575f0485508b ("drm/msm: Clean up and enhance the output of the 'gem' debugfs node") Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20190513234105.7531-2-masneyb@onstation.org Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/msm_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index 18ca651ab942a..23de4d1b7b1ac 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -805,7 +805,8 @@ void msm_gem_describe(struct drm_gem_object *obj, struct seq_file *m) seq_puts(m, " vmas:"); list_for_each_entry(vma, &msm_obj->vmas, list) - seq_printf(m, " [%s: %08llx,%s,inuse=%d]", vma->aspace->name, + seq_printf(m, " [%s: %08llx,%s,inuse=%d]", + vma->aspace != NULL ? vma->aspace->name : NULL, vma->iova, vma->mapped ? "mapped" : "unmapped", vma->inuse); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: [PATCH AUTOSEL 5.1 007/186] drm/msm: correct attempted NULL pointer dereference in debugfs Date: Sat, 1 Jun 2019 09:13:43 -0400 Message-ID: <20190601131653.24205-7-sashal@kernel.org> References: <20190601131653.24205-1-sashal@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190601131653.24205-1-sashal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Sasha Levin , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Sean Paul , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Brian Masney List-Id: dri-devel@lists.freedesktop.org RnJvbTogQnJpYW4gTWFzbmV5IDxtYXNuZXliQG9uc3RhdGlvbi5vcmc+CgpbIFVwc3RyZWFtIGNv bW1pdCA5MGY5NDY2MGU1MzE4OTc1NTY3NjU0Mzk1NDEwMWRlNzhjMjYyNTNiIF0KCm1zbV9nZW1f ZGVzY3JpYmUoKSB3b3VsZCBhdHRlbXB0IHRvIGRlcmVmZXJlbmNlIGEgTlVMTCBwb2ludGVyIHZp YSB0aGUKYWRkcmVzcyBzcGFjZSBwb2ludGVyIHdoZW4gbm8gSU9NTVUgaXMgcHJlc2VudC4gQ29y cmVjdCB0aGlzIGJ5IGFkZGluZwp0aGUgYXBwcm9wcmlhdGUgY2hlY2suCgpTaWduZWQtb2ZmLWJ5 OiBCcmlhbiBNYXNuZXkgPG1hc25leWJAb25zdGF0aW9uLm9yZz4KRml4ZXM6IDU3NWYwNDg1NTA4 YiAoImRybS9tc206IENsZWFuIHVwIGFuZCBlbmhhbmNlIHRoZSBvdXRwdXQgb2YgdGhlICdnZW0n IGRlYnVnZnMgbm9kZSIpClNpZ25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21p dW0ub3JnPgpMaW5rOiBodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvbXNn aWQvMjAxOTA1MTMyMzQxMDUuNzUzMS0yLW1hc25leWJAb25zdGF0aW9uLm9yZwpTaWduZWQtb2Zm LWJ5OiBTYXNoYSBMZXZpbiA8c2FzaGFsQGtlcm5lbC5vcmc+Ci0tLQogZHJpdmVycy9ncHUvZHJt L21zbS9tc21fZ2VtLmMgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2dlbS5j IGIvZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ2VtLmMKaW5kZXggMThjYTY1MWFiOTQyYS4uMjNk ZTRkMWI3YjFhYyAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ2VtLmMKKysr IGIvZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ2VtLmMKQEAgLTgwNSw3ICs4MDUsOCBAQCB2b2lk IG1zbV9nZW1fZGVzY3JpYmUoc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmosIHN0cnVjdCBzZXFf ZmlsZSAqbSkKIAkJc2VxX3B1dHMobSwgIiAgICAgIHZtYXM6Iik7CiAKIAkJbGlzdF9mb3JfZWFj aF9lbnRyeSh2bWEsICZtc21fb2JqLT52bWFzLCBsaXN0KQotCQkJc2VxX3ByaW50ZihtLCAiIFsl czogJTA4bGx4LCVzLGludXNlPSVkXSIsIHZtYS0+YXNwYWNlLT5uYW1lLAorCQkJc2VxX3ByaW50 ZihtLCAiIFslczogJTA4bGx4LCVzLGludXNlPSVkXSIsCisJCQkJdm1hLT5hc3BhY2UgIT0gTlVM TCA/IHZtYS0+YXNwYWNlLT5uYW1lIDogTlVMTCwKIAkJCQl2bWEtPmlvdmEsIHZtYS0+bWFwcGVk ID8gIm1hcHBlZCIgOiAidW5tYXBwZWQiLAogCQkJCXZtYS0+aW51c2UpOwogCi0tIAoyLjIwLjEK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkZyZWVkcmVu byBtYWlsaW5nIGxpc3QKRnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVubw==